Issues in Threatmetrix.php (master) - Issues in master - clippings/omnipay-emp - Measure and Improve Code Quality continuously with Scrutinizer

Issues (8)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Threatmetrix.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Omnipay\Emp;

/**
 * @author    Ivan Kerin <[email protected]>
 * @copyright 2014, Clippings Ltd.
 * @license   http://spdx.org/licenses/BSD-3-Clause
 */
class Threatmetrix
{
    /**
     * @var string
     */
    private $organizationId;

    /**
     * @var string
     */
    private $sessionId;

    /**
     * @var string
     */
    private $session;

    /**
     * @param string $organizationId
     * @param string $clientId
     */
    public function __construct($organizationId, $clientId)
    {
        $this->organizationId = $organizationId;
        $this->sessionId = $clientId.date('Ymdhis').rand(100000,999999);;
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
        $this->session = md5(rand());
    }

    /**
     * @return string
     */
    public function getOrganizationId()
    {
        return $this->organizationId;
    }

    /**
     * @return string
     */
    public function getSessionId()
    {
        return $this->sessionId;
    }

    /**
     * @return string
     */
    public function getSession()
    {
        return $this->session;
    }

    /**
     * @return string
     */
    public function getUrlQuery()
    {
        return http_build_query(array(
            'org_id' => $this->organizationId,
            'session_id' => $this->sessionId,
        ));
    }

    /**
     * Return the tracking code, that has to be placed to the page where the payment form is
     *
     * @return string
     */
    public function getTrackingCode()
    {
        $urlQuery = $this->getUrlQuery();

        return <<<TRACKING
<div style="position:absolute;left:0;bottom:0">
<p style="margin:0;background:url(https://h.online-metrix.net/fp/clear.png?{$urlQuery}&session2={$this->session}&m=1)"></p>
<img src="https://h.online-metrix.net/fp/clear.png?{$urlQuery}&m=2"/>
<script src="https://h.online-metrix.net/fp/check.js?{$urlQuery}"></script>
<object type="application/x-shockwave-flash" data="https://h.online-metrix.net/fp/fp.swf?{$urlQuery}" width="1" height="1" id="thm_fp">
<param name="movie" value="https://h.online-metrix.net/fp/fp.swf?{$urlQuery}" />
</object>
</div>
TRACKING;
    }

    /**
     * @return string
     */
    public function getTrackingUrl()
    {
        $urlQuery = $this->getUrlQuery();

        return "https://h.online-metrix.net/fp/clear.png?{$urlQuery}&m=2";
    }
}


1		<?php
2
3		namespace Omnipay\Emp;
4
5		/**
6		* @author Ivan Kerin <[email protected]>
7		* @copyright 2014, Clippings Ltd.
8		* @license http://spdx.org/licenses/BSD-3-Clause
9		*/
10		class Threatmetrix
11		{
12		/**
13		* @var string
14		*/
15		private $organizationId;
16
17		/**
18		* @var string
19		*/
20		private $sessionId;
21
22		/**
23		* @var string
24		*/
25		private $session;
26
27		/**
28		* @param string $organizationId
29		* @param string $clientId
30		*/
31	1	public function __construct($organizationId, $clientId)
32		{
33	1	$this->organizationId = $organizationId;
34	1	$this->sessionId = $clientId.date('Ymdhis').rand(100000,999999);;
		0 ignored issues – show Coding Style introduced 2016-07-19 15:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
35	1	$this->session = md5(rand());
36	1	}
37
38		/**
39		* @return string
40		*/
41	1	public function getOrganizationId()
42		{
43	1	return $this->organizationId;
44		}
45
46		/**
47		* @return string
48		*/
49	1	public function getSessionId()
50		{
51	1	return $this->sessionId;
52		}
53
54		/**
55		* @return string
56		*/
57	1	public function getSession()
58		{
59	1	return $this->session;
60		}
61
62		/**
63		* @return string
64		*/
65	1	public function getUrlQuery()
66		{
67	1	return http_build_query(array(
68	1	'org_id' => $this->organizationId,
69	1	'session_id' => $this->sessionId,
70	1	));
71		}
72
73		/**
74		* Return the tracking code, that has to be placed to the page where the payment form is
75		*
76		* @return string
77		*/
78	1	public function getTrackingCode()
79		{
80	1	$urlQuery = $this->getUrlQuery();
81
82		return <<<TRACKING
83		<div style="position:absolute;left:0;bottom:0">
84	1	<p style="margin:0;background:url(https://h.online-metrix.net/fp/clear.png?{$urlQuery}&session2={$this->session}&m=1)"></p>
85	1	<img src="https://h.online-metrix.net/fp/clear.png?{$urlQuery}&m=2"/>
86	1	<script src="https://h.online-metrix.net/fp/check.js?{$urlQuery}"></script>
87	1	<object type="application/x-shockwave-flash" data="https://h.online-metrix.net/fp/fp.swf?{$urlQuery}" width="1" height="1" id="thm_fp">
88	1	<param name="movie" value="https://h.online-metrix.net/fp/fp.swf?{$urlQuery}" />
89		</object>
90	1	</div>
91	1	TRACKING;
92		}
93
94		/**
95		* @return string
96		*/
97	1	public function getTrackingUrl()
98		{
99	1	$urlQuery = $this->getUrlQuery();
100
101	1	return "https://h.online-metrix.net/fp/clear.png?{$urlQuery}&m=2";
102		}
103		}
104

clippings / omnipay-emp

Issues (8)

Security Analysis not enabled

src/Threatmetrix.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like