Issues in Item.php (master) - Issues in master - clippings/fluid-gallery - Measure and Improve Code Quality continuously with Scrutinizer

Issues (5)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Item.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace CL\FluidGallery;

/**
 * @author    Ivan Kerin <[email protected]>
 * @copyright 2015, Clippings Ltd.
 * @license   http://spdx.org/licenses/BSD-3-Clause
 */
class Item
{
    /**
     * @var integer
     */
    private $originalWidth;

    /**
     * @var integer
     */
    private $originalHeight;

    /**
     * @var float|integer
     */
    private $width;

    /**
     * @var float|integer
     */
    private $height;

    /**
     * @var mixed
     */
    private $content;

    /**
     * @param string  $url
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param integer $width
     * @param integer $height
     * @param mixed   $content
     */
    function __construct($width, $height, $content = null) {

        $this->originalWidth = $this->width = (int) $width;
        $this->originalHeight = $this->height = (int) $height;
        $this->content = $content;
    }

    /**
     * @return float|integer
     */
    public function getWidth()
    {
        return $this->width;
    }

    /**
     * @return float|integer
     */
    public function getHeight()
    {
        return $this->height;
    }

    /**
     * @param float $total
     * @return float
     */
    public function getWidthPercent($total)
    {
        return ($this->width / $total) * 100;
    }

    /**
     * @param float $total
     * @return float
     */
    public function getHeightPercent($total)
    {
        return ($this->height / $total) * 100;
    }

    /**
     * set width, keeping aspect ratio
     *
     * @param integer $width
     */
    public function setWidth($width)
    {
        $this->width = $width;
        $this->height = $width / $this->getAspect();
    }

    /**
     * set height, keeping aspect ratio
     *
     * @param integer $height
     */
    public function setHeight($height)
    {
        $this->height = $height;
        $this->width = $height * $this->getAspect();
    }

    /**
     * @return float
     */
    public function getScale()
    {
        return $this->width/$this->originalWidth;
    }

    /**
     * @return integer
     */
    public function getOriginalWidth()
    {
        return $this->originalWidth;
    }

    /**
     * @return integer
     */
    public function getOriginalHeight()
    {
        return $this->originalHeight;
    }

    /**
     * @return float
     */
    public function getAspect()
    {
        return $this->originalWidth / $this->originalHeight;
    }

    /**
     * @return boolean
     */
    public function isLandscape()
    {
        return $this->getAspect() > 1;
    }

    /**
     * @return boolean
     */
    public function isPortrait()
    {
        return $this->getAspect() < 1;
    }

    /**
     * @return boolean
     */
    public function isSquare()
    {
        return $this->getAspect() == 1;
    }

    /**
     * @return string
     */
    public function getContent()
    {
        return $this->content;
    }

    public function __toString()
    {
        return "[Image {$this->originalWidth}x{$this->originalHeight} ({$this->content})]";
    }
}


1		<?php
2
3		namespace CL\FluidGallery;
4
5		/**
6		* @author Ivan Kerin <[email protected]>
7		* @copyright 2015, Clippings Ltd.
8		* @license http://spdx.org/licenses/BSD-3-Clause
9		*/
10		class Item
11		{
12		/**
13		* @var integer
14		*/
15		private $originalWidth;
16
17		/**
18		* @var integer
19		*/
20		private $originalHeight;
21
22		/**
23		* @var float\|integer
24		*/
25		private $width;
26
27		/**
28		* @var float\|integer
29		*/
30		private $height;
31
32		/**
33		* @var mixed
34		*/
35		private $content;
36
37		/**
38		* @param string $url
		0 ignored issues – show Bug introduced 2017-03-04 20:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$url`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
39		* @param integer $width
40		* @param integer $height
41		* @param mixed $content
42		*/
43	1	function __construct($width, $height, $content = null) {
		0 ignored issues – show Best Practice introduced 2017-03-04 20:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
44	1	$this->originalWidth = $this->width = (int) $width;
45	1	$this->originalHeight = $this->height = (int) $height;
46	1	$this->content = $content;
47	1	}
48
49		/**
50		* @return float\|integer
51		*/
52	3	public function getWidth()
53		{
54	3	return $this->width;
55		}
56
57		/**
58		* @return float\|integer
59		*/
60	3	public function getHeight()
61		{
62	3	return $this->height;
63		}
64
65		/**
66		* @param float $total
67		* @return float
68		*/
69	1	public function getWidthPercent($total)
70		{
71	1	return ($this->width / $total) * 100;
72		}
73
74		/**
75		* @param float $total
76		* @return float
77		*/
78	1	public function getHeightPercent($total)
79		{
80	1	return ($this->height / $total) * 100;
81		}
82
83		/**
84		* set width, keeping aspect ratio
85		*
86		* @param integer $width
87		*/
88	1	public function setWidth($width)
89		{
90	1	$this->width = $width;
91	1	$this->height = $width / $this->getAspect();
92	1	}
93
94		/**
95		* set height, keeping aspect ratio
96		*
97		* @param integer $height
98		*/
99	1	public function setHeight($height)
100		{
101	1	$this->height = $height;
102	1	$this->width = $height * $this->getAspect();
103	1	}
104
105		/**
106		* @return float
107		*/
108	2	public function getScale()
109		{
110	2	return $this->width/$this->originalWidth;
111		}
112
113		/**
114		* @return integer
115		*/
116	3	public function getOriginalWidth()
117		{
118	3	return $this->originalWidth;
119		}
120
121		/**
122		* @return integer
123		*/
124	3	public function getOriginalHeight()
125		{
126	3	return $this->originalHeight;
127		}
128
129		/**
130		* @return float
131		*/
132	1	public function getAspect()
133		{
134	1	return $this->originalWidth / $this->originalHeight;
135		}
136
137		/**
138		* @return boolean
139		*/
140	3	public function isLandscape()
141		{
142	3	return $this->getAspect() > 1;
143		}
144
145		/**
146		* @return boolean
147		*/
148	3	public function isPortrait()
149		{
150	3	return $this->getAspect() < 1;
151		}
152
153		/**
154		* @return boolean
155		*/
156	3	public function isSquare()
157		{
158	3	return $this->getAspect() == 1;
159		}
160
161		/**
162		* @return string
163		*/
164	1	public function getContent()
165		{
166	1	return $this->content;
167		}
168
169	1	public function __toString()
170		{
171	1	return "[Image {$this->originalWidth}x{$this->originalHeight} ({$this->content})]";
172		}
173		}
174

clippings / fluid-gallery

Issues (5)

Security Analysis no request data

src/Item.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like