Holidays::isActive() - Code Metrics - Inspection of "Refactor methods" - clippings/date-utils - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c3c9bb...0739ce )

by Ivan

created 2015-12-02 18:40 UTC

Holidays::isActive() A

↳ Parent: Holidays

Complexity

Conditions	4
Paths	6

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
ccs	7
cts	7
cp	1
rs	9.2
cc	4
eloc	6
nc	6
nop	1
crap	4

<?php

namespace CL\DateUtils;

use DateTime;
use Countable;

/**
 * @author    Ivan Kerin <[email protected]>
 * @copyright 2015, Clippings Ltd.
 * @license   http://spdx.org/licenses/BSD-3-Clause
 */
class Holidays implements Countable
{
    /**
     * @var DateTime[]
     */
    private $dates;

    public function __construct(array $dates = array())
    {
        foreach ($dates as $date) {
            $this->add($date);
        }
    }

    /**
     * @return boolean
     */
    public function isEmpty()
    {
        return empty($this->dates);
    }

    /**
     * Implement countable
     *
     * @return integer
     */
    public function count()
    {
        return count($this->dates);
    }

    /**
     * @return DateTime[]
     */
    public function getDates()
    {
        return $this->dates;
    }

    /**
     * @param DateTime $current
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param DateTime $to
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function addDateTimeSpan(DateTimeSpan $span)
    {
        $current = clone $span->getFrom();

        while ($current <= $span->getTo()) {
            $this->add($current);

            $current = clone $current;
            $current->modify('+1 day');
        }

        return $this;
    }

    /**
     * @param DateTime $day
     */
    public function add(DateTime $day)
    {
        $this->dates []= $day;

        sort($this->dates);

        return $this;
    }

    /**
     * Check if a date is within any holiday
     *
     * @param  DateTime $date
     * @return boolean
     */
    public function isActive(DateTime $date = null)
    {
        $date = $date ?: new DateTime();

        foreach ($this->dates as $holiday) {
            if ($date->format('Y-m-d') == $holiday->format('Y-m-d')) {
                return true;
            }
        }

        return false;
    }

    /**
     * @param  DateTime $from
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param  DateTime $date
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return DateTime
     */
    public function extendDateTimeSpan(DateTimeSpan $span)
    {
        $to = clone $span->getTo();

        foreach ($this->dates as $holiday) {
            if ($holiday > $span->getFrom() and $holiday < $to) {
                $to->modify('+1 day');
            }
        }

        return new DateTimeSpan($span->getFrom(), $to);
    }
}


1		<?php
2
3		namespace CL\DateUtils;
4
5		use DateTime;
6		use Countable;
7
8		/**
9		* @author Ivan Kerin <[email protected]>
10		* @copyright 2015, Clippings Ltd.
11		* @license http://spdx.org/licenses/BSD-3-Clause
12		*/
13		class Holidays implements Countable
14		{
15		/**
16		* @var DateTime[]
17		*/
18		private $dates;
19
20	1	public function __construct(array $dates = array())
21		{
22	1	foreach ($dates as $date) {
23	1	$this->add($date);
24	1	}
25	1	}
26
27		/**
28		* @return boolean
29		*/
30	1	public function isEmpty()
31		{
32	1	return empty($this->dates);
33		}
34
35		/**
36		* Implement countable
37		*
38		* @return integer
39		*/
40	1	public function count()
41		{
42	1	return count($this->dates);
43		}
44
45		/**
46		* @return DateTime[]
47		*/
48	1	public function getDates()
49		{
50	1	return $this->dates;
51		}
52
53		/**
54		* @param DateTime $current
		0 ignored issues – show Bug introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report There is no parameter named `$current`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
55		* @param DateTime $to
		0 ignored issues – show Bug introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report There is no parameter named `$to`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
56		*/
57	1	public function addDateTimeSpan(DateTimeSpan $span)
58		{
59	1	$current = clone $span->getFrom();
60
61	1	while ($current <= $span->getTo()) {
62	1	$this->add($current);
63
64	1	$current = clone $current;
65	1	$current->modify('+1 day');
66	1	}
67
68	1	return $this;
69		}
70
71		/**
72		* @param DateTime $day
73		*/
74	1	public function add(DateTime $day)
75		{
76	1	$this->dates []= $day;
77
78	1	sort($this->dates);
79
80	1	return $this;
81		}
82
83		/**
84		* Check if a date is within any holiday
85		*
86		* @param DateTime $date
87		* @return boolean
88		*/
89	1	public function isActive(DateTime $date = null)
90		{
91	1	$date = $date ?: new DateTime();
92
93	1	foreach ($this->dates as $holiday) {
94	1	if ($date->format('Y-m-d') == $holiday->format('Y-m-d')) {
95	1	return true;
96		}
97	1	}
98
99	1	return false;
100		}
101
102		/**
103		* @param DateTime $from
		0 ignored issues – show Bug introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report There is no parameter named `$from`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
104		* @param DateTime $date
		0 ignored issues – show Bug introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report There is no parameter named `$date`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
105		* @return DateTime
106		*/
107	1	public function extendDateTimeSpan(DateTimeSpan $span)
108		{
109	1	$to = clone $span->getTo();
110
111	1	foreach ($this->dates as $holiday) {
112	1	if ($holiday > $span->getFrom() and $holiday < $to) {
113	1	$to->modify('+1 day');
114	1	}
115	1	}
116
117	1	return new DateTimeSpan($span->getFrom(), $to);
118		}
119		}
120

clippings / date-utils

Push — master ( c3c9bb...0739ce )

Holidays::isActive() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like