CL\Matrix\Vector\AbstractVector

Complexity

Total Complexity

7

Size/Duplication

Total Lines	62
Duplicated Lines	17.74 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

77.78%

Importance

Changes	3
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	4
A	getElement()	11	11	2
A	getElements()	0	4	1

<?php

namespace CL\Matrix\Vector;

use CL\Matrix\Element;
use CL\Matrix\Matrix;

abstract class AbstractVector implements VectorInterface
{
    /**
     * @var Element[]
     */
    protected $elements = [];

    /**
     * @var Matrix|null
     */
    protected $matrix;

    /**
     * @var int|null
     */
    protected $matrixOffset;

    /**
     * @param Element[] $elements
     * @param Matrix    $matrix
     * @param int|null  $matrixOffset
     */
    public function __construct(array $elements = [], Matrix $matrix = null, $matrixOffset = null)
    {
        foreach ($elements as $offset => $element) {
            $this->setElement($offset, $element);
        }

        if ($matrix) {
            if (!$matrixOffset) {

The expression $matrixOffset of type integer|null is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

                throw new \InvalidArgumentException('You must also supply a matrix offset when setting the matrix');
            }

            $this->setMatrix($matrix, $matrixOffset);
        }
    }

    /**
     * @param int $offset
     *
     * @return Element
     */
    public function getElement($offset)

This method seems to be duplicated in your project.

    {
        if (!array_key_exists($offset, $this->elements)) {
            throw new \InvalidArgumentException(sprintf(
                'There is no element in this vector with that offset: %s',
                $offset
            ));
        }

        return $this->elements[$offset];
    }

    /**
     * @return Element[]
     */
    public function getElements()
    {
        return $this->elements;
    }
}