TestCommand::fire() - Code Metrics - clarkeash/factory - Measure and Improve Code Quality continuously with Scrutinizer

TestCommand::fire() A
last analyzed 2016-02-01 00:41 UTC

↳ Parent: TestCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	17
rs	9.4285
cc	2
eloc	8
nc	2
nop	0

<?php

namespace Factory\Console\Make;

use Factory\Composer;
use Factory\Console\BaseCommand;
use Factory\Generators\TestGenerator;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputOption;

class TestCommand extends BaseCommand
{
    /**
     * @var TestGenerator
     */
    private $generator;
    /**
     * @var \Factory\Composer
     */
    private $composer;

    public function __construct(Composer $composer, TestGenerator $generator)
    {
        parent::__construct();
        $this->generator = $generator;
        $this->composer = $composer;
    }

    public function configure()
    {
        $this->setName('make:test');
        $this->setDescription('Create a test.');

        $this->addArgument('name', InputArgument::REQUIRED, 'The name of the class to make a test for.');
        $this->addOption('force', null, InputOption::VALUE_NONE, 'The class should overwrite an existing one.');
    }

    public function fire()
    {
        $data = [
            'name' => $this->argument('name'),
        ];

        $result = $this->generator->setData($data)->setForce($this->option('force'))->make();
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if ($result)
        {
            $this->info('Test: ' . $this->composer->getTestPath($this->argument('name')) . ' created');
        }
        else
        {
            $this->error('Something went wrong!');
        }
    }
}


1			<?php
2
3			namespace Factory\Console\Make;
4
5			use Factory\Composer;
6			use Factory\Console\BaseCommand;
7			use Factory\Generators\TestGenerator;
8			use Symfony\Component\Console\Input\InputArgument;
9			use Symfony\Component\Console\Input\InputOption;
10
11			class TestCommand extends BaseCommand
12			{
13			/**
14			* @var TestGenerator
15			*/
16			private $generator;
17			/**
18			* @var \Factory\Composer
19			*/
20			private $composer;
21
22			public function __construct(Composer $composer, TestGenerator $generator)
23			{
24			parent::__construct();
25			$this->generator = $generator;
26			$this->composer = $composer;
27			}
28
29			public function configure()
30			{
31			$this->setName('make:test');
32			$this->setDescription('Create a test.');
33
34			$this->addArgument('name', InputArgument::REQUIRED, 'The name of the class to make a test for.');
35			$this->addOption('force', null, InputOption::VALUE_NONE, 'The class should overwrite an existing one.');
36			}
37
38			public function fire()
39			{
40			$data = [
41			'name' => $this->argument('name'),
42			];
43
44			$result = $this->generator->setData($data)->setForce($this->option('force'))->make();
			0 ignored issues – show Documentation introduced 2016-01-28 23:37 UTC by Report Bug Copy Issue Report `$this->option('force')` is of type `string\|array`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45
46			if ($result)
47			{
48			$this->info('Test: ' . $this->composer->getTestPath($this->argument('name')) . ' created');
49			}
50			else
51			{
52			$this->error('Something went wrong!');
53			}
54			}
55			}
56

clarkeash / factory

TestCommand::fire() A last analyzed 2016-02-01 00:41 UTC

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like

TestCommand::fire() A
last analyzed 2016-02-01 00:41 UTC