Issues in AbstractApi.php (master) - Issues in master - ck-developer/emarsys-php-client - Measure and Improve Code Quality continuously with Scrutinizer

Issues (10)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Api/AbstractApi.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * A php library for using the Emarsys API.
 *
 * @link      https://github.com/quitoque/emarsys-php-client
 * @package   emarsys-php-client
 * @license   MIT
 * @copyright Copyright (c) 2017 Quitoque <[email protected]>
 */

namespace Emarsys\Api;

use Http\Client\Common\PluginClient;
use Http\Client\HttpAsyncClient;
use Http\Message\RequestFactory;
use Http\Promise\Promise;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * Class AbstractApi.
 *
 * @author Claude Khedhiri <[email protected]>
 */
abstract class AbstractApi implements ApiInterface
{
    /**
     * @var HttpAsyncClient
     */
    private $httpClient;

    /**
     * @var RequestFactory
     */
    private $requestFactory;

    /**
     * AbstractApi constructor.
     *
     * @param PluginClient   $httpClient
     * @param RequestFactory $requestFactory
     */
    public function __construct(PluginClient $httpClient, RequestFactory $requestFactory)
    {
        $this->httpClient = $httpClient;
        $this->requestFactory = $requestFactory;
    }

    /**
     * @param string     $method
     * @param string     $uri
     * @param array      $headers
     * @param array|null $body
     *
     * @return RequestInterface
     */
    protected function createRequest($method, $uri, array $headers = array(), $body = null)
    {
        return $this->requestFactory->createRequest(
            $method,
            $uri,
            $headers,
            $body

        );
    }

    /**
     * @param RequestInterface $request
     *
     * @return ResponseInterface
     */
    protected function sendRequest(RequestInterface $request)
    {
        return $this->httpClient->sendRequest($request);
    }

    /**
     * @param RequestInterface $request
     *
     * @return Promise
     */
    protected function sendAsyncRequest(RequestInterface $request)
    {
        return $this->httpClient->sendAsyncRequest($request);
    }
}


1		<?php
2
3		/*
4		* A php library for using the Emarsys API.
5		*
6		* @link https://github.com/quitoque/emarsys-php-client
7		* @package emarsys-php-client
8		* @license MIT
9		* @copyright Copyright (c) 2017 Quitoque <[email protected]>
10		*/
11
12		namespace Emarsys\Api;
13
14		use Http\Client\Common\PluginClient;
15		use Http\Client\HttpAsyncClient;
16		use Http\Message\RequestFactory;
17		use Http\Promise\Promise;
18		use Psr\Http\Message\RequestInterface;
19		use Psr\Http\Message\ResponseInterface;
20
21		/**
22		* Class AbstractApi.
23		*
24		* @author Claude Khedhiri <[email protected]>
25		*/
26		abstract class AbstractApi implements ApiInterface
27		{
28		/**
29		* @var HttpAsyncClient
30		*/
31		private $httpClient;
32
33		/**
34		* @var RequestFactory
35		*/
36		private $requestFactory;
37
38		/**
39		* AbstractApi constructor.
40		*
41		* @param PluginClient $httpClient
42		* @param RequestFactory $requestFactory
43		*/
44	2	public function __construct(PluginClient $httpClient, RequestFactory $requestFactory)
45		{
46	2	$this->httpClient = $httpClient;
47	2	$this->requestFactory = $requestFactory;
48	2	}
49
50		/**
51		* @param string $method
52		* @param string $uri
53		* @param array $headers
54		* @param array\|null $body
55		*
56		* @return RequestInterface
57		*/
58		protected function createRequest($method, $uri, array $headers = array(), $body = null)
59		{
60		return $this->requestFactory->createRequest(
61		$method,
62		$uri,
63		$headers,
64		$body
		0 ignored issues – show Bug introduced 2017-07-07 10:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$body` defined by parameter `$body` on line 58 can also be of type `array`; however, `Http\Message\RequestFactory::createRequest()` does only seem to accept `resource\|string\|object<P...e\StreamInterface>\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
65		);
66		}
67
68		/**
69		* @param RequestInterface $request
70		*
71		* @return ResponseInterface
72		*/
73		protected function sendRequest(RequestInterface $request)
74		{
75		return $this->httpClient->sendRequest($request);
76		}
77
78		/**
79		* @param RequestInterface $request
80		*
81		* @return Promise
82		*/
83		protected function sendAsyncRequest(RequestInterface $request)
84		{
85		return $this->httpClient->sendAsyncRequest($request);
86		}
87		}
88

ck-developer / emarsys-php-client

Issues (10)

Security Analysis no request data

src/Api/AbstractApi.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like