Emarsys\HttpClient\Builder

Complexity

Total Complexity

13

Size/Duplication

Total Lines	140
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Test Coverage

Coverage

63.04%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	3
A	setHttpClient()	0	4	1
A	setRequestFactory()	0	4	1
A	setParameters()	0	4	1
A	resolveParameters()	0	8	1
A	getRequestFactory()	0	4	1
A	addPlugin()	0	5	1
A	getHttpClient()	0	22	2
A	removePlugin()	0	6	2

<?php

/*
 * A php library for using the Emarsys API.
 *
 * @link      https://github.com/quitoque/emarsys-php-client
 * @package   emarsys-php-client
 * @license   MIT
 * @copyright Copyright (c) 2017 Quitoque <tech@quitoque.com>
 */

namespace Emarsys\HttpClient;

use Emarsys\HttpClient\Message\Authentication\Wsse;
use Http\Client\Common\Plugin;
use Http\Client\Common\PluginClient;
use Http\Client\HttpAsyncClient;
use Http\Discovery\HttpAsyncClientDiscovery;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Discovery\UriFactoryDiscovery;
use Http\Message\MessageFactory;
use Http\Message\RequestFactory;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
 * Class Builder.
 *
 * @author Claude Khedhiri <claude@khedhiri.com>
 */
class Builder
{
    /**
     * @var HttpAsyncClient
     */
    private $httpClient;

    /**
     * @var array
     */
    private $parameters;

    /**
     * @var MessageFactory
     */
    private $requestFactory;

    /**
     * A HTTP client with all our plugins.
     *
     * @var PluginClient
     */
    private $pluginClient;

    /**
     * True if we should create a new Plugin client at next request.
     *
     * @var bool
     */
    private $httpClientModified = true;

    /**
     * @var Plugin[]
     */
    private $plugins = array();

    /**
     * @param array                $parameters
     * @param HttpAsyncClient|null $httpAsyncClient
     * @param RequestFactory|null  $requestFactory
     */
    public function __construct(
        array $parameters = array(),

The parameter $parameters is not used and could be removed.

        HttpAsyncClient $httpAsyncClient = null,
        RequestFactory $requestFactory = null
    ) {
        $this->httpClient = $httpAsyncClient ?: HttpAsyncClientDiscovery::find();
        $this->requestFactory = $requestFactory ?: MessageFactoryDiscovery::find();

It seems like $requestFactory ?: \Http\Discovery\MessageFactoryDiscovery::find() can also be of type object<Http\Message\RequestFactory>. However, the property $requestFactory is declared as type object<Http\Message\MessageFactory>. Maybe add an additional type check?

    }

    /**
     * @param HttpAsyncClient $httpAsyncClient
     */
    public function setHttpClient(HttpAsyncClient $httpAsyncClient)
    {
        $this->httpClient = $httpAsyncClient;
    }

    /**
     * @param MessageFactory $requestFactory
     */
    public function setRequestFactory($requestFactory)
    {
        $this->requestFactory = $requestFactory;
    }

    /**
     * @param array $parameters
     */
    public function setParameters(array $parameters)
    {
        $this->parameters = $parameters;
    }

    public function resolveParameters()
    {
        $resolver = new OptionsResolver();
        $resolver->setRequired('username');
        $resolver->setRequired('secret');

        $this->parameters = $resolver->resolve($this->parameters);
    }

    /**
     * @return PluginClient
     */
    public function getHttpClient()
    {
        if ($this->httpClientModified) {
            $this->addPlugin(new Plugin\AuthenticationPlugin(new Wsse(
                    $this->parameters['username'],
                    $this->parameters['secret'])
            ));

            $this->addPlugin(new Plugin\BaseUriPlugin(
                    UriFactoryDiscovery::find()->createUri('https://api.emarsys.net/api/v2'))
            );

            $this->addPlugin(new Plugin\HeaderDefaultsPlugin(array(
                'User-Agent' => 'emarsys-php-client (https://github.com/ck-developer/emarsys-php-client)',
            )));

            $this->httpClientModified = false;
            $this->pluginClient = new PluginClient($this->httpClient, $this->plugins);
        }

        return $this->pluginClient;
    }

    /**
     * @return MessageFactory
     */
    public function getRequestFactory()
    {
        return $this->requestFactory;
    }

    /**
     * Add a new plugin to the end of the plugin chain.
     *
     * @param Plugin $plugin
     */
    public function addPlugin(Plugin $plugin)
    {
        $this->plugins[get_class($plugin)] = $plugin;
        $this->httpClientModified = true;
    }

    /**
     * Remove a plugin by its fully qualified class name.
     *
     * @param string $class
     */
    public function removePlugin($class)
    {
        if (array_key_exists($class, $this->plugins)) {
            unset($this->plugins[$class]);
        }
    }
}