cjtterabytesoft\widgets\Export::exportCsv()

Complexity

Conditions	7
Paths	2

Size

Total Lines	36
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	public function exportCsv()
	{
		$csvCharset = $this->_csvCharset;

The assignment to $csvCharset is dead and can be removed.

		$fields = $this->getFieldsKeys($this->_searchModel->exportFields());
		header('Pragma: public');
		header('Expires: 0');
		header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
		header('Content-Description: File Transfer');
		header('Content-Type: text/csv');
		$filename = $this->_tableName . '.csv';
		header('Content-Disposition: attachment;filename=' . $filename);
		header('Content-Transfer-Encoding: binary');
		$fp = fopen('php://output', 'w');
		fwrite($fp, $bom = (chr(0xEF) . chr(0xBB) . chr(0xBF)));

It seems like $fp can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

		if ($fp) {

$fp is of type resource|false, thus it always evaluated to false.

			$items = [];
			$i = 0;
			foreach ($fields as $one) {
				$items[$i] = $one;
				$i++;
			}
			fwrite($fp, implode($items, ',') . "\n");
			$items = [];
			$i = 0;
			foreach ($this->_dataProvider->getModels() as $model) {
				foreach ($this->_searchModel->exportFields() as $one) {
					$item = str_replace('"', '\"', is_string($one) ? $model[$one] : $one($model));
					$items[$i] = ($item) ? '"' . $item . '"' : $item;
					$i++;
				}
				fwrite($fp, implode($items, ',') . "\n");
				$items = [];
				$i = 0;
			}
		}
		fclose($fp);

It seems like $fp can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

	}