Milestone::find() - Code Metrics - ciromattia/laravel-teamwork - Measure and Improve Code Quality continuously with Scrutinizer

Milestone::find() A
last analyzed 2018-04-26 17:30 UTC

↳ Parent: Milestone

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php

namespace Ciromattia\Teamwork;

use Ciromattia\Teamwork\Traits\RestfulTrait;

class Milestone extends TeamworkObject
{
    use RestfulTrait;

    protected $wrapper = 'milestone';
    protected $endpoint = 'milestones';

    /**
     * GET /milestones.json
     *
     * @param null $args
     *
     * @return mixed
     */
    public function all($args = null)
    {
        $this->areArgumentsValid($args, ['getProgress']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $this->client->get($this->endpoint, $args)->response();
    }

    /**
     * GET /milestones/{milestone_id}.json
     *
     * @param null $args
     *
     * @return mixed
     */
    public function find($args = null)
    {
        $this->areArgumentsValid($args, ['getProgress', 'showTaskLists', 'showTasks']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $this->client->get("$this->endpoint/$this->id", $args)->response();
    }

    /**
     * PUT /milestones/{id}/complete.json
     *
     * @param array $data
     *
     * @return
     */
    public function complete($data = [])
    {
        return $this->client->put("$this->endpoint/$this->id/complete", [$this->wrapper => $data])->response();
    }

    /**
     * PUT /milestones/{id}/uncomplete.json
     *
     * @param array $data
     *
     * @return
     */
    public function uncomplete($data = [])
    {
        return $this->client->put("$this->endpoint/$this->id/uncomplete", [$this->wrapper => $data])->response();
    }
}

1			<?php
2
3			namespace Ciromattia\Teamwork;
4
5			use Ciromattia\Teamwork\Traits\RestfulTrait;
6
7			class Milestone extends TeamworkObject
8			{
9			use RestfulTrait;
10
11			protected $wrapper = 'milestone';
12			protected $endpoint = 'milestones';
13
14			/**
15			* GET /milestones.json
16			*
17			* @param null $args
18			*
19			* @return mixed
20			*/
21			public function all($args = null)
22			{
23			$this->areArgumentsValid($args, ['getProgress']);
			0 ignored issues – show Documentation introduced 2018-04-06 07:32 UTC by Report Bug Copy Issue Report `$args` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24
25			return $this->client->get($this->endpoint, $args)->response();
26			}
27
28			/**
29			* GET /milestones/{milestone_id}.json
30			*
31			* @param null $args
32			*
33			* @return mixed
34			*/
35			public function find($args = null)
36			{
37			$this->areArgumentsValid($args, ['getProgress', 'showTaskLists', 'showTasks']);
			0 ignored issues – show Documentation introduced 2018-04-06 07:32 UTC by Report Bug Copy Issue Report `$args` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38
39			return $this->client->get("$this->endpoint/$this->id", $args)->response();
40			}
41
42			/**
43			* PUT /milestones/{id}/complete.json
44			*
45			* @param array $data
46			*
47			* @return
48			*/
49			public function complete($data = [])
50			{
51			return $this->client->put("$this->endpoint/$this->id/complete", [$this->wrapper => $data])->response();
52			}
53
54			/**
55			* PUT /milestones/{id}/uncomplete.json
56			*
57			* @param array $data
58			*
59			* @return
60			*/
61			public function uncomplete($data = [])
62			{
63			return $this->client->put("$this->endpoint/$this->id/uncomplete", [$this->wrapper => $data])->response();
64			}
65			}

ciromattia / laravel-teamwork

GitHub Access Token became invalid

Milestone::find() A last analyzed 2018-04-26 17:30 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Milestone::find() A
last analyzed 2018-04-26 17:30 UTC