index-site.php ➔ printMainPage() - Code Metrics - Inspection of "CIL-621 Move "function" definitions out of top-lev..." - cilogon/service - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5a053e...8eeafe )

by Terrence

created 2019-11-18 22:39 UTC

index-site.php ➔ printMainPage() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	96
rs	8.0872
c	0
b	0
f	0

How to fix Long Method

<?php

// error_reporting(E_ALL); ini_set('display_errors',1);

require_once __DIR__ . '/../vendor/autoload.php';
require_once __DIR__ . '/index-functions.php';

use CILogon\Service\Util;
use CILogon\Service\Content;
use CILogon\Service\Loggit;

Util::startPHPSession();

// Check the csrf cookie against either a hidden <form> element or a
// PHP session variable, and get the value of the 'submit' element.
// Note: replace CR/LF with space for 'Show/Hide Help' buttons.
$retchars = array("\r\n","\n","\r");
$submit = str_replace(
    $retchars,
    " ",
    Util::getCsrf()->verifyCookieAndGetSubmit()
);
Util::unsetSessionVar('submit');

$log = new Loggit();
$log->info('submit="' . $submit . '"');

// First, check to see if the info related to the OIDC client exists
// in the current PHP session. If so, continue processing based on the
// 'submit' value. Otherwise, print out error message about bad or
// missing OpenID Connect parameters.
if (verifyOIDCParams()) {
    // Get the OIDC client parameters from the PHP session.
    $clientparams = json_decode(Util::getSessionVar('clientparams'), true);

    // Depending on the value of the clicked 'submit' button or the
    // equivalent PHP session variable, take action or print out HTML.
    switch ($submit) {
        case 'Log On': // Check for OpenID or InCommon usage.
        case 'Continue': // For OOI
            // Need to check for 'max_age' OIDC parameeter. If elapsed time
            // since last user authentication is greater than max_age, then
            // set 'forceauthn' session variable to force the user to
            // (re)authenticate.
            if (isset($clientparams['max_age'])) {
                $max_age = (int)$clientparams['max_age'];
                if (strlen(Util::getSessionVar('authntime')) > 0) {
                    $authntime = (int)Util::getSessionVar('authntime');
                    $currtime = time();
                    if (
                        ($authtime > $currtime) || // Weird error!!!
                        (($currtime - $authtime) > $max_age)
                    ) {
                        Util::setSessionVar('forceauthn', '1');
                    }
                } else { // No authntime - assume no user authentication
                    Util::setSessionVar('forceauthn', '1');
                }
            }
            Content::handleLogOnButtonClicked();
            break; // End case 'Log On'

        case 'gotuser': // Return from the getuser script
            Content::handleGotUser();
            break; // End case 'gotuser'

        case 'Proceed': // Proceed after 'User Changed' or Error page
        case 'Done with Two-Factor':
            Util::verifySessionAndCall('printMainPage');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            break; // End case 'Proceed'

        case 'Cancel': // User denies release of attributes
            // If user clicked the 'Cancel' button, return to the
            // OIDC client with an error message.
            $redirect = 'Location: ' . $clientparams['redirect_uri'] .
                (preg_match('/\?/', $clientparams['redirect_uri']) ? '&' : '?') .
                'error=access_denied&error_description=' .
                'User%20denied%20authorization%20request' .
                ((isset($clientparams['state'])) ?
                    '&state=' . $clientparams['state'] : '');
            Util::unsetAllUserSessionVars();
            header($redirect);
            exit; // No further processing necessary
            break; // End case 'Cancel'

        case 'Manage Two-Factor':
            Util::verifySessionAndCall(
                'CILogon\\Service\\Content::printTwoFactorPage'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
            break; // End case 'Manage Two-Factor'

        case 'Enable':   // Enable / Disable two-factor authentication
        case 'Disable':
        case 'Verify':   // Log in with Google Authenticator
        case 'Disable Two-Factor':
            $enable = !preg_match('/^Disable/', $submit);
            Util::verifySessionAndCall(
                'CILogon\\Service\\Content::handleEnableDisableTwoFactor',
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                array($enable)
            );
            break; // End case 'Enable' / 'Disable'

        case 'I Lost My Phone':
            Util::verifySessionAndCall(
                'CILogon\\Service\\Content::handleILostMyPhone'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
            break; // End case 'I Lost My Phone'

        case 'Enter': // Verify Google Authenticator one time password
            Util::verifySessionAndCall(
                'CILogon\\Service\\Content::handleGoogleAuthenticatorLogin'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
            break; // End case 'Enter'

        case 'EnterDuo': // Verify Duo Security login
            Util::verifySessionAndCall(
                'CILogon\\Service\\Content::handleDuoSecurityLogin'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
            break; // End case 'EnterDuo'

        case 'Show  Help ': // Toggle showing of help text on and off
        case 'Hide  Help ':
            Content::handleHelpButtonClicked();
            break; // End case 'Show Help' / 'Hide Help'

        default: // No submit button clicked nor PHP session submit variable set
            Content::handleNoSubmitButtonClicked();

            break; // End default case
    } // End switch ($submit)
} else { // Failed to verify OIDC client parameters in PHP session
    printOIDCErrorPage();
}


1			<?php
2
3			// error_reporting(E_ALL); ini_set('display_errors',1);
4
5			require_once __DIR__ . '/../vendor/autoload.php';
6			require_once __DIR__ . '/index-functions.php';
7
8			use CILogon\Service\Util;
9			use CILogon\Service\Content;
10			use CILogon\Service\Loggit;
11
12			Util::startPHPSession();
13
14			// Check the csrf cookie against either a hidden <form> element or a
15			// PHP session variable, and get the value of the 'submit' element.
16			// Note: replace CR/LF with space for 'Show/Hide Help' buttons.
17			$retchars = array("\r\n","\n","\r");
18			$submit = str_replace(
19			$retchars,
20			" ",
21			Util::getCsrf()->verifyCookieAndGetSubmit()
22			);
23			Util::unsetSessionVar('submit');
24
25			$log = new Loggit();
26			$log->info('submit="' . $submit . '"');
27
28			// First, check to see if the info related to the OIDC client exists
29			// in the current PHP session. If so, continue processing based on the
30			// 'submit' value. Otherwise, print out error message about bad or
31			// missing OpenID Connect parameters.
32			if (verifyOIDCParams()) {
33			// Get the OIDC client parameters from the PHP session.
34			$clientparams = json_decode(Util::getSessionVar('clientparams'), true);
35
36			// Depending on the value of the clicked 'submit' button or the
37			// equivalent PHP session variable, take action or print out HTML.
38			switch ($submit) {
39			case 'Log On': // Check for OpenID or InCommon usage.
40			case 'Continue': // For OOI
41			// Need to check for 'max_age' OIDC parameeter. If elapsed time
42			// since last user authentication is greater than max_age, then
43			// set 'forceauthn' session variable to force the user to
44			// (re)authenticate.
45			if (isset($clientparams['max_age'])) {
46			$max_age = (int)$clientparams['max_age'];
47			if (strlen(Util::getSessionVar('authntime')) > 0) {
48			$authntime = (int)Util::getSessionVar('authntime');
49			$currtime = time();
50			if (
51			($authtime > $currtime) \|\| // Weird error!!!
52			(($currtime - $authtime) > $max_age)
53			) {
54			Util::setSessionVar('forceauthn', '1');
55			}
56			} else { // No authntime - assume no user authentication
57			Util::setSessionVar('forceauthn', '1');
58			}
59			}
60			Content::handleLogOnButtonClicked();
61			break; // End case 'Log On'
62
63			case 'gotuser': // Return from the getuser script
64			Content::handleGotUser();
65			break; // End case 'gotuser'
66
67			case 'Proceed': // Proceed after 'User Changed' or Error page
68			case 'Done with Two-Factor':
69			Util::verifySessionAndCall('printMainPage');
			0 ignored issues – show Documentation introduced 2017-04-05 19:36 UTC by Report Bug Copy Issue Report `'printMainPage'` is of type `string`, but the function expects a `object<CILogon\Service\function>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
70			break; // End case 'Proceed'
71
72			case 'Cancel': // User denies release of attributes
73			// If user clicked the 'Cancel' button, return to the
74			// OIDC client with an error message.
75			$redirect = 'Location: ' . $clientparams['redirect_uri'] .
76			(preg_match('/\?/', $clientparams['redirect_uri']) ? '&' : '?') .
77			'error=access_denied&error_description=' .
78			'User%20denied%20authorization%20request' .
79			((isset($clientparams['state'])) ?
80			'&state=' . $clientparams['state'] : '');
81			Util::unsetAllUserSessionVars();
82			header($redirect);
83			exit; // No further processing necessary
84			break; // End case 'Cancel'
85
86			case 'Manage Two-Factor':
87			Util::verifySessionAndCall(
88			'CILogon\\Service\\Content::printTwoFactorPage'
			0 ignored issues – show Documentation introduced 2017-04-05 19:36 UTC by Report Bug Copy Issue Report `'CILogon\\Service\\Content::printTwoFactorPage'` is of type `string`, but the function expects a `object<CILogon\Service\function>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
89			);
90			break; // End case 'Manage Two-Factor'
91
92			case 'Enable': // Enable / Disable two-factor authentication
93			case 'Disable':
94			case 'Verify': // Log in with Google Authenticator
95			case 'Disable Two-Factor':
96			$enable = !preg_match('/^Disable/', $submit);
97			Util::verifySessionAndCall(
98			'CILogon\\Service\\Content::handleEnableDisableTwoFactor',
			0 ignored issues – show Documentation introduced 2017-04-05 19:36 UTC by Report Bug Copy Issue Report `'CILogon\\Service\\Conte...EnableDisableTwoFactor'` is of type `string`, but the function expects a `object<CILogon\Service\function>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
99			array($enable)
100			);
101			break; // End case 'Enable' / 'Disable'
102
103			case 'I Lost My Phone':
104			Util::verifySessionAndCall(
105			'CILogon\\Service\\Content::handleILostMyPhone'
			0 ignored issues – show Documentation introduced 2017-04-05 19:36 UTC by Report Bug Copy Issue Report `'CILogon\\Service\\Content::handleILostMyPhone'` is of type `string`, but the function expects a `object<CILogon\Service\function>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
106			);
107			break; // End case 'I Lost My Phone'
108
109			case 'Enter': // Verify Google Authenticator one time password
110			Util::verifySessionAndCall(
111			'CILogon\\Service\\Content::handleGoogleAuthenticatorLogin'
			0 ignored issues – show Documentation introduced 2017-04-05 19:36 UTC by Report Bug Copy Issue Report `'CILogon\\Service\\Conte...ogleAuthenticatorLogin'` is of type `string`, but the function expects a `object<CILogon\Service\function>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
112			);
113			break; // End case 'Enter'
114
115			case 'EnterDuo': // Verify Duo Security login
116			Util::verifySessionAndCall(
117			'CILogon\\Service\\Content::handleDuoSecurityLogin'
			0 ignored issues – show Documentation introduced 2017-04-05 19:36 UTC by Report Bug Copy Issue Report `'CILogon\\Service\\Conte...handleDuoSecurityLogin'` is of type `string`, but the function expects a `object<CILogon\Service\function>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
118			);
119			break; // End case 'EnterDuo'
120
121			case 'Show Help ': // Toggle showing of help text on and off
122			case 'Hide Help ':
123			Content::handleHelpButtonClicked();
124			break; // End case 'Show Help' / 'Hide Help'
125
126			default: // No submit button clicked nor PHP session submit variable set
127			Content::handleNoSubmitButtonClicked();
128
129			break; // End default case
130			} // End switch ($submit)
131			} else { // Failed to verify OIDC client parameters in PHP session
132			printOIDCErrorPage();
133			}
134

cilogon / service

Push — master ( 5a053e...8eeafe )

index-site.php ➔ printMainPage() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like