Complex classes like Util often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Util, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
27 | class Util |
||
28 | { |
||
29 | /** |
||
30 | * @var array $ini_array Read the cilogon.ini file into an array |
||
31 | */ |
||
32 | public static $ini_array = null; |
||
33 | |||
34 | /** |
||
35 | * @var TimeIt $timeit Initialize by calling static::startTiming() in |
||
36 | * init(). |
||
37 | */ |
||
38 | public static $timeit; |
||
39 | |||
40 | /** |
||
41 | * @var IdPList $idplist A 'global' IdpList object since dplist.xml is |
||
42 | * large and expensive to create multiple times. |
||
43 | */ |
||
44 | public static $idplist = null; |
||
45 | |||
46 | /** |
||
47 | * @var CSRF $csrf A 'global' CSRF token object to set the CSRF cookie |
||
48 | * and print the hidden CSRF form element. Needs to be set only once |
||
49 | * to keep the same CSRF value through the session. |
||
50 | */ |
||
51 | public static $csrf = null; |
||
52 | |||
53 | /** |
||
54 | * @var Skin $skin A 'global' Skin object for skin configuration. |
||
55 | */ |
||
56 | public static $skin = null; |
||
57 | |||
58 | /** |
||
59 | * @var array $oauth2idps An array of OAuth2 Identity Providers. |
||
60 | */ |
||
61 | public static $oauth2idps = ['Google', 'GitHub', 'ORCID']; |
||
62 | |||
63 | |||
64 | /** |
||
65 | * getIdPList |
||
66 | * |
||
67 | * This function initializes the class $idplist object (if not yet |
||
68 | * created) and returns it. This allows for a single 'global' |
||
69 | * $idplist to be used by other classes (since creating an IdPList |
||
70 | * object is expensive). |
||
71 | * |
||
72 | * @return IdPList The class instantiated IdPList object. |
||
73 | **/ |
||
74 | public static function getIdpList() |
||
81 | |||
82 | /** |
||
83 | * getCsrf |
||
84 | * |
||
85 | * This function initializes the class $csrf object (if not yet |
||
86 | * created) and returns it. This allows for a single 'global' |
||
87 | * $csrf to be used by other classes (since we want the CSRV value |
||
88 | * to be consistent for the current page load). |
||
89 | * |
||
90 | * @return CSRF The class instantiated CSRF object. |
||
91 | */ |
||
92 | public static function getCsrf() |
||
99 | |||
100 | /** |
||
101 | * getSkin |
||
102 | * |
||
103 | * This function initializes the class $skin object (if not yet |
||
104 | * created) and returns it. This allows for a single 'global' |
||
105 | * $skin to be used by other classes (since loading the skin is |
||
106 | * potentially expensive). |
||
107 | * |
||
108 | * @return The class instantiated Skin object. |
||
109 | */ |
||
110 | public static function getSkin() |
||
117 | |||
118 | /** |
||
119 | * getConfigVar |
||
120 | * |
||
121 | * This function returns a sinle configuration vale from the |
||
122 | * CILOGON_INI_FILE, or empty string if no such configuration |
||
123 | * value is found in the file. |
||
124 | * |
||
125 | * @param string $config The config parameter to read from the |
||
126 | * cilogon.ini file. |
||
127 | * @return string The value of the config parameter, or empty string |
||
128 | * if no such parameter found in config.ini. |
||
129 | */ |
||
130 | public static function getConfigVar($config) |
||
143 | |||
144 | /** |
||
145 | * startTiming |
||
146 | * |
||
147 | * This function initializes the class variable $timeit which is |
||
148 | * used for timing/benchmarking purposes. |
||
149 | */ |
||
150 | public static function startTiming() |
||
154 | |||
155 | /** |
||
156 | * getServerVar |
||
157 | * |
||
158 | * This function queries a given $_SERVER variable (which is set |
||
159 | * by the Apache server) and returns the value. |
||
160 | * |
||
161 | * @param string $serv The $_SERVER variable to query. |
||
162 | * @return string The value of the $_SERVER variable or empty string |
||
163 | * if that variable is not set. |
||
164 | */ |
||
165 | public static function getServerVar($serv) |
||
173 | |||
174 | /** |
||
175 | * getGetVar |
||
176 | * |
||
177 | * This function queries a given $_GET parameter (which is set in |
||
178 | * the URL via a '?parameter=value' parameter) and returns the |
||
179 | * value. |
||
180 | * |
||
181 | * @param string $get The $_GET variable to query. |
||
182 | * @return string The value of the $_GET variable or empty string if |
||
183 | * that variable is not set. |
||
184 | */ |
||
185 | public static function getGetVar($get) |
||
193 | |||
194 | /** |
||
195 | * getPostVar |
||
196 | * |
||
197 | * This function queries a given $_POST variable (which is set when |
||
198 | * the user submits a form, for example) and returns the value. |
||
199 | * |
||
200 | * @param string $post The $_POST variable to query. |
||
201 | * @return string The value of the $_POST variable or empty string if |
||
202 | * that variable is not set. |
||
203 | */ |
||
204 | public static function getPostVar($post) |
||
212 | |||
213 | /** |
||
214 | * getCookieVar |
||
215 | * |
||
216 | * This function returns the value of a given cookie. |
||
217 | * |
||
218 | * @param string $cookie he $_COOKIE variable to query. |
||
219 | * @return string The value of the $_COOKIE variable or empty string |
||
220 | * if that variable is not set. |
||
221 | */ |
||
222 | public static function getCookieVar($cookie) |
||
230 | |||
231 | /** |
||
232 | * setCookieVar |
||
233 | * |
||
234 | * This function sets a cookie. |
||
235 | * |
||
236 | * @param string $cookie The name of the cookie to set. |
||
237 | * @param string $value (Optional) The value to set for the cookie. |
||
238 | * Defaults to empty string. |
||
239 | * @param int $exp The future expiration time (in seconds) of the |
||
240 | * cookie. Defaults to 1 year from now. If set to 0, |
||
241 | * the cookie expires at the end of the session. |
||
242 | */ |
||
243 | public static function setCookieVar($cookie, $value = '', $exp = 31536000) |
||
251 | |||
252 | /** |
||
253 | * unsetCookieVar |
||
254 | * |
||
255 | * This function unsets a cookie. Strictly speaking, the cookie is |
||
256 | * not removed, rather it is set to an empty value with an expired |
||
257 | * time. |
||
258 | * |
||
259 | * @param string $cookie The name of the cookie to unset (delete). |
||
260 | */ |
||
261 | public static function unsetCookieVar($cookie) |
||
266 | |||
267 | /** |
||
268 | * getPortalOrNormalCookieVar |
||
269 | * |
||
270 | * This is a convenience function which first checks if there is a |
||
271 | * OAuth 1.0a ('delegate') or OIDC ('authorize') session active. |
||
272 | * If so, it attempts to get the requested cookie from the |
||
273 | * associated portalcookie. If there is not an OAuth/OIDC session |
||
274 | * active, it looks for a 'normal' cookie. If you need a |
||
275 | * portalcookie object to do multiple get/set method calls from |
||
276 | * one function, it is probably better NOT to use this method since |
||
277 | * creating the portalcookie object is potentially expensive. |
||
278 | * |
||
279 | * @param string $cookie The name of the cookie to get. |
||
280 | * @return string The cookie value from either the portalcookie |
||
281 | * (in the case of an active OAuth session) or the |
||
282 | * 'normal' cookie. Return empty string if no matching |
||
283 | * cookie in either place. |
||
284 | */ |
||
285 | public static function getPortalOrNormalCookieVar($cookie) |
||
297 | |||
298 | /** |
||
299 | * getSessionVar |
||
300 | * |
||
301 | * This function returns the value of a given PHP Session variable. |
||
302 | * |
||
303 | * @param string $sess The $_SESSION variable to query. |
||
304 | * @return string The value of the $_SESSION variable or empty string |
||
305 | * if that variable is not set. |
||
306 | */ |
||
307 | public static function getSessionVar($sess) |
||
315 | |||
316 | /** |
||
317 | * setSessionVar |
||
318 | * |
||
319 | * This function can set or unset a given PHP session variable. |
||
320 | * The first parameter is the PHP session variable to set/unset. |
||
321 | * If the second parameter is the empty string, then the session |
||
322 | * variable is unset. Otherwise, the session variable is set to |
||
323 | * the second parameter. The function returns true if the session |
||
324 | * variable was set to a non-empty value, false otherwise. |
||
325 | * Normally, the return value can be ignored. |
||
326 | * |
||
327 | * @param string $key The name of the PHP session variable to set |
||
328 | * (or unset). |
||
329 | * @param string $value (Optional) The value of the PHP session variable |
||
330 | * (to set), or empty string (to unset). Defaults to empty |
||
331 | * string (implies unset the session variable). |
||
332 | * @return bool True if the PHP session variable was set to a |
||
333 | * non-empty string, false if variable was unset or if |
||
334 | * the specified session variable was not previously set. |
||
335 | */ |
||
336 | public static function setSessionVar($key, $value = '') |
||
349 | |||
350 | /** |
||
351 | * unsetSessionVar |
||
352 | * |
||
353 | * This function clears the given PHP session variable by first |
||
354 | * setting it to null and then unsetting it entirely. |
||
355 | * |
||
356 | * @param string $sess The $_SESSION variable to erase. |
||
357 | */ |
||
358 | public static function unsetSessionVar($sess) |
||
365 | |||
366 | /** |
||
367 | * removeShibCookies |
||
368 | * |
||
369 | * This function removes all '_shib*' cookies currently in the |
||
370 | * user's browser session. In effect, this logs the user out of |
||
371 | * any IdP. Note that you must call this before you output any |
||
372 | * HTML. Strictly speaking, the cookies are not removed, rather |
||
373 | * they are set to empty values with expired times. |
||
374 | */ |
||
375 | public static function removeShibCookies() |
||
383 | |||
384 | /** |
||
385 | * startPHPSession |
||
386 | * |
||
387 | * This function starts a secure PHP session and should be called |
||
388 | * at the beginning of each script before any HTML is output. It |
||
389 | * does a trick of setting a 'lastaccess' time so that the |
||
390 | * $_SESSION variable does not expire without warning. |
||
391 | * |
||
392 | * @param string $storetype (Optional) Storage location of the PHP |
||
393 | * session data, one of 'file' or 'mysql'. Defaults to null, |
||
394 | * which means use the value of storage.phpsessions from the |
||
395 | * cilogon.ini config file, or 'file' if no such |
||
396 | * parameter configured. |
||
397 | */ |
||
398 | public static function startPHPSession($storetype = null) |
||
416 | |||
417 | /** |
||
418 | * getScriptDir |
||
419 | * |
||
420 | * This function returns the directory (or full url) of the script |
||
421 | * that is currently running. The returned directory/url is |
||
422 | * terminated by a '/' character (unless the second parameter is |
||
423 | * set to true). This function is useful for those scripts named |
||
424 | * index.php where we don't want to actually see 'index.php' in the |
||
425 | * address bar (again, unless the second parameter is set to true). |
||
426 | * |
||
427 | * @param bool $prependhttp (Optional) Boolean to prepend 'http(s)://' to |
||
428 | * the script name. Defaults to false. |
||
429 | * @param bool $stripfile (Optional) Boolean to strip off the trailing |
||
430 | * filename (e.g. index.php) from the path. |
||
431 | * Defaults to true (i.e., defaults to directory |
||
432 | * only without the trailing filename). |
||
433 | * @return string The directory or url of the current script, with or |
||
434 | * without the trailing .php filename. |
||
435 | */ |
||
436 | public static function getScriptDir($prependhttp = false, $stripfile = true) |
||
456 | |||
457 | /** |
||
458 | * readArrayFromFile |
||
459 | * |
||
460 | * This function reads in the contents of a file into an array. It |
||
461 | * is assumed that the file contains lines of the form: |
||
462 | * key value |
||
463 | * where 'key' and 'value' are separated by whitespace. The 'key' |
||
464 | * portion of the string may not contain any whitespace, but the |
||
465 | * 'value' part of the line may contain whitespace. Any empty lines |
||
466 | * or lines starting with '#' (comments, without leading spaces) |
||
467 | * in the file are skipped. Note that this assumes that each 'key' |
||
468 | * in the file is unique. If there is any problem reading the |
||
469 | * file, the resulting array will be empty. |
||
470 | * |
||
471 | * @param string $filename The name of the file to read. |
||
472 | * @return array An array containing the contents of the file. |
||
473 | */ |
||
474 | public static function readArrayFromFile($filename) |
||
492 | |||
493 | /** |
||
494 | * writeArrayToFile |
||
495 | * |
||
496 | * This funtion writes an array (with key=>value pairs) to a file, |
||
497 | * each line will be of the form: |
||
498 | * key value |
||
499 | * The 'key' and 'value' strings are separated by a space. Note |
||
500 | * that a 'key' may not contain any whitespace (e.g. tabs), but a |
||
501 | * 'value' may contain whitespace. To be super safe, the array is |
||
502 | * first written to a temporary file, which is then renamed to the |
||
503 | * final desired filename. |
||
504 | * |
||
505 | * @param string $filename The name of the file to write. |
||
506 | * @param array $thearray The array to be written to the file. |
||
507 | * @return bool True if successfully wrote file, false otherwise. |
||
508 | */ |
||
509 | public static function writeArrayToFile($filename, $thearray) |
||
530 | |||
531 | /** |
||
532 | * parseGridShibConf |
||
533 | * |
||
534 | * This function parses the gridshib-ca.conf file and returns an |
||
535 | * array containing the various options. It uses the PHP |
||
536 | * PEAR::Config package to parse the config file. The |
||
537 | * gridshib-ca.conf file is MOSTLY an Apache-style config file. |
||
538 | * However, each option has an extra ' = ' prepended, so you will |
||
539 | * need to strip these off each config option. For example, to get |
||
540 | * the 'MaximumCredLifetime' value which is in the 'CA' section, |
||
541 | * you would do the following: |
||
542 | * $gridshibconf = Util::parseGridShibConf(); |
||
543 | * $life = preg_replace('%^\s*=\s*%','', |
||
544 | * $gridshibconf['root']['CA']['MaximumCredLifetime']); |
||
545 | * |
||
546 | * @param string $conffile (Optional) Full path location of |
||
547 | * gridshib-ca.conf file. Defaults to |
||
548 | * '/usr/local/gridshib-ca/conf/gridshib-ca.conf'. |
||
549 | * @return array An array containing the various configuration |
||
550 | * parameters in the gridshib-ca.conf file. |
||
551 | */ |
||
552 | public static function parseGridShibConf( |
||
563 | |||
564 | /** |
||
565 | * tempDir |
||
566 | * |
||
567 | * This function creates a temporary subdirectory within the |
||
568 | * specified subdirectory. The new directory name is composed of |
||
569 | * 16 hexadecimal letters, plus any prefix if you specify one. The |
||
570 | * full path of the the newly created directory is returned. |
||
571 | * |
||
572 | * @param string $dir The full path to the containing directory. |
||
573 | * @param string $prefix (Optional) A prefix for the new temporary |
||
574 | * directory. Defaults to empty string. |
||
575 | * @param int $mode (Optional) Access permissions for the new |
||
576 | * temporary directory. Defaults to 0775. |
||
577 | * @return string Full path to the newly created temporary directory. |
||
578 | */ |
||
579 | public static function tempDir($dir, $prefix = '', $mode = 0775) |
||
592 | |||
593 | /** |
||
594 | * deleteDir |
||
595 | * |
||
596 | * This function deletes a directory and all of its contents. |
||
597 | * |
||
598 | * @param string $dir The (possibly non-empty) directory to delete. |
||
599 | * @param bool $shred (Optional) Shred the file before deleting? |
||
600 | * Defaults to false. |
||
601 | */ |
||
602 | public static function deleteDir($dir, $shred = false) |
||
623 | |||
624 | /** |
||
625 | * htmlent |
||
626 | * |
||
627 | * This method is necessary since htmlentities() does not seem to |
||
628 | * obey the default arguments as documented in the PHP manual, and |
||
629 | * instead encodes accented characters incorrectly. By specifying |
||
630 | * the flags and encoding, the problem is solved. |
||
631 | * |
||
632 | * @param string $str : A string to process with htmlentities(). |
||
633 | * @return string The input string processed by htmlentities with |
||
634 | * specific options. |
||
635 | */ |
||
636 | public static function htmlent($str) |
||
640 | |||
641 | /** |
||
642 | * sendErrorAlert |
||
643 | * |
||
644 | * Use this function to send an error message. The $summary should |
||
645 | * be a short description of the error since it is placed in the |
||
646 | * subject of the email. Put a more verbose description of the |
||
647 | * error in the $detail parameter. Any session variables available |
||
648 | * are appended to the body of the message. |
||
649 | * |
||
650 | * @param string $summary A brief summary of the error (in email subject) |
||
651 | * @param string $detail A detailed description of the error (in the |
||
652 | * email body) |
||
653 | * @param string $mailto (Optional) The destination email address. |
||
654 | * Defaults to '[email protected]'. |
||
655 | */ |
||
656 | public static function sendErrorAlert( |
||
711 | |||
712 | /** |
||
713 | * getFirstAndLastName |
||
714 | * |
||
715 | * This function attempts to get the first and last name of a user |
||
716 | * extracted from the 'full name' (displayName) of the user. |
||
717 | * Simply pass in all name info (full, first, and last) and the |
||
718 | * function first tries to break up the full name into first/last. |
||
719 | * If this is not sufficient, the function checks first and last |
||
720 | * name. Finally, if either first or last is blank, the function |
||
721 | * duplicates first <=> last so both names have the same value. |
||
722 | * Note that even with all this, you still need to check if the |
||
723 | * returned (first,last) names are blank. |
||
724 | * |
||
725 | * @param string $full The 'full name' of the user |
||
726 | * @param string $first (Optional) The 'first name' of the user |
||
727 | * @param string $last (Optional) The 'last name' of the user |
||
728 | * @return array An array 'list(firstname,lastname)' |
||
729 | */ |
||
730 | public static function getFirstAndLastName($full, $first = '', $last = '') |
||
761 | |||
762 | /** |
||
763 | * getHN |
||
764 | * |
||
765 | * This function calculates and returns the 'hostname' for the |
||
766 | * server. It first checks HTTP_HOST. If not set, it returns |
||
767 | * 'cilogon.org'. This is needed by command line scripts. |
||
768 | * |
||
769 | * @return string The 'Hostname' for the web server. |
||
770 | */ |
||
771 | public static function getHN() |
||
779 | |||
780 | /** |
||
781 | * getDN |
||
782 | * |
||
783 | * This function calculates and returns the 'domainname' for the |
||
784 | * server. It uses the hostname value calculated by getHN() and |
||
785 | * uses the last two segments. |
||
786 | * |
||
787 | * @return string The 'Domainname' for the web server. |
||
788 | */ |
||
789 | public static function getDN() |
||
797 | |||
798 | /** |
||
799 | * getAuthzUrl |
||
800 | * |
||
801 | * This funtion takes in the name of an IdP (e.g., 'Google') and |
||
802 | * returns the assoicated OAuth2 authorization URL. |
||
803 | * |
||
804 | * @param string $idp The name of an OAuth2 Identity Provider. |
||
805 | * @return string The authorization URL for the given IdP. |
||
806 | */ |
||
807 | public static function getAuthzUrl($idp) |
||
820 | |||
821 | /** |
||
822 | * getAuthzIdP |
||
823 | * |
||
824 | * This function takes in the OAuth2 authorization URL and returns |
||
825 | * the associated pretty-print name of the IdP. |
||
826 | * |
||
827 | * @param string $url The authorization URL of an OAuth2 Identity Provider. |
||
828 | * @return string The name of the IdP. |
||
829 | */ |
||
830 | public static function getAuthzIdP($url) |
||
843 | |||
844 | /** |
||
845 | * saveUserToDataStore |
||
846 | * |
||
847 | * This function is called when a user logs on to save identity |
||
848 | * information to the datastore. As it is used by both Shibboleth |
||
849 | * and OpenID Identity Providers, some parameters passed in may |
||
850 | * be blank (empty string). The function verifies that the minimal |
||
851 | * sets of parameters are valid, the dbservice servlet is called |
||
852 | * to save the user info. Then various session variables are set |
||
853 | * for use by the program later on. In case of error, an email |
||
854 | * alert is sent showing the missing parameters. |
||
855 | * |
||
856 | * @param string $remoteuser The REMOTE_USER from HTTP headers |
||
857 | * @param string $providerId The provider IdP Identifier / URL endpoint |
||
858 | * @param string providerName The pretty print provider IdP name |
||
859 | * @param string $firstname The user's first name |
||
860 | * @param string $lastname The user's last name |
||
861 | * @param string $displayname The user's display name |
||
862 | * @param string $emailaddr The user's email address |
||
863 | * @param string $loa The level of assurance (e.g., openid/basic/silver) |
||
864 | * @param string $eppn (optional) User's ePPN (for SAML IdPs) |
||
865 | * @param string $eptid (optional) User's ePTID (for SAML IdPs) |
||
866 | * @param string $openidid (optional) User's OpenID 2.0 Identifier |
||
867 | * @param string $oidcid (optional) User's OpenID Connect Identifier |
||
868 | * @param string $affiliation (optional) User's affiliation |
||
869 | * @param string $ou (optional) User's organizational unit (OU) |
||
870 | * @param string $memberof (optional) User's isMemberOf group info |
||
871 | * @param string $acr (optional) Authentication Context Class Ref |
||
872 | * @param string $entitlement (optional) User's entitlement |
||
873 | */ |
||
874 | public static function saveUserToDataStore( |
||
1086 | |||
1087 | /** |
||
1088 | * unsetClientSessionVars |
||
1089 | * |
||
1090 | * This function removes all of the PHP session variables related to |
||
1091 | * the client session. |
||
1092 | */ |
||
1093 | public static function unsetClientSessionVars() |
||
1114 | |||
1115 | /** |
||
1116 | * unsetUserSessionVars |
||
1117 | * |
||
1118 | * This function removes all of the PHP session variables related to |
||
1119 | * the user's session. This will force the user to log on (again) |
||
1120 | * with their IdP and call the 'getuser' script to repopulate the PHP |
||
1121 | * session. |
||
1122 | */ |
||
1123 | public static function unsetUserSessionVars() |
||
1155 | |||
1156 | /** |
||
1157 | * unsetAllUserSessionVars |
||
1158 | * |
||
1159 | * This is a convenience method to clear all session variables related |
||
1160 | * to the client and the user. |
||
1161 | */ |
||
1162 | public static function unsetAllUserSessionVars() |
||
1167 | |||
1168 | /** |
||
1169 | * verifySessionAndCall |
||
1170 | * |
||
1171 | * This function is a convenience method called by several cases in the |
||
1172 | * main 'switch' call at the top of the index.php file. I noticed |
||
1173 | * a pattern where verifyCurrentUserSession() was called to verify the |
||
1174 | * current user session. Upon success, one or two functions were called |
||
1175 | * to continue program, flow. Upon failure, cookies and session |
||
1176 | * variables were cleared, and the main Logon page was printed. This |
||
1177 | * function encapsulates that pattern. If the user's session is valid, |
||
1178 | * the passed-in $func is called, possibly with parameters passed in as |
||
1179 | * an array. The function returns true if the session is verified, so |
||
1180 | * that other functions may be called upon return. |
||
1181 | * |
||
1182 | * @param function $func The function to call if the current session is |
||
1183 | * successfully verified. |
||
1184 | * @param array $params (Optional) An array of parameters to pass to the |
||
1185 | 8 function. Defaults to empty array, meaning zero parameters. |
||
1186 | */ |
||
1187 | public static function verifySessionAndCall($func, $params = array()) |
||
1198 | } |
||
1199 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.