PlaceholdersTransformer::transformArgument() - Code Metrics - Inspection of "Merged feature/config-sections into master" - ciandt-dev/behat-placeholders-extension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 66c291...444f0e )

by Bruno

created 2017-01-02 12:05 UTC

PlaceholdersTransformer::transformArgument() A

↳ Parent: PlaceholdersTransformer

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	3

<?php

namespace Ciandt\Behat\PlaceholdersExtension\Transformer;

use Behat\Behat\Transformation\Transformer\ArgumentTransformer;
use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainerStepNode;
use Ciandt\Behat\PlaceholdersExtension\Transformation\RuntimePlaceholdersTransformation;
use Behat\Behat\Definition\Call\DefinitionCall;
use Ciandt\Behat\PlaceholdersExtension\Config\PlaceholdersRepository;

/**
 * Transforms a single argument value.

 */
class PlaceholdersTransformer implements ArgumentTransformer
{
    
    private $placeholdersRepository;
    
    public function __construct(PlaceholdersRepository $placeholdersRepository) {
        $this->placeholdersRepository = $placeholdersRepository;
    }

    
    public function supportsDefinitionAndArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue) {
        return RuntimePlaceholdersTransformation::supportsDefinitionAndArgument($definitionCall, $argumentValue);        
    }

    public function transformArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue) {
        $transformedArgument = $argumentValue;
        if (RuntimePlaceholdersTransformation::supportsDefinitionAndArgument($definitionCall, $argumentValue)){
            $transformedArgument = RuntimePlaceholdersTransformation::transformArgument(
                    $transformedArgument,
                    $this->placeholdersRepository,
                    $definitionCall->getStep());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        
        return $transformedArgument;
    }

}


1			<?php
2
3			namespace Ciandt\Behat\PlaceholdersExtension\Transformer;
4
5			use Behat\Behat\Transformation\Transformer\ArgumentTransformer;
6			use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainerStepNode;
7			use Ciandt\Behat\PlaceholdersExtension\Transformation\RuntimePlaceholdersTransformation;
8			use Behat\Behat\Definition\Call\DefinitionCall;
9			use Ciandt\Behat\PlaceholdersExtension\Config\PlaceholdersRepository;
10
11			/**
12			* Transforms a single argument value.
13
14			*/
15			class PlaceholdersTransformer implements ArgumentTransformer
16			{
17
18			private $placeholdersRepository;
19
20			public function __construct(PlaceholdersRepository $placeholdersRepository) {
21			$this->placeholdersRepository = $placeholdersRepository;
22			}
23
24
25			public function supportsDefinitionAndArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue) {
26			return RuntimePlaceholdersTransformation::supportsDefinitionAndArgument($definitionCall, $argumentValue);
27			}
28
29			public function transformArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue) {
30			$transformedArgument = $argumentValue;
31			if (RuntimePlaceholdersTransformation::supportsDefinitionAndArgument($definitionCall, $argumentValue)){
32			$transformedArgument = RuntimePlaceholdersTransformation::transformArgument(
33			$transformedArgument,
34			$this->placeholdersRepository,
35			$definitionCall->getStep());
			0 ignored issues – show Documentation introduced 2017-01-02 12:09 UTC by Report Bug Copy Issue Report `$definitionCall->getStep()` is of type `object<Behat\Gherkin\Node\StepNode>`, but the function expects a `object<Ciandt\Behat\Plac...r\PlaceholderContainer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			}
37
38			return $transformedArgument;
39			}
40
41			}
42

ciandt-dev / behat-placeholders-extension

GitHub Access Token became invalid

Push — master ( 66c291...444f0e )

PlaceholdersTransformer::transformArgument() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like