ci-bonfire / Sprint

myth/Api/Server/LogModel.php

Spacing +2 added lines, -2 removed lines

@@ -55,11 +55,11 @@
 		$time = date('Y-m-d H:00:00');
 
 		$query = $this->db->select('id')
-						  ->where('user_id', (int)$user_id)
+						  ->where('user_id', (int) $user_id)
 						  ->where('created_on >=', $time)
 						  ->get($this->table_name);
 
-		return (int)$query->num_rows();
+		return (int) $query->num_rows();
 	}
 
 	//--------------------------------------------------------------------

myth/Auth/AuthenticateInterface.php

Spacing +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
      * @param $credentials
      * @param bool $remember
      */
-    public function login($credentials, $remember=false);
+    public function login($credentials, $remember = false);
 
     //--------------------------------------------------------------------
 
@@ -65,7 +65,7 @@ 
      * @param bool $return_user
      * @return mixed
      */
-    public function validate($credentials, $return_user=false);
+    public function validate($credentials, $return_user = false);
 
     //--------------------------------------------------------------------
 
@@ -188,7 +188,7 @@ 
      * @param null $message
      * @return mixed
      */
-    public function changeStatus($newStatus, $message=null);
+    public function changeStatus($newStatus, $message = null);
 
     //--------------------------------------------------------------------
 

Indentation +192 added lines, -192 removed lines

@@ -42,197 +42,197 @@
  */
 interface AuthenticateInterface {
 
-    /**
-     * Attempt to log a user into the system.
-     *
-     * $credentials is an array of key/value pairs needed to log the user in.
-     * This is often email/password, or username/password.
-     *
-     * @param $credentials
-     * @param bool $remember
-     */
-    public function login($credentials, $remember=false);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Validates user login information without logging them in.
-     *
-     * $credentials is an array of key/value pairs needed to log the user in.
-     * This is often email/password, or username/password.
-     *
-     * @param $credentials
-     * @param bool $return_user
-     * @return mixed
-     */
-    public function validate($credentials, $return_user=false);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Logs a user out and removes all session information.
-     *
-     * @return mixed
-     */
-    public function logout();
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Checks whether a user is logged in or not.
-     *
-     * @return bool
-     */
-    public function isLoggedIn();
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Attempts to log a user in based on the "remember me" cookie.
-     *
-     * @return bool
-     */
-    public function viaRemember();
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Registers a new user and handles activation method.
-     *
-     * @param $user_data
-     * @return bool
-     */
-    public function registerUser($user_data);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Used to verify the user values and activate a user so they can
-     * visit the site.
-     *
-     * @param $data
-     * @return bool
-     */
-    public function activateUser($data);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Used to allow manual activation of a user with a known ID.
-     *
-     * @param $id
-     * @return bool
-     */
-    public function activateUserById($id);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Grabs the current user object. Returns NULL if nothing found.
-     *
-     * @return array|null
-     */
-    public function user();
-
-    //--------------------------------------------------------------------
-
-    /**
-     * A convenience method to grab the current user's ID.
-     *
-     * @return int|null
-     */
-    public function id();
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Tells the system to start throttling a user. This may vary by implementation,
-     * but will often add additional time before another login is allowed.
-     *
-     * @param $email
-     * @return mixed
-     */
-    public function isThrottled($email);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Sends a password reminder email to the user associated with
-     * the passed in $email.
-     *
-     * @param $email
-     * @return mixed
-     */
-    public function remindUser($email);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Validates the credentials provided and, if valid, resets the password.
-     *
-     * @param $credentials
-     * @param $password
-     * @param $passConfirm
-     * @return mixed
-     */
-    public function resetPassword($credentials, $password, $passConfirm);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Provides a way for implementations to allow new statuses to be set
-     * on the user. The details will vary based upon implementation, but
-     * will often allow for banning or suspending users.
-     *
-     * @param $newStatus
-     * @param null $message
-     * @return mixed
-     */
-    public function changeStatus($newStatus, $message=null);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Allows the consuming application to pass in a reference to the
-     * model that should be used.
-     *
-     * The model MUST extend Myth\Models\CIDbModel.
-     *
-     * @param $model
-     * @return mixed
-     */
-    public function useModel($model);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Returns the current error string.
-     *
-     * @return mixed
-     */
-    public function error();
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Purges all login attempt records from the database.
-     *
-     * @param null $ip_address
-     * @param null $user_id
-     */
-    public function purgeLoginAttempts($ip_address = null, $user_id = null);
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Purges all remember tokens for a single user. Effectively logs
-     * a user out of all devices. Intended to allow users to log themselves
-     * out of all devices as a security measure.
-     *
-     * @param $email
-     */
-    public function purgeRememberTokens($email);
-
-    //--------------------------------------------------------------------
+	/**
+	 * Attempt to log a user into the system.
+	 *
+	 * $credentials is an array of key/value pairs needed to log the user in.
+	 * This is often email/password, or username/password.
+	 *
+	 * @param $credentials
+	 * @param bool $remember
+	 */
+	public function login($credentials, $remember=false);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Validates user login information without logging them in.
+	 *
+	 * $credentials is an array of key/value pairs needed to log the user in.
+	 * This is often email/password, or username/password.
+	 *
+	 * @param $credentials
+	 * @param bool $return_user
+	 * @return mixed
+	 */
+	public function validate($credentials, $return_user=false);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Logs a user out and removes all session information.
+	 *
+	 * @return mixed
+	 */
+	public function logout();
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Checks whether a user is logged in or not.
+	 *
+	 * @return bool
+	 */
+	public function isLoggedIn();
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Attempts to log a user in based on the "remember me" cookie.
+	 *
+	 * @return bool
+	 */
+	public function viaRemember();
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Registers a new user and handles activation method.
+	 *
+	 * @param $user_data
+	 * @return bool
+	 */
+	public function registerUser($user_data);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Used to verify the user values and activate a user so they can
+	 * visit the site.
+	 *
+	 * @param $data
+	 * @return bool
+	 */
+	public function activateUser($data);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Used to allow manual activation of a user with a known ID.
+	 *
+	 * @param $id
+	 * @return bool
+	 */
+	public function activateUserById($id);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Grabs the current user object. Returns NULL if nothing found.
+	 *
+	 * @return array|null
+	 */
+	public function user();
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * A convenience method to grab the current user's ID.
+	 *
+	 * @return int|null
+	 */
+	public function id();
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Tells the system to start throttling a user. This may vary by implementation,
+	 * but will often add additional time before another login is allowed.
+	 *
+	 * @param $email
+	 * @return mixed
+	 */
+	public function isThrottled($email);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Sends a password reminder email to the user associated with
+	 * the passed in $email.
+	 *
+	 * @param $email
+	 * @return mixed
+	 */
+	public function remindUser($email);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Validates the credentials provided and, if valid, resets the password.
+	 *
+	 * @param $credentials
+	 * @param $password
+	 * @param $passConfirm
+	 * @return mixed
+	 */
+	public function resetPassword($credentials, $password, $passConfirm);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Provides a way for implementations to allow new statuses to be set
+	 * on the user. The details will vary based upon implementation, but
+	 * will often allow for banning or suspending users.
+	 *
+	 * @param $newStatus
+	 * @param null $message
+	 * @return mixed
+	 */
+	public function changeStatus($newStatus, $message=null);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Allows the consuming application to pass in a reference to the
+	 * model that should be used.
+	 *
+	 * The model MUST extend Myth\Models\CIDbModel.
+	 *
+	 * @param $model
+	 * @return mixed
+	 */
+	public function useModel($model);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Returns the current error string.
+	 *
+	 * @return mixed
+	 */
+	public function error();
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Purges all login attempt records from the database.
+	 *
+	 * @param null $ip_address
+	 * @param null $user_id
+	 */
+	public function purgeLoginAttempts($ip_address = null, $user_id = null);
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Purges all remember tokens for a single user. Effectively logs
+	 * a user out of all devices. Intended to allow users to log themselves
+	 * out of all devices as a security measure.
+	 *
+	 * @param $email
+	 */
+	public function purgeRememberTokens($email);
+
+	//--------------------------------------------------------------------
 
 }

myth/Auth/AuthorizeInterface.php

Spacing +5 added lines, -5 removed lines

@@ -30,7 +30,7 @@ 
  * @since       Version 1.0
  */
 
-interface AuthorizeInterface  {
+interface AuthorizeInterface {
 
 	/**
 	 * Returns the latest error string.
@@ -150,7 +150,7 @@ 
 	 *
 	 * @return mixed
 	 */
-	public function createGroup($name, $description='');
+	public function createGroup($name, $description = '');
 
 	//--------------------------------------------------------------------
 
@@ -174,7 +174,7 @@ 
 	 *
 	 * @return mixed
 	 */
-	public function updateGroup($id, $name, $description='');
+	public function updateGroup($id, $name, $description = '');
 
 	//--------------------------------------------------------------------
 
@@ -210,7 +210,7 @@ 
 	 *
 	 * @return mixed
 	 */
-	public function createPermission($name, $description='');
+	public function createPermission($name, $description = '');
 
 	//--------------------------------------------------------------------
 
@@ -234,7 +234,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function updatePermission($id, $name, $description='');
+	public function updatePermission($id, $name, $description = '');
 
 	//--------------------------------------------------------------------
 

myth/Auth/Flat/FlatGroupsModel.php

Indentation +22 added lines, -22 removed lines

@@ -85,10 +85,10 @@ 
 	 */
 	public function addUserToGroup($user_id, $group_id)
 	{
-	    $data = [
-		    'user_id'   => (int)$user_id,
-		    'group_id'  => (int)$group_id
-	    ];
+		$data = [
+			'user_id'   => (int)$user_id,
+			'group_id'  => (int)$group_id
+		];
 
 		return $this->db->insert('auth_groups_users', $data);
 	}
@@ -105,10 +105,10 @@ 
 	 */
 	public function removeUserFromGroup($user_id, $group_id)
 	{
-	    return $this->where([
-		    'user_id' => (int)$user_id,
-		    'group_id' => (int)$group_id
-	    ])->delete('auth_groups_users');
+		return $this->where([
+			'user_id' => (int)$user_id,
+			'group_id' => (int)$group_id
+		])->delete('auth_groups_users');
 	}
 
 	//--------------------------------------------------------------------
@@ -122,8 +122,8 @@ 
 	 */
 	public function removeUserFromAllGroups($user_id)
 	{
-	    return $this->db->where('user_id', (int)$user_id)
-		                ->delete('auth_groups_users');
+		return $this->db->where('user_id', (int)$user_id)
+						->delete('auth_groups_users');
 	}
 
 	//--------------------------------------------------------------------
@@ -137,11 +137,11 @@ 
 	 */
 	public function getGroupsForUser($user_id)
 	{
-	    return $this->select('auth_groups_users.*, auth_groups.name, auth_groups.description')
-		            ->join('auth_groups_users', 'auth_groups_users.group_id = auth_groups.id', 'left')
-		            ->where('user_id', $user_id)
-		            ->as_array()
-		            ->find_all();
+		return $this->select('auth_groups_users.*, auth_groups.name, auth_groups.description')
+					->join('auth_groups_users', 'auth_groups_users.group_id = auth_groups.id', 'left')
+					->where('user_id', $user_id)
+					->as_array()
+					->find_all();
 	}
 
 	//--------------------------------------------------------------------
@@ -160,7 +160,7 @@ 
 			'group_id'      => (int)$group_id
 		];
 
-	    return $this->db->insert('auth_groups_permissions', $data);
+		return $this->db->insert('auth_groups_permissions', $data);
 	}
 
 	//--------------------------------------------------------------------
@@ -176,10 +176,10 @@ 
 	 */
 	public function removePermissionFromGroup($permission_id, $group_id)
 	{
-	    return $this->db->where([
-		    'permission_id' => $permission_id,
-		    'group_id'      => $group_id
-	    ])->delete('auth_groups_permissions');
+		return $this->db->where([
+			'permission_id' => $permission_id,
+			'group_id'      => $group_id
+		])->delete('auth_groups_permissions');
 	}
 
 	//--------------------------------------------------------------------
@@ -193,8 +193,8 @@ 
 	 */
 	public function removePermissionFromAllGroups($permission_id)
 	{
-	    return $this->db->where('permission_id', $permission_id)
-		                ->delete('auth_groups_permissions');
+		return $this->db->where('permission_id', $permission_id)
+						->delete('auth_groups_permissions');
 	}
 
 	//--------------------------------------------------------------------

Spacing +7 added lines, -7 removed lines

@@ -86,8 +86,8 @@ 
 	public function addUserToGroup($user_id, $group_id)
 	{
 	    $data = [
-		    'user_id'   => (int)$user_id,
-		    'group_id'  => (int)$group_id
+		    'user_id'   => (int) $user_id,
+		    'group_id'  => (int) $group_id
 	    ];
 
 		return $this->db->insert('auth_groups_users', $data);
@@ -106,8 +106,8 @@ 
 	public function removeUserFromGroup($user_id, $group_id)
 	{
 	    return $this->where([
-		    'user_id' => (int)$user_id,
-		    'group_id' => (int)$group_id
+		    'user_id' => (int) $user_id,
+		    'group_id' => (int) $group_id
 	    ])->delete('auth_groups_users');
 	}
 
@@ -122,7 +122,7 @@ 
 	 */
 	public function removeUserFromAllGroups($user_id)
 	{
-	    return $this->db->where('user_id', (int)$user_id)
+	    return $this->db->where('user_id', (int) $user_id)
 		                ->delete('auth_groups_users');
 	}
 
@@ -156,8 +156,8 @@ 
 	public function addPermissionToGroup($permission_id, $group_id)
 	{
 		$data = [
-			'permission_id' => (int)$permission_id,
-			'group_id'      => (int)$group_id
+			'permission_id' => (int) $permission_id,
+			'group_id'      => (int) $group_id
 		];
 
 	    return $this->db->insert('auth_groups_permissions', $data);

myth/Auth/Flat/FlatPermissionsModel.php

Spacing +2 added lines, -2 removed lines

@@ -84,11 +84,11 @@
 	{
 		$permissions = $this->join('auth_groups_permissions', 'auth_groups_permissions.permission_id = auth_permissions.id', 'inner')
 							->join('auth_groups_users', 'auth_groups_users.group_id = auth_groups_permissions.group_id', 'inner')
-							->where('auth_groups_users.user_id', (int)$user_id)
+							->where('auth_groups_users.user_id', (int) $user_id)
 							->as_array()
 							->find_all();
 
-		if (! $permissions)
+		if ( ! $permissions)
 		{
 			return false;
 		}

myth/Auth/Password.php

Indentation +321 added lines, -321 removed lines

@@ -51,325 +51,325 @@
  */
 class Password {
 
-    /**
-     * A standardized method for hasing a password before storing
-     * in the database.
-     *
-     * @param $password
-     * @return bool|mixed|string
-     */
-    public static function hashPassword($password)
-    {
-        if (! config_item('auth.hash_cost'))
-        {
-            get_instance()->load->config('auth');
-        }
-
-        return password_hash($password, PASSWORD_DEFAULT, ['cost' => config_item('auth.hash_cost')]);
-    }
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Determines the number of entropy bits a password has based on
-     *
-     *
-     * @param $password
-     * @param bool $repeatcalc
-     * @return int
-     */
-    public static function getNISTNumBits($password, $repeatcalc = false)
-    {
-        $y = strlen($password);
-        if ($repeatcalc)
-        {
-            // Variant on NIST rules to reduce long sequences of repeated characters.
-            $result = 0;
-            $charmult = array_fill(0, 256, 1);
-            for ($x = 0; $x < $y; $x++)
-            {
-                $tempchr = ord(substr($password, $x, 1));
-                if ($x > 19)  $result += $charmult[$tempchr];
-                else if ($x > 7)  $result += $charmult[$tempchr] * 1.5;
-                else if ($x > 0)  $result += $charmult[$tempchr] * 2;
-                else  $result += 4;
-
-                $charmult[$tempchr] *= 0.75;
-            }
-
-            return $result;
-        }
-        else
-        {
-            if ($y > 20)  return 4 + (7 * 2) + (12 * 1.5) + $y - 20;
-            if ($y > 8)  return 4 + (7 * 2) + (($y - 8) * 1.5);
-            if ($y > 1)  return 4 + (($y - 1) * 2);
-
-            return ($y == 1 ? 4 : 0);
-        }
-    }
-
-    //--------------------------------------------------------------------
-
-    /**
-     * Determines whether a password is strong enough to use. You should check
-     * the password against this method and reject it if the password is not
-     * strong enough.
-     *
-     * The following guidelines come from the author's tests against 10.4 million actual passwords
-     * ( see post: http://cubicspot.blogspot.com/2012/01/how-to-calculate-password-strength-part.html )
-     * and represents the suggested minimum entropy bits for different types of sites:
-     *
-     *      - 18 bits of entropy = minimum for ANY website.
-     *      - 25 bits of entropy = minimum for a general purpose web service used relatively widely (e.g. Hotmail).
-     *      - 30 bits of entropy = minimum for a web service with business critical applications (e.g. SAAS).
-     *      - 40 bits of entropy = minimum for a bank or other financial service.
-     *
-     * The algorithm is based upon a modified version of the NIST rules which suggest the following:
-     *
-     *      - The first byte counts as 4 bits.
-     *      - The next 7 bytes count as 2 bits each.
-     *      - The next 12 bytes count as 1.5 bits each.
-     *      - Anything beyond that counts as 1 bit each.
-     *      - Mixed case + non-alphanumeric = up to 6 extra bits.
-     *
-     * @param string    $password   - The password to check
-     * @param int       $minbits    - Minimum "entropy bits" that is allowed
-     * @param bool      $usedict    - Should we check the password against a 300,000 word English dictionary?
-     * @param int       $minwordlen -
-     * @return bool
-     */
-    public static function isStrongPassword($password, $minbits = 18, $usedict = false, $minwordlen = 4)
-    {
-        // NIST password strength rules allow up to 6 extra bits for mixed case and non-alphabetic.
-        $upper = false;
-        $lower = false;
-        $numeric = false;
-        $other = false;
-        $space = false;
-        $y = strlen($password);
-        for ($x = 0; $x < $y; $x++)
-        {
-            $tempchr = ord(substr($password, $x, 1));
-            if ($tempchr >= ord("A") && $tempchr <= ord("Z"))  $upper = true;
-            else if ($tempchr >= ord("a") && $tempchr <= ord("z"))  $lower = true;
-            else if ($tempchr >= ord("0") && $tempchr <= ord("9"))  $numeric = true;
-            else if ($tempchr == ord(" "))  $space = true;
-            else  $other = true;
-        }
-        $extrabits = ($upper && $lower && $other ? ($numeric ? 6 : 5) : ($numeric && !$upper && !$lower ? ($other ? -2 : -6) : 0));
-        if (!$space)  $extrabits -= 2;
-        else if (count(explode(" ", preg_replace('/\s+/', " ", $password))) > 3)  $extrabits++;
-        $result = self::getNISTNumBits($password, true) + $extrabits;
-
-        $password = strtolower($password);
-        $revpassword = strrev($password);
-        $numbits = self::getNISTNumBits($password) + $extrabits;
-        if ($result > $numbits)  $result = $numbits;
-
-        // Remove QWERTY strings.
-        $qwertystrs = array(
-            "1234567890-qwertyuiopasdfghjkl;zxcvbnm,./",
-            "1qaz2wsx3edc4rfv5tgb6yhn7ujm8ik,9ol.0p;/-['=]:?_{\"+}",
-            "1qaz2wsx3edc4rfv5tgb6yhn7ujm8ik9ol0p",
-            "qazwsxedcrfvtgbyhnujmik,ol.p;/-['=]:?_{\"+}",
-            "qazwsxedcrfvtgbyhnujmikolp",
-            "]\"/=[;.-pl,0okm9ijn8uhb7ygv6tfc5rdx4esz3wa2q1",
-            "pl0okm9ijn8uhb7ygv6tfc5rdx4esz3wa2q1",
-            "]\"/[;.pl,okmijnuhbygvtfcrdxeszwaq",
-            "plokmijnuhbygvtfcrdxeszwaq",
-            "014725836914702583697894561230258/369*+-*/",
-            "abcdefghijklmnopqrstuvwxyz"
-        );
-        foreach ($qwertystrs as $qwertystr)
-        {
-            $qpassword = $password;
-            $qrevpassword = $revpassword;
-            $z = 6;
-            do
-            {
-                $y = strlen($qwertystr) - $z;
-                for ($x = 0; $x < $y; $x++)
-                {
-                    $str = substr($qwertystr, $x, $z);
-                    $qpassword = str_replace($str, "*", $qpassword);
-                    $qrevpassword = str_replace($str, "*", $qrevpassword);
-                }
-
-                $z--;
-            } while ($z > 2);
-
-            $numbits = self::getNISTNumBits($qpassword) + $extrabits;
-            if ($result > $numbits)  $result = $numbits;
-            $numbits = self::getNISTNumBits($qrevpassword) + $extrabits;
-            if ($result > $numbits)  $result = $numbits;
-
-            if ($result < $minbits)  return false;
-        }
-
-        if ($usedict && $result >= $minbits)
-        {
-            $passwords = array();
-
-            // Add keyboard shifting password variants.
-            $keyboardmap_down_noshift = array(
-                "z" => "", "x" => "", "c" => "", "v" => "", "b" => "", "n" => "", "m" => "", "," => "", "." => "", "/" => "", "<" => "", ">" => "", "?" => ""
-            );
-            if ($password == str_replace(array_keys($keyboardmap_down_noshift), array_values($keyboardmap_down_noshift), $password))
-            {
-                $keyboardmap_downright = array(
-                    "a" => "z",
-                    "q" => "a",
-                    "1" => "q",
-                    "s" => "x",
-                    "w" => "s",
-                    "2" => "w",
-                    "d" => "c",
-                    "e" => "d",
-                    "3" => "e",
-                    "f" => "v",
-                    "r" => "f",
-                    "4" => "r",
-                    "g" => "b",
-                    "t" => "g",
-                    "5" => "t",
-                    "h" => "n",
-                    "y" => "h",
-                    "6" => "y",
-                    "j" => "m",
-                    "u" => "j",
-                    "7" => "u",
-                    "i" => "k",
-                    "8" => "i",
-                    "o" => "l",
-                    "9" => "o",
-                    "0" => "p",
-                );
-
-                $keyboardmap_downleft = array(
-                    "2" => "q",
-                    "w" => "a",
-                    "3" => "w",
-                    "s" => "z",
-                    "e" => "s",
-                    "4" => "e",
-                    "d" => "x",
-                    "r" => "d",
-                    "5" => "r",
-                    "f" => "c",
-                    "t" => "f",
-                    "6" => "t",
-                    "g" => "v",
-                    "y" => "g",
-                    "7" => "y",
-                    "h" => "b",
-                    "u" => "h",
-                    "8" => "u",
-                    "j" => "n",
-                    "i" => "j",
-                    "9" => "i",
-                    "k" => "m",
-                    "o" => "k",
-                    "0" => "o",
-                    "p" => "l",
-                    "-" => "p",
-                );
-
-                $password2 = str_replace(array_keys($keyboardmap_downright), array_values($keyboardmap_downright), $password);
-                $passwords[] = $password2;
-                $passwords[] = strrev($password2);
-
-                $password2 = str_replace(array_keys($keyboardmap_downleft), array_values($keyboardmap_downleft), $password);
-                $passwords[] = $password2;
-                $passwords[] = strrev($password2);
-            }
-
-            // Deal with LEET-Speak substitutions.
-            $leetspeakmap = array(
-                "@" => "a",
-                "!" => "i",
-                "$" => "s",
-                "1" => "i",
-                "2" => "z",
-                "3" => "e",
-                "4" => "a",
-                "5" => "s",
-                "6" => "g",
-                "7" => "t",
-                "8" => "b",
-                "9" => "g",
-                "0" => "o"
-            );
-
-            $password2 = str_replace(array_keys($leetspeakmap), array_values($leetspeakmap), $password);
-            $passwords[] = $password2;
-            $passwords[] = strrev($password2);
-
-            $leetspeakmap["1"] = "l";
-            $password3 = str_replace(array_keys($leetspeakmap), array_values($leetspeakmap), $password);
-            if ($password3 != $password2)
-            {
-                $passwords[] = $password3;
-                $passwords[] = strrev($password3);
-            }
-
-            // Process the password, while looking for words in the dictionary.
-            $a = ord("a");
-            $z = ord("z");
-            $data = file_get_contents(DICTIONARY_PATH);
-            foreach ($passwords as $num => $password)
-            {
-                $y = strlen($password);
-                for ($x = 0; $x < $y; $x++)
-                {
-                    $tempchr = ord(substr($password, $x, 1));
-                    if ($tempchr >= $a && $tempchr <= $z)
-                    {
-                        for ($x2 = $x + 1; $x2 < $y; $x2++)
-                        {
-                            $tempchr = ord(substr($password, $x2, 1));
-                            if ($tempchr < $a || $tempchr > $z)  break;
-                        }
-
-                        $found = false;
-                        while (!$found && $x2 - $x >= $minwordlen)
-                        {
-                            $word = "/\\n" . substr($password, $x, $minwordlen);
-                            for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++)  $word .= "(" . $password{$x3};
-                            for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++)  $word .= ")?";
-                            $word .= "\\n/";
-
-                            preg_match_all($word, $data, $matches);
-                            if (!count($matches[0]))
-                            {
-                                $password{$x} = "*";
-                                $x++;
-                                $numbits = self::getNISTNumBits(substr($password, 0, $x)) + $extrabits;
-                                if ($numbits >= $minbits)  $found = true;
-                            }
-                            else
-                            {
-                                foreach ($matches[0] as $match)
-                                {
-                                    $password2 = str_replace(trim($match), "*", $password);
-                                    $numbits = self::getNISTNumBits($password2) + $extrabits;
-                                    if ($result > $numbits)  $result = $numbits;
-
-                                    if ($result < $minbits)  return false;
-                                }
-
-                                $found = true;
-                            }
-                        }
-
-                        if ($found)  break;
-
-                        $x = $x2 - 1;
-                    }
-                }
-            }
-        }
-
-        return $result >= $minbits;
-    }
+	/**
+	 * A standardized method for hasing a password before storing
+	 * in the database.
+	 *
+	 * @param $password
+	 * @return bool|mixed|string
+	 */
+	public static function hashPassword($password)
+	{
+		if (! config_item('auth.hash_cost'))
+		{
+			get_instance()->load->config('auth');
+		}
+
+		return password_hash($password, PASSWORD_DEFAULT, ['cost' => config_item('auth.hash_cost')]);
+	}
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Determines the number of entropy bits a password has based on
+	 *
+	 *
+	 * @param $password
+	 * @param bool $repeatcalc
+	 * @return int
+	 */
+	public static function getNISTNumBits($password, $repeatcalc = false)
+	{
+		$y = strlen($password);
+		if ($repeatcalc)
+		{
+			// Variant on NIST rules to reduce long sequences of repeated characters.
+			$result = 0;
+			$charmult = array_fill(0, 256, 1);
+			for ($x = 0; $x < $y; $x++)
+			{
+				$tempchr = ord(substr($password, $x, 1));
+				if ($x > 19)  $result += $charmult[$tempchr];
+				else if ($x > 7)  $result += $charmult[$tempchr] * 1.5;
+				else if ($x > 0)  $result += $charmult[$tempchr] * 2;
+				else  $result += 4;
+
+				$charmult[$tempchr] *= 0.75;
+			}
+
+			return $result;
+		}
+		else
+		{
+			if ($y > 20)  return 4 + (7 * 2) + (12 * 1.5) + $y - 20;
+			if ($y > 8)  return 4 + (7 * 2) + (($y - 8) * 1.5);
+			if ($y > 1)  return 4 + (($y - 1) * 2);
+
+			return ($y == 1 ? 4 : 0);
+		}
+	}
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * Determines whether a password is strong enough to use. You should check
+	 * the password against this method and reject it if the password is not
+	 * strong enough.
+	 *
+	 * The following guidelines come from the author's tests against 10.4 million actual passwords
+	 * ( see post: http://cubicspot.blogspot.com/2012/01/how-to-calculate-password-strength-part.html )
+	 * and represents the suggested minimum entropy bits for different types of sites:
+	 *
+	 *      - 18 bits of entropy = minimum for ANY website.
+	 *      - 25 bits of entropy = minimum for a general purpose web service used relatively widely (e.g. Hotmail).
+	 *      - 30 bits of entropy = minimum for a web service with business critical applications (e.g. SAAS).
+	 *      - 40 bits of entropy = minimum for a bank or other financial service.
+	 *
+	 * The algorithm is based upon a modified version of the NIST rules which suggest the following:
+	 *
+	 *      - The first byte counts as 4 bits.
+	 *      - The next 7 bytes count as 2 bits each.
+	 *      - The next 12 bytes count as 1.5 bits each.
+	 *      - Anything beyond that counts as 1 bit each.
+	 *      - Mixed case + non-alphanumeric = up to 6 extra bits.
+	 *
+	 * @param string    $password   - The password to check
+	 * @param int       $minbits    - Minimum "entropy bits" that is allowed
+	 * @param bool      $usedict    - Should we check the password against a 300,000 word English dictionary?
+	 * @param int       $minwordlen -
+	 * @return bool
+	 */
+	public static function isStrongPassword($password, $minbits = 18, $usedict = false, $minwordlen = 4)
+	{
+		// NIST password strength rules allow up to 6 extra bits for mixed case and non-alphabetic.
+		$upper = false;
+		$lower = false;
+		$numeric = false;
+		$other = false;
+		$space = false;
+		$y = strlen($password);
+		for ($x = 0; $x < $y; $x++)
+		{
+			$tempchr = ord(substr($password, $x, 1));
+			if ($tempchr >= ord("A") && $tempchr <= ord("Z"))  $upper = true;
+			else if ($tempchr >= ord("a") && $tempchr <= ord("z"))  $lower = true;
+			else if ($tempchr >= ord("0") && $tempchr <= ord("9"))  $numeric = true;
+			else if ($tempchr == ord(" "))  $space = true;
+			else  $other = true;
+		}
+		$extrabits = ($upper && $lower && $other ? ($numeric ? 6 : 5) : ($numeric && !$upper && !$lower ? ($other ? -2 : -6) : 0));
+		if (!$space)  $extrabits -= 2;
+		else if (count(explode(" ", preg_replace('/\s+/', " ", $password))) > 3)  $extrabits++;
+		$result = self::getNISTNumBits($password, true) + $extrabits;
+
+		$password = strtolower($password);
+		$revpassword = strrev($password);
+		$numbits = self::getNISTNumBits($password) + $extrabits;
+		if ($result > $numbits)  $result = $numbits;
+
+		// Remove QWERTY strings.
+		$qwertystrs = array(
+			"1234567890-qwertyuiopasdfghjkl;zxcvbnm,./",
+			"1qaz2wsx3edc4rfv5tgb6yhn7ujm8ik,9ol.0p;/-['=]:?_{\"+}",
+			"1qaz2wsx3edc4rfv5tgb6yhn7ujm8ik9ol0p",
+			"qazwsxedcrfvtgbyhnujmik,ol.p;/-['=]:?_{\"+}",
+			"qazwsxedcrfvtgbyhnujmikolp",
+			"]\"/=[;.-pl,0okm9ijn8uhb7ygv6tfc5rdx4esz3wa2q1",
+			"pl0okm9ijn8uhb7ygv6tfc5rdx4esz3wa2q1",
+			"]\"/[;.pl,okmijnuhbygvtfcrdxeszwaq",
+			"plokmijnuhbygvtfcrdxeszwaq",
+			"014725836914702583697894561230258/369*+-*/",
+			"abcdefghijklmnopqrstuvwxyz"
+		);
+		foreach ($qwertystrs as $qwertystr)
+		{
+			$qpassword = $password;
+			$qrevpassword = $revpassword;
+			$z = 6;
+			do
+			{
+				$y = strlen($qwertystr) - $z;
+				for ($x = 0; $x < $y; $x++)
+				{
+					$str = substr($qwertystr, $x, $z);
+					$qpassword = str_replace($str, "*", $qpassword);
+					$qrevpassword = str_replace($str, "*", $qrevpassword);
+				}
+
+				$z--;
+			} while ($z > 2);
+
+			$numbits = self::getNISTNumBits($qpassword) + $extrabits;
+			if ($result > $numbits)  $result = $numbits;
+			$numbits = self::getNISTNumBits($qrevpassword) + $extrabits;
+			if ($result > $numbits)  $result = $numbits;
+
+			if ($result < $minbits)  return false;
+		}
+
+		if ($usedict && $result >= $minbits)
+		{
+			$passwords = array();
+
+			// Add keyboard shifting password variants.
+			$keyboardmap_down_noshift = array(
+				"z" => "", "x" => "", "c" => "", "v" => "", "b" => "", "n" => "", "m" => "", "," => "", "." => "", "/" => "", "<" => "", ">" => "", "?" => ""
+			);
+			if ($password == str_replace(array_keys($keyboardmap_down_noshift), array_values($keyboardmap_down_noshift), $password))
+			{
+				$keyboardmap_downright = array(
+					"a" => "z",
+					"q" => "a",
+					"1" => "q",
+					"s" => "x",
+					"w" => "s",
+					"2" => "w",
+					"d" => "c",
+					"e" => "d",
+					"3" => "e",
+					"f" => "v",
+					"r" => "f",
+					"4" => "r",
+					"g" => "b",
+					"t" => "g",
+					"5" => "t",
+					"h" => "n",
+					"y" => "h",
+					"6" => "y",
+					"j" => "m",
+					"u" => "j",
+					"7" => "u",
+					"i" => "k",
+					"8" => "i",
+					"o" => "l",
+					"9" => "o",
+					"0" => "p",
+				);
+
+				$keyboardmap_downleft = array(
+					"2" => "q",
+					"w" => "a",
+					"3" => "w",
+					"s" => "z",
+					"e" => "s",
+					"4" => "e",
+					"d" => "x",
+					"r" => "d",
+					"5" => "r",
+					"f" => "c",
+					"t" => "f",
+					"6" => "t",
+					"g" => "v",
+					"y" => "g",
+					"7" => "y",
+					"h" => "b",
+					"u" => "h",
+					"8" => "u",
+					"j" => "n",
+					"i" => "j",
+					"9" => "i",
+					"k" => "m",
+					"o" => "k",
+					"0" => "o",
+					"p" => "l",
+					"-" => "p",
+				);
+
+				$password2 = str_replace(array_keys($keyboardmap_downright), array_values($keyboardmap_downright), $password);
+				$passwords[] = $password2;
+				$passwords[] = strrev($password2);
+
+				$password2 = str_replace(array_keys($keyboardmap_downleft), array_values($keyboardmap_downleft), $password);
+				$passwords[] = $password2;
+				$passwords[] = strrev($password2);
+			}
+
+			// Deal with LEET-Speak substitutions.
+			$leetspeakmap = array(
+				"@" => "a",
+				"!" => "i",
+				"$" => "s",
+				"1" => "i",
+				"2" => "z",
+				"3" => "e",
+				"4" => "a",
+				"5" => "s",
+				"6" => "g",
+				"7" => "t",
+				"8" => "b",
+				"9" => "g",
+				"0" => "o"
+			);
+
+			$password2 = str_replace(array_keys($leetspeakmap), array_values($leetspeakmap), $password);
+			$passwords[] = $password2;
+			$passwords[] = strrev($password2);
+
+			$leetspeakmap["1"] = "l";
+			$password3 = str_replace(array_keys($leetspeakmap), array_values($leetspeakmap), $password);
+			if ($password3 != $password2)
+			{
+				$passwords[] = $password3;
+				$passwords[] = strrev($password3);
+			}
+
+			// Process the password, while looking for words in the dictionary.
+			$a = ord("a");
+			$z = ord("z");
+			$data = file_get_contents(DICTIONARY_PATH);
+			foreach ($passwords as $num => $password)
+			{
+				$y = strlen($password);
+				for ($x = 0; $x < $y; $x++)
+				{
+					$tempchr = ord(substr($password, $x, 1));
+					if ($tempchr >= $a && $tempchr <= $z)
+					{
+						for ($x2 = $x + 1; $x2 < $y; $x2++)
+						{
+							$tempchr = ord(substr($password, $x2, 1));
+							if ($tempchr < $a || $tempchr > $z)  break;
+						}
+
+						$found = false;
+						while (!$found && $x2 - $x >= $minwordlen)
+						{
+							$word = "/\\n" . substr($password, $x, $minwordlen);
+							for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++)  $word .= "(" . $password{$x3};
+							for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++)  $word .= ")?";
+							$word .= "\\n/";
+
+							preg_match_all($word, $data, $matches);
+							if (!count($matches[0]))
+							{
+								$password{$x} = "*";
+								$x++;
+								$numbits = self::getNISTNumBits(substr($password, 0, $x)) + $extrabits;
+								if ($numbits >= $minbits)  $found = true;
+							}
+							else
+							{
+								foreach ($matches[0] as $match)
+								{
+									$password2 = str_replace(trim($match), "*", $password);
+									$numbits = self::getNISTNumBits($password2) + $extrabits;
+									if ($result > $numbits)  $result = $numbits;
+
+									if ($result < $minbits)  return false;
+								}
+
+								$found = true;
+							}
+						}
+
+						if ($found)  break;
+
+						$x = $x2 - 1;
+					}
+				}
+			}
+		}
+
+		return $result >= $minbits;
+	}
 }

Spacing +8 added lines, -8 removed lines

@@ -30,7 +30,7 @@ 
  * @since       Version 1.0
  */
 
-define('DICTIONARY_PATH', dirname(__FILE__) .'/dictionary.txt');
+define('DICTIONARY_PATH', dirname(__FILE__).'/dictionary.txt');
 
 /**
  * Class Password
@@ -60,7 +60,7 @@ 
      */
     public static function hashPassword($password)
     {
-        if (! config_item('auth.hash_cost'))
+        if ( ! config_item('auth.hash_cost'))
         {
             get_instance()->load->config('auth');
         }
@@ -157,8 +157,8 @@ 
             else if ($tempchr == ord(" "))  $space = true;
             else  $other = true;
         }
-        $extrabits = ($upper && $lower && $other ? ($numeric ? 6 : 5) : ($numeric && !$upper && !$lower ? ($other ? -2 : -6) : 0));
-        if (!$space)  $extrabits -= 2;
+        $extrabits = ($upper && $lower && $other ? ($numeric ? 6 : 5) : ($numeric && ! $upper && ! $lower ? ($other ? -2 : -6) : 0));
+        if ( ! $space)  $extrabits -= 2;
         else if (count(explode(" ", preg_replace('/\s+/', " ", $password))) > 3)  $extrabits++;
         $result = self::getNISTNumBits($password, true) + $extrabits;
 
@@ -332,15 +332,15 @@ 
                         }
 
                         $found = false;
-                        while (!$found && $x2 - $x >= $minwordlen)
+                        while ( ! $found && $x2 - $x >= $minwordlen)
                         {
-                            $word = "/\\n" . substr($password, $x, $minwordlen);
-                            for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++)  $word .= "(" . $password{$x3};
+                            $word = "/\\n".substr($password, $x, $minwordlen);
+                            for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++)  $word .= "(".$password{$x3};
                             for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++)  $word .= ")?";
                             $word .= "\\n/";
 
                             preg_match_all($word, $data, $matches);
-                            if (!count($matches[0]))
+                            if ( ! count($matches[0]))
                             {
                                 $password{$x} = "*";
                                 $x++;

Braces +69 added lines, -29 removed lines

@@ -89,21 +89,31 @@ 
             for ($x = 0; $x < $y; $x++)
             {
                 $tempchr = ord(substr($password, $x, 1));
-                if ($x > 19)  $result += $charmult[$tempchr];
-                else if ($x > 7)  $result += $charmult[$tempchr] * 1.5;
-                else if ($x > 0)  $result += $charmult[$tempchr] * 2;
-                else  $result += 4;
+                if ($x > 19) {
+                	$result += $charmult[$tempchr];
+                } else if ($x > 7) {
+                	$result += $charmult[$tempchr] * 1.5;
+                } else if ($x > 0) {
+                	$result += $charmult[$tempchr] * 2;
+                } else {
+                	$result += 4;
+                }
 
                 $charmult[$tempchr] *= 0.75;
             }
 
             return $result;
-        }
-        else
+        } else
         {
-            if ($y > 20)  return 4 + (7 * 2) + (12 * 1.5) + $y - 20;
-            if ($y > 8)  return 4 + (7 * 2) + (($y - 8) * 1.5);
-            if ($y > 1)  return 4 + (($y - 1) * 2);
+            if ($y > 20) {
+            	return 4 + (7 * 2) + (12 * 1.5) + $y - 20;
+            }
+            if ($y > 8) {
+            	return 4 + (7 * 2) + (($y - 8) * 1.5);
+            }
+            if ($y > 1) {
+            	return 4 + (($y - 1) * 2);
+            }
 
             return ($y == 1 ? 4 : 0);
         }
@@ -151,21 +161,32 @@ 
         for ($x = 0; $x < $y; $x++)
         {
             $tempchr = ord(substr($password, $x, 1));
-            if ($tempchr >= ord("A") && $tempchr <= ord("Z"))  $upper = true;
-            else if ($tempchr >= ord("a") && $tempchr <= ord("z"))  $lower = true;
-            else if ($tempchr >= ord("0") && $tempchr <= ord("9"))  $numeric = true;
-            else if ($tempchr == ord(" "))  $space = true;
-            else  $other = true;
+            if ($tempchr >= ord("A") && $tempchr <= ord("Z")) {
+            	$upper = true;
+            } else if ($tempchr >= ord("a") && $tempchr <= ord("z")) {
+            	$lower = true;
+            } else if ($tempchr >= ord("0") && $tempchr <= ord("9")) {
+            	$numeric = true;
+            } else if ($tempchr == ord(" ")) {
+            	$space = true;
+            } else {
+            	$other = true;
+            }
         }
         $extrabits = ($upper && $lower && $other ? ($numeric ? 6 : 5) : ($numeric && !$upper && !$lower ? ($other ? -2 : -6) : 0));
-        if (!$space)  $extrabits -= 2;
-        else if (count(explode(" ", preg_replace('/\s+/', " ", $password))) > 3)  $extrabits++;
+        if (!$space) {
+        	$extrabits -= 2;
+        } else if (count(explode(" ", preg_replace('/\s+/', " ", $password))) > 3) {
+        	$extrabits++;
+        }
         $result = self::getNISTNumBits($password, true) + $extrabits;
 
         $password = strtolower($password);
         $revpassword = strrev($password);
         $numbits = self::getNISTNumBits($password) + $extrabits;
-        if ($result > $numbits)  $result = $numbits;
+        if ($result > $numbits) {
+        	$result = $numbits;
+        }
 
         // Remove QWERTY strings.
         $qwertystrs = array(
@@ -200,11 +221,17 @@ 
             } while ($z > 2);
 
             $numbits = self::getNISTNumBits($qpassword) + $extrabits;
-            if ($result > $numbits)  $result = $numbits;
+            if ($result > $numbits) {
+            	$result = $numbits;
+            }
             $numbits = self::getNISTNumBits($qrevpassword) + $extrabits;
-            if ($result > $numbits)  $result = $numbits;
+            if ($result > $numbits) {
+            	$result = $numbits;
+            }
 
-            if ($result < $minbits)  return false;
+            if ($result < $minbits) {
+            	return false;
+            }
         }
 
         if ($usedict && $result >= $minbits)
@@ -328,15 +355,21 @@ 
                         for ($x2 = $x + 1; $x2 < $y; $x2++)
                         {
                             $tempchr = ord(substr($password, $x2, 1));
-                            if ($tempchr < $a || $tempchr > $z)  break;
+                            if ($tempchr < $a || $tempchr > $z) {
+                            	break;
+                            }
                         }
 
                         $found = false;
                         while (!$found && $x2 - $x >= $minwordlen)
                         {
                             $word = "/\\n" . substr($password, $x, $minwordlen);
-                            for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++)  $word .= "(" . $password{$x3};
-                            for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++)  $word .= ")?";
+                            for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++) {
+                            	$word .= "(" . $password{$x3};
+                            }
+                            for ($x3 = $x + $minwordlen; $x3 < $x2; $x3++) {
+                            	$word .= ")?";
+                            }
                             $word .= "\\n/";
 
                             preg_match_all($word, $data, $matches);
@@ -345,24 +378,31 @@ 
                                 $password{$x} = "*";
                                 $x++;
                                 $numbits = self::getNISTNumBits(substr($password, 0, $x)) + $extrabits;
-                                if ($numbits >= $minbits)  $found = true;
-                            }
-                            else
+                                if ($numbits >= $minbits) {
+                                	$found = true;
+                                }
+                            } else
                             {
                                 foreach ($matches[0] as $match)
                                 {
                                     $password2 = str_replace(trim($match), "*", $password);
                                     $numbits = self::getNISTNumBits($password2) + $extrabits;
-                                    if ($result > $numbits)  $result = $numbits;
+                                    if ($result > $numbits) {
+                                    	$result = $numbits;
+                                    }
 
-                                    if ($result < $minbits)  return false;
+                                    if ($result < $minbits) {
+                                    	return false;
+                                    }
                                 }
 
                                 $found = true;
                             }
                         }
 
-                        if ($found)  break;
+                        if ($found) {
+                        	break;
+                        }
 
                         $x = $x2 - 1;
                     }

myth/CIModules/auth/controllers/Auth.php

Spacing +18 added lines, -18 removed lines

@@ -71,14 +71,14 @@ 
                 'password' => $this->input->post('password')
             ];
 
-            $remember = (bool)$this->input->post('remember');
+            $remember = (bool) $this->input->post('remember');
 
             if ($auth->login($post_data, $remember))
             {
 	            // Is the user being forced to reset their password?
 	            if ($auth->user()['force_pass_reset'] == 1)
 	            {
-		            redirect( Route::named('change_pass') );
+		            redirect(Route::named('change_pass'));
 	            }
 
                 unset($_SESSION['redirect_url']);
@@ -135,7 +135,7 @@ 
             if ($auth->registerUser($post_data))
             {
                 $this->setMessage(lang('auth.did_register'), 'success');
-                redirect( Route::named('login') );
+                redirect(Route::named('login'));
             }
             else
             {
@@ -168,7 +168,7 @@ 
             if ($auth->activateUser($post_data))
             {
                 $this->setMessage(lang('auth.did_activate'), 'success');
-                redirect( Route::named('login') );
+                redirect(Route::named('login'));
             }
             else
             {
@@ -201,7 +201,7 @@ 
             if ($auth->remindUser($this->input->post('email')))
             {
                 $this->setMessage(lang('auth.send_success'), 'success');
-                redirect( Route::named('reset_pass') );
+                redirect(Route::named('reset_pass'));
             }
             else
             {
@@ -236,7 +236,7 @@ 
             if ($auth->resetPassword($credentials, $password, $pass_confirm))
             {
                 $this->setMessage(lang('auth.new_password_success'), 'success');
-                redirect( Route::named('login') );
+                redirect(Route::named('login'));
             }
             else
             {
@@ -267,9 +267,9 @@ 
 		$this->load->model('user_model');
 		$auth->useModel($this->user_model);
 
-		if (! $auth->isLoggedIn())
+		if ( ! $auth->isLoggedIn())
 		{
-			redirect( Route::named('login') );
+			redirect(Route::named('login'));
 		}
 
 		$this->load->helper('form');
@@ -281,35 +281,35 @@ 
 			$pass_confirm = $this->input->post('pass_confirm');
 
 			// Does the current password match?
-			if (! password_verify($current_pass, $auth->user()['password_hash']))
+			if ( ! password_verify($current_pass, $auth->user()['password_hash']))
 			{
-				$this->setMessage( lang('auth.bad_current_pass'), 'warning');
-				redirect( current_url() );
+				$this->setMessage(lang('auth.bad_current_pass'), 'warning');
+				redirect(current_url());
 			}
 
 			// Do the passwords match?
 			if ($password != $pass_confirm)
 			{
-				$this->setMessage( lang('auth.pass_must_match'), 'warning');
-				redirect( current_url() );
+				$this->setMessage(lang('auth.pass_must_match'), 'warning');
+				redirect(current_url());
 			}
 
 			$hash = \Myth\Auth\Password::hashPassword($password);
 
-			if (! $this->user_model->update( $auth->id(), ['password_hash' => $hash, 'force_pass_reset' => 0]) )
+			if ( ! $this->user_model->update($auth->id(), ['password_hash' => $hash, 'force_pass_reset' => 0]))
 			{
-				$this->setMessage( 'Error: '. $this->user_model->error(), 'danger');
-				redirect( current_url() );
+				$this->setMessage('Error: '.$this->user_model->error(), 'danger');
+				redirect(current_url());
 			}
 
 			$redirect_url = $this->session->userdata('redirect_url');
 			unset($_SESSION['redirect_url']);
 
-			$this->setMessage( lang('auth.new_password_success'), 'success' );
+			$this->setMessage(lang('auth.new_password_success'), 'success');
 
 			$auth->logout();
 
-			redirect( Route::named('login') );
+			redirect(Route::named('login'));
 		}
 
 		$this->addScript('register.js');

Braces +4 added lines, -8 removed lines

@@ -136,8 +136,7 @@ 
             {
                 $this->setMessage(lang('auth.did_register'), 'success');
                 redirect( Route::named('login') );
-            }
-            else
+            } else
             {
                 $this->setMessage($auth->error(), 'danger');
             }
@@ -169,8 +168,7 @@ 
             {
                 $this->setMessage(lang('auth.did_activate'), 'success');
                 redirect( Route::named('login') );
-            }
-            else
+            } else
             {
                 $this->setMessage($auth->error(), 'danger');
             }
@@ -202,8 +200,7 @@ 
             {
                 $this->setMessage(lang('auth.send_success'), 'success');
                 redirect( Route::named('reset_pass') );
-            }
-            else
+            } else
             {
                 $this->setMessage($auth->error(), 'danger');
             }
@@ -237,8 +234,7 @@ 
             {
                 $this->setMessage(lang('auth.new_password_success'), 'success');
                 redirect( Route::named('login') );
-            }
-            else
+            } else
             {
                 $this->setMessage($auth->error(), 'danger');
             }

Indentation +234 added lines, -234 removed lines

@@ -36,225 +36,225 @@ 
 class Auth extends \Myth\Controllers\ThemedController
 {
 
-    public function __construct()
-    {
-        parent::__construct();
-
-        $this->config->load('auth');
-        $this->lang->load('auth');
-        $this->load->library('session');
-    }
-
-    //--------------------------------------------------------------------
-
-    public function login()
-    {
-        $this->load->helper('form');
-
-        $auth = new LocalAuthentication();
-        $this->load->model('user_model');
-        $auth->useModel($this->user_model);
-
-        $redirect_url = $this->session->userdata('redirect_url');
-
-        // No need to login again if they are already logged in...
-        if ($auth->isLoggedIn())
-        {
-            unset($_SESSION['redirect_url']);
-            redirect($redirect_url);
-        }
-
-        if ($this->input->post())
-        {
-            $post_data = [
-                'email'    => $this->input->post('email'),
-                'password' => $this->input->post('password')
-            ];
-
-            $remember = (bool)$this->input->post('remember');
-
-            if ($auth->login($post_data, $remember))
-            {
-	            // Is the user being forced to reset their password?
-	            if ($auth->user()['force_pass_reset'] == 1)
-	            {
-		            redirect( Route::named('change_pass') );
-	            }
-
-                unset($_SESSION['redirect_url']);
-                $this->setMessage(lang('auth.did_login'), 'success');
-                redirect($redirect_url);
-            }
-
-            $this->setMessage(lang('auth.invalid_user'), 'danger');
-        }
-
-        $this->themer->setLayout('login');
-        $this->render();
-    }
-
-    //--------------------------------------------------------------------
-
-    public function logout()
-    {
-        $auth = new LocalAuthentication();
-        $this->load->model('user_model');
-        $auth->useModel($this->user_model);
-
-        if ($auth->isLoggedIn())
-        {
-            $auth->logout();
-
-            $this->setMessage(lang('auth.did_logout'), 'success');
-        }
-
-        redirect('/');
-    }
-
-    //--------------------------------------------------------------------
-
-    public function register()
-    {
-        $this->load->helper('form');
-
-        if ($this->input->post())
-        {
-            $auth = new LocalAuthentication();
-            $this->load->model('user_model');
-            $auth->useModel($this->user_model);
-
-            $post_data = [
-                'first_name'   => $this->input->post('first_name'),
-                'last_name'    => $this->input->post('last_name'),
-                'email'        => $this->input->post('email'),
-                'username'     => $this->input->post('username'),
-                'password'     => $this->input->post('password'),
-                'pass_confirm' => $this->input->post('pass_confirm')
-            ];
-
-            if ($auth->registerUser($post_data))
-            {
-                $this->setMessage(lang('auth.did_register'), 'success');
-                redirect( Route::named('login') );
-            }
-            else
-            {
-                $this->setMessage($auth->error(), 'danger');
-            }
-        }
-
-        $this->addScript('register.js');
-        $this->themer->setLayout('login');
-        $this->render();
-    }
-
-    //--------------------------------------------------------------------
-
-    public function activate_user()
-    {
-        $this->load->helper('form');
-
-        if ($this->input->post())
-        {
-            $auth = new LocalAuthentication();
-            $this->load->model('user_model');
-            $auth->useModel($this->user_model);
-
-            $post_data = [
-                  'email' => $this->input->post('email'),
-                  'code'  => $this->input->post('code')
-            ];
-
-            if ($auth->activateUser($post_data))
-            {
-                $this->setMessage(lang('auth.did_activate'), 'success');
-                redirect( Route::named('login') );
-            }
-            else
-            {
-                $this->setMessage($auth->error(), 'danger');
-            }
-        }
-
-        $data = [
-            'email' => $this->input->get('e'),
-            'code'  => $this->input->get('code')
-        ];
-
-        $this->themer->setLayout('login');
-        $this->render($data);
-    }
-
-    //--------------------------------------------------------------------
-
-
-    public function forgot_password()
-    {
-        $this->load->helper('form');
-
-        if ($this->input->post())
-        {
-            $auth = new LocalAuthentication();
-            $this->load->model('user_model');
-            $auth->useModel($this->user_model);
-
-            if ($auth->remindUser($this->input->post('email')))
-            {
-                $this->setMessage(lang('auth.send_success'), 'success');
-                redirect( Route::named('reset_pass') );
-            }
-            else
-            {
-                $this->setMessage($auth->error(), 'danger');
-            }
-        }
-
-        $this->themer->setLayout('login');
-        $this->render();
-    }
-
-    //--------------------------------------------------------------------
-
-    public function reset_password()
-    {
-        $this->load->helper('form');
-
-        if ($this->input->post())
-        {
-            $auth = new LocalAuthentication();
-            $this->load->model('user_model');
-            $auth->useModel($this->user_model);
-
-            $credentials = [
-                'email' => $this->input->post('email'),
-                'code'  => $this->input->post('code')
-            ];
-
-            $password     = $this->input->post('password');
-            $pass_confirm = $this->input->post('pass_confirm');
-
-            if ($auth->resetPassword($credentials, $password, $pass_confirm))
-            {
-                $this->setMessage(lang('auth.new_password_success'), 'success');
-                redirect( Route::named('login') );
-            }
-            else
-            {
-                $this->setMessage($auth->error(), 'danger');
-            }
-        }
-
-        $data = [
-            'email' => $this->input->get('e'),
-            'code'  => $this->input->get('code')
-        ];
-
-        $this->addScript('register.js');
-        $this->themer->setLayout('login');
-        $this->render($data);
-    }
-
-    //--------------------------------------------------------------------
+	public function __construct()
+	{
+		parent::__construct();
+
+		$this->config->load('auth');
+		$this->lang->load('auth');
+		$this->load->library('session');
+	}
+
+	//--------------------------------------------------------------------
+
+	public function login()
+	{
+		$this->load->helper('form');
+
+		$auth = new LocalAuthentication();
+		$this->load->model('user_model');
+		$auth->useModel($this->user_model);
+
+		$redirect_url = $this->session->userdata('redirect_url');
+
+		// No need to login again if they are already logged in...
+		if ($auth->isLoggedIn())
+		{
+			unset($_SESSION['redirect_url']);
+			redirect($redirect_url);
+		}
+
+		if ($this->input->post())
+		{
+			$post_data = [
+				'email'    => $this->input->post('email'),
+				'password' => $this->input->post('password')
+			];
+
+			$remember = (bool)$this->input->post('remember');
+
+			if ($auth->login($post_data, $remember))
+			{
+				// Is the user being forced to reset their password?
+				if ($auth->user()['force_pass_reset'] == 1)
+				{
+					redirect( Route::named('change_pass') );
+				}
+
+				unset($_SESSION['redirect_url']);
+				$this->setMessage(lang('auth.did_login'), 'success');
+				redirect($redirect_url);
+			}
+
+			$this->setMessage(lang('auth.invalid_user'), 'danger');
+		}
+
+		$this->themer->setLayout('login');
+		$this->render();
+	}
+
+	//--------------------------------------------------------------------
+
+	public function logout()
+	{
+		$auth = new LocalAuthentication();
+		$this->load->model('user_model');
+		$auth->useModel($this->user_model);
+
+		if ($auth->isLoggedIn())
+		{
+			$auth->logout();
+
+			$this->setMessage(lang('auth.did_logout'), 'success');
+		}
+
+		redirect('/');
+	}
+
+	//--------------------------------------------------------------------
+
+	public function register()
+	{
+		$this->load->helper('form');
+
+		if ($this->input->post())
+		{
+			$auth = new LocalAuthentication();
+			$this->load->model('user_model');
+			$auth->useModel($this->user_model);
+
+			$post_data = [
+				'first_name'   => $this->input->post('first_name'),
+				'last_name'    => $this->input->post('last_name'),
+				'email'        => $this->input->post('email'),
+				'username'     => $this->input->post('username'),
+				'password'     => $this->input->post('password'),
+				'pass_confirm' => $this->input->post('pass_confirm')
+			];
+
+			if ($auth->registerUser($post_data))
+			{
+				$this->setMessage(lang('auth.did_register'), 'success');
+				redirect( Route::named('login') );
+			}
+			else
+			{
+				$this->setMessage($auth->error(), 'danger');
+			}
+		}
+
+		$this->addScript('register.js');
+		$this->themer->setLayout('login');
+		$this->render();
+	}
+
+	//--------------------------------------------------------------------
+
+	public function activate_user()
+	{
+		$this->load->helper('form');
+
+		if ($this->input->post())
+		{
+			$auth = new LocalAuthentication();
+			$this->load->model('user_model');
+			$auth->useModel($this->user_model);
+
+			$post_data = [
+				  'email' => $this->input->post('email'),
+				  'code'  => $this->input->post('code')
+			];
+
+			if ($auth->activateUser($post_data))
+			{
+				$this->setMessage(lang('auth.did_activate'), 'success');
+				redirect( Route::named('login') );
+			}
+			else
+			{
+				$this->setMessage($auth->error(), 'danger');
+			}
+		}
+
+		$data = [
+			'email' => $this->input->get('e'),
+			'code'  => $this->input->get('code')
+		];
+
+		$this->themer->setLayout('login');
+		$this->render($data);
+	}
+
+	//--------------------------------------------------------------------
+
+
+	public function forgot_password()
+	{
+		$this->load->helper('form');
+
+		if ($this->input->post())
+		{
+			$auth = new LocalAuthentication();
+			$this->load->model('user_model');
+			$auth->useModel($this->user_model);
+
+			if ($auth->remindUser($this->input->post('email')))
+			{
+				$this->setMessage(lang('auth.send_success'), 'success');
+				redirect( Route::named('reset_pass') );
+			}
+			else
+			{
+				$this->setMessage($auth->error(), 'danger');
+			}
+		}
+
+		$this->themer->setLayout('login');
+		$this->render();
+	}
+
+	//--------------------------------------------------------------------
+
+	public function reset_password()
+	{
+		$this->load->helper('form');
+
+		if ($this->input->post())
+		{
+			$auth = new LocalAuthentication();
+			$this->load->model('user_model');
+			$auth->useModel($this->user_model);
+
+			$credentials = [
+				'email' => $this->input->post('email'),
+				'code'  => $this->input->post('code')
+			];
+
+			$password     = $this->input->post('password');
+			$pass_confirm = $this->input->post('pass_confirm');
+
+			if ($auth->resetPassword($credentials, $password, $pass_confirm))
+			{
+				$this->setMessage(lang('auth.new_password_success'), 'success');
+				redirect( Route::named('login') );
+			}
+			else
+			{
+				$this->setMessage($auth->error(), 'danger');
+			}
+		}
+
+		$data = [
+			'email' => $this->input->get('e'),
+			'code'  => $this->input->get('code')
+		];
+
+		$this->addScript('register.js');
+		$this->themer->setLayout('login');
+		$this->render($data);
+	}
+
+	//--------------------------------------------------------------------
 
 	/**
 	 * Allows a logged in user to enter their current password
@@ -320,24 +320,24 @@ 
 	//--------------------------------------------------------------------
 
 
-    //--------------------------------------------------------------------
-    // AJAX Methods
-    //--------------------------------------------------------------------
+	//--------------------------------------------------------------------
+	// AJAX Methods
+	//--------------------------------------------------------------------
 
-    /**
-     * Checks the password strength and returns pass/fail.
-     *
-     * @param $str
-     */
-    public function password_check($str)
-    {
-        $this->load->helper('auth/password');
+	/**
+	 * Checks the password strength and returns pass/fail.
+	 *
+	 * @param $str
+	 */
+	public function password_check($str)
+	{
+		$this->load->helper('auth/password');
 
-        $strength = isStrongPassword($str);
+		$strength = isStrongPassword($str);
 
-        $this->renderJSON(['status' => $strength ? 'pass' : 'fail']);
-    }
+		$this->renderJSON(['status' => $strength ? 'pass' : 'fail']);
+	}
 
-    //--------------------------------------------------------------------
+	//--------------------------------------------------------------------
 
 }

myth/CIModules/auth/controllers/Test.php

Indentation +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 	public function index($target_time = 50)
 	{
 		// Convert the milliseconds to seconds.
-	    $target_time = $target_time / 1000;
+		$target_time = $target_time / 1000;
 
 		CLI::write('Testing for password hash value with a target time of '. $target_time .' seconds...');
 

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
 		// Convert the milliseconds to seconds.
 	    $target_time = $target_time / 1000;
 
-		CLI::write('Testing for password hash value with a target time of '. $target_time .' seconds...');
+		CLI::write('Testing for password hash value with a target time of '.$target_time.' seconds...');
 
 		// Taken from the PHP manual
 		$cost = 8;
@@ -59,7 +59,7 @@ 
 			$end = microtime(true);
 		} while (($end - $start) < $target_time);
 
-		CLI::write("Hash value should be set to: ". CLI::color($cost, 'green'));
+		CLI::write("Hash value should be set to: ".CLI::color($cost, 'green'));
 	}
 	
 	//--------------------------------------------------------------------

myth/CIModules/auth/helpers/password_helper.php

Indentation +21 added lines, -21 removed lines

@@ -32,28 +32,28 @@
 
 if (! function_exists('isStrongPassword'))
 {
-    /**
-     * Works with Myth\Auth\Password to enforce a strong password.
-     * Uses settings from the auth config file.
-     *
-     * @param $password
-     */
-    function isStrongPassword($password)
-    {
-        $min_strength = config_item('auth.min_password_strength');
-        $use_dict = config_item('auth.use_dictionary');
+	/**
+	 * Works with Myth\Auth\Password to enforce a strong password.
+	 * Uses settings from the auth config file.
+	 *
+	 * @param $password
+	 */
+	function isStrongPassword($password)
+	{
+		$min_strength = config_item('auth.min_password_strength');
+		$use_dict = config_item('auth.use_dictionary');
 
-        $strong = \Myth\Auth\Password::isStrongPassword($password, $min_strength, $use_dict);
+		$strong = \Myth\Auth\Password::isStrongPassword($password, $min_strength, $use_dict);
 
-        if (! $strong)
-        {
-            if (isset(get_instance()->form_validation))
-            {
-                get_instance()->form_validation->set_message('isStrongPassword', lang('auth.pass_not_strong'));
-            }
-            return false;
-        }
+		if (! $strong)
+		{
+			if (isset(get_instance()->form_validation))
+			{
+				get_instance()->form_validation->set_message('isStrongPassword', lang('auth.pass_not_strong'));
+			}
+			return false;
+		}
 
-        return true;
-    }
+		return true;
+	}
 }

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
  * @since       Version 1.0
  */
 
-if (! function_exists('isStrongPassword'))
+if ( ! function_exists('isStrongPassword'))
 {
     /**
      * Works with Myth\Auth\Password to enforce a strong password.
@@ -45,7 +45,7 @@ 
 
         $strong = \Myth\Auth\Password::isStrongPassword($password, $min_strength, $use_dict);
 
-        if (! $strong)
+        if ( ! $strong)
         {
             if (isset(get_instance()->form_validation))
             {