CI_DB_pdo_oci_driver - Code Metrics - Inspection of "Merge pull request #142 from dev-ggallon/f/Update_..." - ci-bonfire/Sprint - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 7d455c...f6fa23 )

by Lonnie

created 2015-12-15 19:11 UTC

CI_DB_pdo_oci_driver A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	266
Duplicated Lines	36.09 %

Coupling/Cohesion

Components	4
Dependencies	1

Metric	Value
wmc	32
lcom	4
cbo	1
dl	96
loc	266
rs	9.6

8 Methods

Rating	Name	Duplication	Size	Complexity
D	__construct()	0	29	10
A	version()	0	15	3
A	_list_tables()	12	12	3
A	_list_columns()	15	15	2
C	field_data()	47	47	8
A	_insert_batch()	12	12	2
A	_delete()	10	10	2
A	_limit()	0	5	2

How to fix Duplicated Code

<?php
/**
 * CodeIgniter
 *
 * An open source application development framework for PHP
 *
 * This content is released under the MIT License (MIT)
 *
 * Copyright (c) 2014 - 2015, British Columbia Institute of Technology
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 * @package	CodeIgniter
 * @author	EllisLab Dev Team
 * @copyright	Copyright (c) 2008 - 2014, EllisLab, Inc. (http://ellislab.com/)
 * @copyright	Copyright (c) 2014 - 2015, British Columbia Institute of Technology (http://bcit.ca/)
 * @license	http://opensource.org/licenses/MIT	MIT License
 * @link	http://codeigniter.com
 * @since	Version 3.0.0
 * @filesource
 */
defined('BASEPATH') OR exit('No direct script access allowed');

/**
 * PDO Oracle Database Adapter Class
 *
 * Note: _DB is an extender class that the app controller
 * creates dynamically based on whether the query builder
 * class is being used or not.
 *
 * @package		CodeIgniter
 * @subpackage	Drivers
 * @category	Database
 * @author		EllisLab Dev Team
 * @link		http://codeigniter.com/user_guide/database/
 */
class CI_DB_pdo_oci_driver extends CI_DB_pdo_driver {

	/**
	 * Sub-driver
	 *
	 * @var	string
	 */
	public $subdriver = 'oci';

	// --------------------------------------------------------------------

	/**
	 * List of reserved identifiers
	 *
	 * Identifiers that must NOT be escaped.
	 *
	 * @var	string[]
	 */
	protected $_reserved_identifiers = array('*', 'rownum');

	/**
	 * ORDER BY random keyword
	 *
	 * @var	array
	 */
	protected $_random_keyword = array('ASC', 'ASC'); // Currently not supported

	/**
	 * COUNT string
	 *
	 * @used-by	CI_DB_driver::count_all()
	 * @used-by	CI_DB_query_builder::count_all_results()
	 *
	 * @var	string
	 */
	protected $_count_string = 'SELECT COUNT(1) AS ';

	// --------------------------------------------------------------------

	/**
	 * Class constructor
	 *
	 * Builds the DSN if not already set.
	 *
	 * @param	array	$params
	 * @return	void
	 */
	public function __construct($params)
	{
		parent::__construct($params);

		if (empty($this->dsn))
		{
			$this->dsn = 'oci:dbname=';

			// Oracle has a slightly different PDO DSN format (Easy Connect),
			// which also supports pre-defined DSNs.
			if (empty($this->hostname) && empty($this->port))
			{
				$this->dsn .= $this->database;
			}
			else
			{
				$this->dsn .= '//'.(empty($this->hostname) ? '127.0.0.1' : $this->hostname)
					.(empty($this->port) ? '' : ':'.$this->port).'/';

				empty($this->database) OR $this->dsn .= $this->database;
			}

			empty($this->char_set) OR $this->dsn .= ';charset='.$this->char_set;
		}
		elseif ( ! empty($this->char_set) && strpos($this->dsn, 'charset=', 4) === FALSE)
		{
			$this->dsn .= ';charset='.$this->char_set;
		}
	}

	// --------------------------------------------------------------------

	/**
	 * Database version number
	 *
	 * @return	string
	 */
	public function version()
	{
		if (isset($this->data_cache['version']))
		{
			return $this->data_cache['version'];
		}

		$version_string = parent::version();
		if (preg_match('#Release\s(?<version>\d+(?:\.\d+)+)#', $version_string, $match))
		{
			return $this->data_cache['version'] = $match[1];
		}

		return FALSE;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	}

	// --------------------------------------------------------------------

	/**
	 * Show table query
	 *
	 * Generates a platform-specific query string so that the table names can be fetched
	 *
	 * @param	bool	$prefix_limit
	 * @return	string
	 */
	protected function _list_tables($prefix_limit = FALSE)
	{
		$sql = 'SELECT "TABLE_NAME" FROM "ALL_TABLES"';

		if ($prefix_limit === TRUE && $this->dbprefix !== '')
		{
			return $sql.' WHERE "TABLE_NAME" LIKE \''.$this->escape_like_str($this->dbprefix)."%' "
				.sprintf($this->_like_escape_str, $this->_like_escape_chr);
		}

		return $sql;
	}

	// --------------------------------------------------------------------

	/**
	 * Show column query
	 *
	 * Generates a platform-specific query string so that the column names can be fetched
	 *
	 * @param	string	$table
	 * @return	string
	 */
	protected function _list_columns($table = '')
	{
		if (strpos($table, '.') !== FALSE)
		{
			sscanf($table, '%[^.].%s', $owner, $table);
		}
		else
		{
			$owner = $this->username;
		}

		return 'SELECT COLUMN_NAME FROM ALL_TAB_COLUMNS
			WHERE UPPER(OWNER) = '.$this->escape(strtoupper($owner)).'
				AND UPPER(TABLE_NAME) = '.$this->escape(strtoupper($table));
	}

	// --------------------------------------------------------------------

	/**
	 * Returns an object with field data
	 *
	 * @param	string	$table
	 * @return	array
	 */
	public function field_data($table)
	{
		if (strpos($table, '.') !== FALSE)
		{
			sscanf($table, '%[^.].%s', $owner, $table);
		}
		else
		{
			$owner = $this->username;
		}

		$sql = 'SELECT COLUMN_NAME, DATA_TYPE, CHAR_LENGTH, DATA_PRECISION, DATA_LENGTH, DATA_DEFAULT, NULLABLE
			FROM ALL_TAB_COLUMNS
			WHERE UPPER(OWNER) = '.$this->escape(strtoupper($owner)).'
				AND UPPER(TABLE_NAME) = '.$this->escape(strtoupper($table));

		if (($query = $this->query($sql)) === FALSE)
		{
			return FALSE;
		}
		$query = $query->result_object();

		$retval = array();
		for ($i = 0, $c = count($query); $i < $c; $i++)
		{
			$retval[$i]			= new stdClass();
			$retval[$i]->name		= $query[$i]->COLUMN_NAME;
			$retval[$i]->type		= $query[$i]->DATA_TYPE;

			$length = ($query[$i]->CHAR_LENGTH > 0)
				? $query[$i]->CHAR_LENGTH : $query[$i]->DATA_PRECISION;
			if ($length === NULL)
			{
				$length = $query[$i]->DATA_LENGTH;
			}
			$retval[$i]->max_length		= $length;

			$default = $query[$i]->DATA_DEFAULT;
			if ($default === NULL && $query[$i]->NULLABLE === 'N')
			{
				$default = '';
			}
			$retval[$i]->default		= $query[$i]->COLUMN_DEFAULT;
		}

		return $retval;
	}

	// --------------------------------------------------------------------

	/**
	 * Insert batch statement
	 *
	 * @param	string	$table	Table name
	 * @param	array	$keys	INSERT keys
	 * @param	array	$values	INSERT values
	 * @return 	string
	 */
	protected function _insert_batch($table, $keys, $values)
	{
		$keys = implode(', ', $keys);
		$sql = "INSERT ALL\n";

		for ($i = 0, $c = count($values); $i < $c; $i++)
		{
			$sql .= '	INTO '.$table.' ('.$keys.') VALUES '.$values[$i]."\n";
		}

		return $sql.'SELECT * FROM dual';
	}

	// --------------------------------------------------------------------

	/**
	 * Delete statement
	 *
	 * Generates a platform-specific delete string from the supplied data
	 *
	 * @param	string	$table
	 * @return	string
	 */
	protected function _delete($table)
	{
		if ($this->qb_limit)
		{
			$this->where('rownum <= ',$this->qb_limit, FALSE);
			$this->qb_limit = FALSE;
		}

		return parent::_delete($table);
	}

	// --------------------------------------------------------------------

	/**
	 * LIMIT
	 *
	 * Generates a platform-specific LIMIT clause
	 *
	 * @param	string	$sql	SQL Query
	 * @return	string
	 */
	protected function _limit($sql)
	{
		return 'SELECT * FROM (SELECT inner_query.*, rownum rnum FROM ('.$sql.') inner_query WHERE rownum < '.($this->qb_offset + $this->qb_limit + 1).')'
			.($this->qb_offset ? ' WHERE rnum >= '.($this->qb_offset + 1): '');
	}

}


1		<?php
2		/**
3		* CodeIgniter
4		*
5		* An open source application development framework for PHP
6		*
7		* This content is released under the MIT License (MIT)
8		*
9		* Copyright (c) 2014 - 2015, British Columbia Institute of Technology
10		*
11		* Permission is hereby granted, free of charge, to any person obtaining a copy
12		* of this software and associated documentation files (the "Software"), to deal
13		* in the Software without restriction, including without limitation the rights
14		* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
15		* copies of the Software, and to permit persons to whom the Software is
16		* furnished to do so, subject to the following conditions:
17		*
18		* The above copyright notice and this permission notice shall be included in
19		* all copies or substantial portions of the Software.
20		*
21		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
22		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
23		* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
24		* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
25		* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
26		* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
27		* THE SOFTWARE.
28		*
29		* @package CodeIgniter
30		* @author EllisLab Dev Team
31		* @copyright Copyright (c) 2008 - 2014, EllisLab, Inc. (http://ellislab.com/)
32		* @copyright Copyright (c) 2014 - 2015, British Columbia Institute of Technology (http://bcit.ca/)
33		* @license http://opensource.org/licenses/MIT MIT License
34		* @link http://codeigniter.com
35		* @since Version 3.0.0
36		* @filesource
37		*/
38		defined('BASEPATH') OR exit('No direct script access allowed');
39
40		/**
41		* PDO Oracle Database Adapter Class
42		*
43		* Note: _DB is an extender class that the app controller
44		* creates dynamically based on whether the query builder
45		* class is being used or not.
46		*
47		* @package CodeIgniter
48		* @subpackage Drivers
49		* @category Database
50		* @author EllisLab Dev Team
51		* @link http://codeigniter.com/user_guide/database/
52		*/
53		class CI_DB_pdo_oci_driver extends CI_DB_pdo_driver {
54
55		/**
56		* Sub-driver
57		*
58		* @var string
59		*/
60		public $subdriver = 'oci';
61
62		// --------------------------------------------------------------------
63
64		/**
65		* List of reserved identifiers
66		*
67		* Identifiers that must NOT be escaped.
68		*
69		* @var string[]
70		*/
71		protected $_reserved_identifiers = array('*', 'rownum');
72
73		/**
74		* ORDER BY random keyword
75		*
76		* @var array
77		*/
78		protected $_random_keyword = array('ASC', 'ASC'); // Currently not supported
79
80		/**
81		* COUNT string
82		*
83		* @used-by CI_DB_driver::count_all()
84		* @used-by CI_DB_query_builder::count_all_results()
85		*
86		* @var string
87		*/
88		protected $_count_string = 'SELECT COUNT(1) AS ';
89
90		// --------------------------------------------------------------------
91
92		/**
93		* Class constructor
94		*
95		* Builds the DSN if not already set.
96		*
97		* @param array $params
98		* @return void
99		*/
100		public function __construct($params)
101		{
102		parent::__construct($params);
103
104		if (empty($this->dsn))
105		{
106		$this->dsn = 'oci:dbname=';
107
108		// Oracle has a slightly different PDO DSN format (Easy Connect),
109		// which also supports pre-defined DSNs.
110		if (empty($this->hostname) && empty($this->port))
111		{
112		$this->dsn .= $this->database;
113		}
114		else
115		{
116		$this->dsn .= '//'.(empty($this->hostname) ? '127.0.0.1' : $this->hostname)
117		.(empty($this->port) ? '' : ':'.$this->port).'/';
118
119		empty($this->database) OR $this->dsn .= $this->database;
120		}
121
122		empty($this->char_set) OR $this->dsn .= ';charset='.$this->char_set;
123		}
124		elseif ( ! empty($this->char_set) && strpos($this->dsn, 'charset=', 4) === FALSE)
125		{
126		$this->dsn .= ';charset='.$this->char_set;
127		}
128		}
129
130		// --------------------------------------------------------------------
131
132		/**
133		* Database version number
134		*
135		* @return string
136		*/
137		public function version()
138		{
139		if (isset($this->data_cache['version']))
140		{
141		return $this->data_cache['version'];
142		}
143
144		$version_string = parent::version();
145		if (preg_match('#Release\s(?<version>\d+(?:\.\d+)+)#', $version_string, $match))
146		{
147		return $this->data_cache['version'] = $match[1];
148		}
149
150		return FALSE;
		0 ignored issues – show Bug Best Practice introduced 2015-12-15 18:41 UTC by Report Bug Copy Issue Report The return type of `return FALSE;` (`false`) is incompatible with the return type documented by `CI_DB_pdo_oci_driver::version` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
151		}
152
153		// --------------------------------------------------------------------
154
155		/**
156		* Show table query
157		*
158		* Generates a platform-specific query string so that the table names can be fetched
159		*
160		* @param bool $prefix_limit
161		* @return string
162		*/
163	View Code Duplication	protected function _list_tables($prefix_limit = FALSE)
164		{
165		$sql = 'SELECT "TABLE_NAME" FROM "ALL_TABLES"';
166
167		if ($prefix_limit === TRUE && $this->dbprefix !== '')
168		{
169		return $sql.' WHERE "TABLE_NAME" LIKE \''.$this->escape_like_str($this->dbprefix)."%' "
170		.sprintf($this->_like_escape_str, $this->_like_escape_chr);
171		}
172
173		return $sql;
174		}
175
176		// --------------------------------------------------------------------
177
178		/**
179		* Show column query
180		*
181		* Generates a platform-specific query string so that the column names can be fetched
182		*
183		* @param string $table
184		* @return string
185		*/
186	View Code Duplication	protected function _list_columns($table = '')
187		{
188		if (strpos($table, '.') !== FALSE)
189		{
190		sscanf($table, '%[^.].%s', $owner, $table);
191		}
192		else
193		{
194		$owner = $this->username;
195		}
196
197		return 'SELECT COLUMN_NAME FROM ALL_TAB_COLUMNS
198		WHERE UPPER(OWNER) = '.$this->escape(strtoupper($owner)).'
199		AND UPPER(TABLE_NAME) = '.$this->escape(strtoupper($table));
200		}
201
202		// --------------------------------------------------------------------
203
204		/**
205		* Returns an object with field data
206		*
207		* @param string $table
208		* @return array
209		*/
210	View Code Duplication	public function field_data($table)
211		{
212		if (strpos($table, '.') !== FALSE)
213		{
214		sscanf($table, '%[^.].%s', $owner, $table);
215		}
216		else
217		{
218		$owner = $this->username;
219		}
220
221		$sql = 'SELECT COLUMN_NAME, DATA_TYPE, CHAR_LENGTH, DATA_PRECISION, DATA_LENGTH, DATA_DEFAULT, NULLABLE
222		FROM ALL_TAB_COLUMNS
223		WHERE UPPER(OWNER) = '.$this->escape(strtoupper($owner)).'
224		AND UPPER(TABLE_NAME) = '.$this->escape(strtoupper($table));
225
226		if (($query = $this->query($sql)) === FALSE)
227		{
228		return FALSE;
229		}
230		$query = $query->result_object();
231
232		$retval = array();
233		for ($i = 0, $c = count($query); $i < $c; $i++)
234		{
235		$retval[$i] = new stdClass();
236		$retval[$i]->name = $query[$i]->COLUMN_NAME;
237		$retval[$i]->type = $query[$i]->DATA_TYPE;
238
239		$length = ($query[$i]->CHAR_LENGTH > 0)
240		? $query[$i]->CHAR_LENGTH : $query[$i]->DATA_PRECISION;
241		if ($length === NULL)
242		{
243		$length = $query[$i]->DATA_LENGTH;
244		}
245		$retval[$i]->max_length = $length;
246
247		$default = $query[$i]->DATA_DEFAULT;
248		if ($default === NULL && $query[$i]->NULLABLE === 'N')
249		{
250		$default = '';
251		}
252		$retval[$i]->default = $query[$i]->COLUMN_DEFAULT;
253		}
254
255		return $retval;
256		}
257
258		// --------------------------------------------------------------------
259
260		/**
261		* Insert batch statement
262		*
263		* @param string $table Table name
264		* @param array $keys INSERT keys
265		* @param array $values INSERT values
266		* @return string
267		*/
268	View Code Duplication	protected function _insert_batch($table, $keys, $values)
269		{
270		$keys = implode(', ', $keys);
271		$sql = "INSERT ALL\n";
272
273		for ($i = 0, $c = count($values); $i < $c; $i++)
274		{
275		$sql .= ' INTO '.$table.' ('.$keys.') VALUES '.$values[$i]."\n";
276		}
277
278		return $sql.'SELECT * FROM dual';
279		}
280
281		// --------------------------------------------------------------------
282
283		/**
284		* Delete statement
285		*
286		* Generates a platform-specific delete string from the supplied data
287		*
288		* @param string $table
289		* @return string
290		*/
291	View Code Duplication	protected function _delete($table)
292		{
293		if ($this->qb_limit)
294		{
295		$this->where('rownum <= ',$this->qb_limit, FALSE);
296		$this->qb_limit = FALSE;
297		}
298
299		return parent::_delete($table);
300		}
301
302		// --------------------------------------------------------------------
303
304		/**
305		* LIMIT
306		*
307		* Generates a platform-specific LIMIT clause
308		*
309		* @param string $sql SQL Query
310		* @return string
311		*/
312		protected function _limit($sql)
313		{
314		return 'SELECT * FROM (SELECT inner_query.*, rownum rnum FROM ('.$sql.') inner_query WHERE rownum < '.($this->qb_offset + $this->qb_limit + 1).')'
315		.($this->qb_offset ? ' WHERE rnum >= '.($this->qb_offset + 1): '');
316		}
317
318		}
319

ci-bonfire / Sprint

GitHub Access Token became invalid

Push — develop ( 7d455c...f6fa23 )

CI_DB_pdo_oci_driver A

Complexity

Size/Duplication

Coupling/Cohesion

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like