Chuckcms\Contacts\ContactsServiceProvider

Complexity

Total Complexity

6

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	registerModelBindings()	0	5	1
A	getMigrationFileName()	0	12	1
A	doPublishing()	0	14	2
A	boot()	0	5	1
A	register()	0	5	1

<?php

namespace Chuckcms\Contacts;

use Chuckcms\Contacts\Contracts\Contact as ContactContract;
use Illuminate\Filesystem\Filesystem;
use Illuminate\Support\Collection;
use Illuminate\Support\ServiceProvider;

class ContactsServiceProvider extends ServiceProvider
{
    public function boot()
    {
        $this->doPublishing();

        $this->registerModelBindings();
    }

    public function register()
    {
        $this->mergeConfigFrom(
            __DIR__.'/../config/contacts.php',
            'contacts'
        );
    }

    public function doPublishing()
    {
        if (!function_exists('config_path')) {
            // function not available and 'publish' not relevant in Lumen (credit: Spatie)
            return;
        }

        $this->publishes([
            __DIR__.'/../config/contacts.php' => config_path('contacts.php'),
        ], 'config');

        $this->publishes([
            __DIR__.'/../database/migrations/create_contacts_tables.php.stub' => $this->getMigrationFileName('create_contacts_tables.php'),
        ], 'migrations');
    }

    public function registerModelBindings()
    {
        $config = $this->app->config['contacts.models'];

Accessing config on the interface Illuminate\Contracts\Foundation\Application suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->app->bind(ContactContract::class, $config['contact']);
    }

    /**
     * Returns existing migration file if found, else uses the current timestamp.
     *
     * @return string
     */
    public function getMigrationFileName($migrationFileName): string
    {
        $timestamp = date('Y_m_d_His');

        $filesystem = $this->app->make(Filesystem::class);

        return Collection::make($this->app->databasePath().DIRECTORY_SEPARATOR.'migrations'.DIRECTORY_SEPARATOR)

$this->app->databasePath() . Chuckcms\Contacts\DIRECTORY_SEPARATOR . 'migrations' . Chuckcms\Contacts\DIRECTORY_SEPARATOR of type string is incompatible with the type Illuminate\Contracts\Support\Arrayable expected by parameter $items of Illuminate\Support\Collection::make().

            ->flatMap(function ($path) use ($filesystem, $migrationFileName) {
                return $filesystem->glob($path.'*_'.$migrationFileName);
            })
            ->push($this->app->databasePath()."/migrations/{$timestamp}_{$migrationFileName}")

$this->app->databasePath() . '/migrations/'.$timestamp.'_'.$migrationFileName of type string is incompatible with the type Illuminate\Support\TValue expected by parameter $values of Illuminate\Support\Collection::push().

            ->first();
    }
}