chuckbe / chuckcms

src/Controllers/UserRoleController.php

<?php

namespace Chuckbe\Chuckcms\Controllers;

use Chuckbe\Chuckcms\Chuck\UserRepository;
use Chuckbe\Chuckcms\Models\User;
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller as BaseController;
use Spatie\Permission\Models\Permission;
use Spatie\Permission\Models\Role;

class UserRoleController extends BaseController
{
    use AuthorizesRequests;
    use DispatchesJobs;
    use ValidatesRequests;

    private $user;
    private $userRepository;

    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct(User $user, UserRepository $userRepository)
    {
        $this->user = $user;
        $this->userRepository = $userRepository;
    }

    /**
     * Show the dashboard -> roles.
     *
     * @return \Illuminate\View\View
     */
    public function index()
    {
        $roles = Role::all();

        return view('chuckcms::backend.users.roles.index', compact('roles'));
    }

    public function create(Request $request)
    {
        $this->validate(request(), [//@todo create custom Request class for page validation
            'role_name'     => 'max:185|required',
            'role_redirect' => 'max:255|required',
        ]);

        $role = Role::firstOrCreate(['name' => $request->role_name], ['redirect' => $request->role_redirect]);

        return redirect()->route('dashboard.users.roles.edit', ['role' => $role->id])->with('notification', 'Rol aangemaakt!');
    }

    /**
     * Show the edit user page.
     *
     * @return \Illuminate\View\View
     */
    public function edit(Role $role)
    {
        $permissions = Permission::all();

        return view('chuckcms::backend.users.roles.edit', compact('role', 'permissions'));
    }

    public function save(Request $request)
    {
        $this->validate(request(), [//@todo create custom Request class for page validation
            'role_name'            => 'max:185|required',
            'role_redirect'        => 'max:255|required',
            'role_id'              => 'required',
            'permissions_name.*'   => 'required',
            'permissions_active.*' => 'required',
        ]);

        $role = Role::findById($request->role_id);
        $role->name = $request->role_name;

The property name does not seem to exist on Spatie\Permission\Models\Role. Are you sure there is no database migration missing?

        $role->redirect = $request->role_redirect;
        $role->save();

        $permissions = [];

The assignment to $permissions is dead and can be removed.

        $countPermissions = count($request->permissions_name);
        for ($i = 0; $i < $countPermissions; $i++) {
            if ($request->permissions_active[$i] == 1) {
                $role->givePermissionTo($request->permissions_name[$i]);
            } else {
                $role->revokePermissionTo($request->permissions_name[$i]);
            }
        }

        //redirect back
        return redirect()->route('dashboard.users.roles')->with('notification', 'Rol gewijzigd!');
    }

    /**
     * Delete the role.
     *
     * @return string $status
     */
    public function delete(Request $request)
    {
        $this->validate(request(), [
            'role_id' => 'required',
        ]);

        $role = Role::findById($request->get('role_id'));

It seems like $request->get('role_id') can also be of type null; however, parameter $id of Spatie\Permission\Models\Role::findById() does only seem to accept integer, maybe add an additional type check?

        if ($role->delete()) {
            return redirect()->route('dashboard.users.roles')->with('notification', 'Rol verwijderd!');
        } else {
            return redirect()->route('dashboard.users.roles')->with('whoops', 'Er is iets misgegaan, probeer het later nog eens!');
        }
    }
}