Chuckbe\Chuckcms\Models\Template

Complexity

Total Complexity

24

Size/Duplication

Total Lines	113
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	getPageViews()	0	29	10
A	pages()	0	2	1
A	updateFromRequest()	0	29	3
B	getEmailTemplates()	0	29	10

<?php

namespace Chuckbe\Chuckcms\Models;

use Eloquent;
use Illuminate\Http\Request;

class Template extends Eloquent
{
    public function pages(){
        return $this->hasMany('Chuckbe\Chuckcms\Models\Page');
    }

    protected $casts = [
        'fonts' => 'array',
        'css' => 'array',
        'js' => 'array',
        'json' => 'array'
    ];

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name', 'slug', 'hintpath', 'path', 'type', 'version', 'author', 'active', 'fonts', 'css', 'js', 'json'
    ];

    public function getEmailTemplates()
    {
        $templates = $this->where('active', 1)->where('type', 'default')->get();
        $emailTemplates = [];
        foreach ($templates as $template) {
            if (file_exists(base_path('vendor/' . $template->path . '/src/views/templates/' . $template->slug . '/mails'))) {
                $mailDir = array_slice(scandir(base_path('vendor/' . $template->path . '/src/views/templates/' . $template->slug . '/mails')), 2);

It seems like scandir(base_path('vendor/' . $template->path . '/src/views/templates/' . $template->slug . '/mails')) can also be of type false; however, parameter $array of array_slice() does only seem to accept array, maybe add an additional type check?

                if (count($mailDir) > 0) {
                    $emailTemplates[$template->slug]['hintpath'] = $template->hintpath;
                    foreach ($mailDir as $mdKey => $mdValue) {
                        if (strpos($mdValue, '.blade.php')) {
                            $emailTemplates[$template->slug]['files'][] = str_replace('.blade.php', '', $mdValue);
                        }    
                    }
                }
            }
            if (file_exists(base_path('resources/views/vendor/' . $template->slug . '/templates/' . $template->slug . '/mails'))) {
                $mailDirVendor = array_slice(scandir(base_path('resources/views/vendor/' . $template->slug . '/templates/' . $template->slug . '/mails')), 2);
                if (count($mailDirVendor) > 0) {
                    $emailTemplates[$template->slug]['hintpath'] = $template->hintpath;
                    foreach ($mailDirVendor as $mdKey => $mdValue) {
                        if (strpos($mdValue, '.blade.php')) {
                            $emailTemplates[$template->slug]['files'][] = str_replace('.blade.php', '', $mdValue);
                        }    
                    }
                }
            }
        }
        return $emailTemplates;
    }

    public function getPageViews()
    {
        $templates = $this->where('active', 1)->where('type', 'default')->get();
        $pageViews = [];
        foreach ($templates as $template) {
            if (file_exists(base_path('vendor/' . $template->path . '/src/views/templates/' . $template->slug))) {
                $pageDir = array_slice(scandir(base_path('vendor/' . $template->path . '/src/views/templates/' . $template->slug)), 2);

It seems like scandir(base_path('vendor/' . $template->path . '/src/views/templates/' . $template->slug)) can also be of type false; however, parameter $array of array_slice() does only seem to accept array, maybe add an additional type check?

                if (count($pageDir) > 0) {
                    $pageViews[$template->slug]['hintpath'] = $template->hintpath;
                    foreach ($pageDir as $pdKey => $pdValue) {
                        if (strpos($pdValue, '.blade.php')) {
                            $pageViews[$template->slug]['files'][] = str_replace('.blade.php', '', $pdValue);
                        }    
                    }
                }
            }
            if (file_exists(base_path('resources/views/vendor/' . $template->slug . '/templates/' . $template->slug))) {
                $pageDir = array_slice(scandir(base_path('resources/views/vendor/' . $template->slug . '/templates/' . $template->slug)), 2);
                if (count($pageDir) > 0) {
                    $pageViews[$template->slug]['hintpath'] = $template->hintpath;
                    foreach ($pageDir as $pdKey => $pdValue) {
                        if (strpos($pdValue, '.blade.php')) {
                            $pageViews[$template->slug]['files'][] = str_replace('.blade.php', '', $pdValue);
                        }    
                    }
                }
            }
        }
        return $pageViews;
    }

    public function updateFromRequest(Request $request)
    {
        $template = $this->where('id', $request->template_id)->first();

        $template->name = $request->template_name;

        $fonts = [];
        $fonts['raw'] = $request->template_fonts;
        $template->fonts = $fonts;

        $css = [];

        for ($i=0; $i < count($request->css_slug); $i++) { 

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $css[$request->css_slug[$i]]['href'] = $request->css_href[$i];
            $css[$request->css_slug[$i]]['asset'] = $request->css_asset[$i];
        }

        $template->css = $css;

        $js = [];

        for ($k=0; $k < count($request->js_slug); $k++) { 

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $js[$request->js_slug[$k]]['href'] = $request->js_href[$k];
            $js[$request->js_slug[$k]]['asset'] = $request->js_asset[$k];
        }

        $template->js = $js;

        $template->update();
    }
}