| Conditions | 8 |
| Paths | 24 |
| Total Lines | 55 |
| Code Lines | 41 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 95 | public function save(Request $request) |
||
| 96 | { |
||
| 97 | $form = []; |
||
| 98 | $form_slug = $request->get('form_slug'); |
||
| 99 | $fields_slug = $request->get('fields_slug'); |
||
| 100 | $countFS = count($fields_slug); |
||
| 101 | for ($i = 0; $i < $countFS; $i++) { |
||
| 102 | $form['fields'][$form_slug.'_'.$fields_slug[$i]]['label'] = $request->get('fields_label')[$i]; |
||
| 103 | $form['fields'][$form_slug.'_'.$fields_slug[$i]]['type'] = $request->get('fields_type')[$i]; |
||
| 104 | $form['fields'][$form_slug.'_'.$fields_slug[$i]]['class'] = $request->get('fields_class')[$i]; |
||
| 105 | $form['fields'][$form_slug.'_'.$fields_slug[$i]]['parentclass'] = $request->get('fields_parentclass')[$i]; |
||
| 106 | $form['fields'][$form_slug.'_'.$fields_slug[$i]]['placeholder'] = $request->get('fields_placeholder')[$i]; |
||
| 107 | $form['fields'][$form_slug.'_'.$fields_slug[$i]]['validation'] = $request->get('fields_validation')[$i]; |
||
| 108 | $form['fields'][$form_slug.'_'.$fields_slug[$i]]['value'] = $request->get('fields_value')[$i]; |
||
| 109 | $countFAN = count(explode(';', $request->get('fields_attributes_name')[$i])); |
||
| 110 | for ($k = 0; $k < $countFAN; $k++) { |
||
| 111 | $form['fields'][$form_slug.'_'.$fields_slug[$i]]['attributes'][explode(';', $request->get('fields_attributes_name')[$i])[$k]] = explode(';', $request->get('fields_attributes_value')[$i])[$k]; |
||
| 112 | } |
||
| 113 | $form['fields'][$form_slug.'_'.$fields_slug[$i]]['required'] = $request->get('fields_required')[$i]; |
||
| 114 | } |
||
| 115 | |||
| 116 | $form['actions']['store'] = $request->get('action_store') == 'true' ? true : false; |
||
| 117 | |||
| 118 | if ($request->get('action_send') !== 'false' && $request->get('action_send') !== false) { |
||
| 119 | $countActions = count($request->get('action_send_slug')); |
||
| 120 | for ($g = 0; $g < $countActions; $g++) { |
||
| 121 | $form['actions']['send'][$request->get('action_send_slug')[$g]]['to'] = $request->get('action_send_to')[$g]; |
||
| 122 | $form['actions']['send'][$request->get('action_send_slug')[$g]]['to_name'] = $request->get('action_send_to_name')[$g]; |
||
| 123 | $form['actions']['send'][$request->get('action_send_slug')[$g]]['from'] = $request->get('action_send_from')[$g]; |
||
| 124 | $form['actions']['send'][$request->get('action_send_slug')[$g]]['from_name'] = $request->get('action_send_from_name')[$g]; |
||
| 125 | $form['actions']['send'][$request->get('action_send_slug')[$g]]['subject'] = $request->get('action_send_subject')[$g]; |
||
| 126 | $form['actions']['send'][$request->get('action_send_slug')[$g]]['body'] = $request->get('action_send_body')[$g]; |
||
| 127 | $form['actions']['send'][$request->get('action_send_slug')[$g]]['files'] = $request->get('action_send_files')[$g]; |
||
| 128 | $form['actions']['send'][$request->get('action_send_slug')[$g]]['template'] = $request->get('action_send_template')[$g]; |
||
| 129 | } |
||
| 130 | } else { |
||
| 131 | $form['actions']['send'] = false; |
||
| 132 | } |
||
| 133 | $form['actions']['redirect'] = $request->get('action_redirect'); |
||
| 134 | |||
| 135 | $form['files'] = $request->get('files_allowed') == 'true' ? true : false; |
||
| 136 | |||
| 137 | $form['button']['class'] = $request->get('button_class'); |
||
| 138 | $form['button']['label'] = $request->get('button_label'); |
||
| 139 | $form['button']['id'] = $request->get('button_id'); |
||
| 140 | |||
| 141 | // updateOrCreate the site |
||
| 142 | Form::updateOrCreate( |
||
| 143 | ['id' => $request->get('form_id')], |
||
| 144 | ['title' => $request->get('form_title'), |
||
| 145 | 'slug' => $request->get('form_slug'), |
||
| 146 | 'form' => $form, ] |
||
| 147 | ); |
||
| 148 | |||
| 149 | return redirect()->route('dashboard.forms'); |
||
| 150 | } |
||
| 224 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths