Chuckbe\Chuckcms\Controllers\RedirectController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	delete()	0	8	2
A	create()	0	18	2
A	index()	0	5	1
A	update()	0	18	1

<?php

namespace Chuckbe\Chuckcms\Controllers;

use Chuckbe\Chuckcms\Models\Redirect;
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller as BaseController;

class RedirectController extends BaseController
{
    use AuthorizesRequests;
    use DispatchesJobs;
    use ValidatesRequests;

    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct(Redirect $redirect)
    {
        $this->redirect = $redirect;

The property redirect does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Show the dashboard -> menus index.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $redirects = $this->redirect->get();

        return view('chuckcms::backend.redirects.index', compact('redirects'));

The expression return view('chuckcms::backend.redirects.index', compact('redirects')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    public function create(Request $request)
    {
        //$request['slug'] = str_slug($request->slug, '-');

        $this->validate($request, [//@todo create custom Request class for redirect validation
            'slug' => 'max:185|required|unique:redirects',
            'to'   => 'required|max:185',
            'type' => 'required|numeric|in:301,302',
        ]);

        $redirect = Redirect::firstOrNew(
            ['slug' => $request['slug']],
            ['to'      => $request['to'],
                'type' => $request['type'], ]
        );

        if ($redirect->save()) {
            return redirect()->route('dashboard.redirects');
        }
    }

    public function update(Request $request)
    {
        //$request['slug'] = str_slug($request->slug, '-');

        $this->validate($request, [//@todo create custom Request class for redirect validation
            'id'   => 'required',
            'slug' => 'required|max:185',
            'to'   => 'required|max:185',
            'type' => 'required|numeric|in:301,302',
        ]);

        $redirect = Redirect::where('id', $request['id'])->update([

The assignment to $redirect is dead and can be removed.

            'slug' => $request['slug'],
            'to'   => $request['to'],
            'type' => $request['type'],
        ]);

        return redirect()->route('dashboard.redirects');
    }

    public function delete(Request $request)
    {
        $this->validate($request, ['id' => 'required']);

        $redirect = Redirect::where('id', $request['id'])->first();

        if ($redirect->delete()) {
            return redirect()->route('dashboard.redirects');
        }
    }
}