Chubbyphp\Serialization\Link\Link

Complexity

Total Complexity

3

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	jsonSerialize()	0	13	2

<?php

declare(strict_types=1);

namespace Chubbyphp\Serialization\Link;

final class Link implements LinkInterface
{
    /**
     * @var string
     */
    private $href;

    /**
     * @var string
     */
    private $method;

    /**
     * @var array
     */
    private $attributes;

    /**
     * @param string     $href
     * @param string     $method
     * @param array|null $attributes
     */
    public function __construct($href, $method, array $attributes = null)
    {
        $this->href = $href;
        $this->method = $method;
        $this->attributes = $attributes;

It seems like $attributes can be null. However, the property $attributes is declared as array. Maybe change the type of the property to array|null or add a type check?

    }

    /**
     * @return array
     */
    public function jsonSerialize(): array
    {
        $data = [
            'href' => $this->href,
            'method' => $this->method,
        ];

        if (null !== $this->attributes) {
            $data['attributes'] = $this->attributes;
        }

        return $data;
    }
}