CollectionFieldSerializer::serializeField() - Code Metrics - Inspection of "fix class name and tests" - chubbyphp/chubbyphp-serialization - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 341743...0998b7 )

by Dominik

created 2017-08-06 19:04 UTC

CollectionFieldSerializer::serializeField() A

↳ Parent: CollectionFieldSerializer

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	7
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	4
crap	6

<?php

declare(strict_types=1);

namespace Chubbyphp\Serialization\Serializer\Field;

use Chubbyphp\Serialization\Accessor\AccessorInterface;
use Chubbyphp\Serialization\SerializerInterface;
use Psr\Http\Message\ServerRequestInterface as Request;

final class CollectionFieldSerializer implements FieldSerializerInterface
{
    /**
     * @var AccessorInterface
     */
    private $accessor;

    /**
     * @param AccessorInterface $accessor
     */
    public function __construct(AccessorInterface $accessor)
    {
        $this->accessor = $accessor;
    }

    /**
     * @param string                   $path
     * @param Request                  $request
     * @param object                   $object
     * @param SerializerInterface|null $serializer
     *
     * @return mixed
     */
    public function serializeField(string $path, Request $request, $object, SerializerInterface $serializer = null)
    {
        $this->serializerOrException($serializer);

        $collection = [];
        foreach ($this->accessor->getValue($object) as $i => $childObject) {
            $subPath = $path.'.['.$i.']';
            $collection[$i] = $serializer->serialize($request, $childObject, $subPath);
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
        }

        return $collection;
    }

    /**
     * @param SerializerInterface|null $serializer
     *
     * @throws \RuntimeException
     */
    private function serializerOrException(SerializerInterface $serializer = null)
    {
        if (null === $serializer) {
            throw new \RuntimeException(sprintf('Serializer needed: %s', SerializerInterface::class));
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Chubbyphp\Serialization\Serializer\Field;
6
7			use Chubbyphp\Serialization\Accessor\AccessorInterface;
8			use Chubbyphp\Serialization\SerializerInterface;
9			use Psr\Http\Message\ServerRequestInterface as Request;
10
11			final class CollectionFieldSerializer implements FieldSerializerInterface
12			{
13			/**
14			* @var AccessorInterface
15			*/
16			private $accessor;
17
18			/**
19			* @param AccessorInterface $accessor
20			*/
21			public function __construct(AccessorInterface $accessor)
22			{
23			$this->accessor = $accessor;
24			}
25
26			/**
27			* @param string $path
28			* @param Request $request
29			* @param object $object
30			* @param SerializerInterface\|null $serializer
31			*
32			* @return mixed
33			*/
34			public function serializeField(string $path, Request $request, $object, SerializerInterface $serializer = null)
35			{
36			$this->serializerOrException($serializer);
37
38			$collection = [];
39			foreach ($this->accessor->getValue($object) as $i => $childObject) {
40			$subPath = $path.'.['.$i.']';
41			$collection[$i] = $serializer->serialize($request, $childObject, $subPath);
			0 ignored issues – show Bug introduced 2017-08-01 08:36 UTC by Report Bug Copy Issue Report It seems like `$serializer` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
42			}
43
44			return $collection;
45			}
46
47			/**
48			* @param SerializerInterface\|null $serializer
49			*
50			* @throws \RuntimeException
51			*/
52			private function serializerOrException(SerializerInterface $serializer = null)
53			{
54			if (null === $serializer) {
55			throw new \RuntimeException(sprintf('Serializer needed: %s', SerializerInterface::class));
56			}
57			}
58			}
59

chubbyphp / chubbyphp-serialization

Push — master ( 341743...0998b7 )

CollectionFieldSerializer::serializeField() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like