Chubbyphp\Model\Collection\ModelCollection

Complexity

Total Complexity

16

Size/Duplication

Total Lines	125
Duplicated Lines	20.8 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	modelsWithIdKey()	15	15	3
A	current()	0	4	1
A	next()	0	4	1
A	key()	0	4	1
A	valid()	0	4	1
A	rewind()	0	4	1
A	set()	0	4	1
A	toPersist()	0	4	1
A	toRemove()	11	11	3
A	jsonSerialize()	0	9	2

<?php

namespace Chubbyphp\Model\Collection;

use Chubbyphp\Model\ModelInterface;

class ModelCollection implements ModelCollectionInterface
{
    /**
     * @var ModelInterface[]|array
     */
    private $initialModels;

    /**
     * @var ModelInterface[]|array
     */
    private $models;

    /**
     * @param ModelInterface[]|array $models
     */
    public function __construct(array $models = [])
    {
        $models = $this->modelsWithIdKey($models);

        $this->initialModels = $models;
        $this->models = $models;
    }

    /**
     * @param ModelInterface[]|array $models
     *
     * @return ModelInterface[]|array
     */
    private function modelsWithIdKey(array $models): array

This method seems to be duplicated in your project.

    {
        $modelsWithIdKey = [];
        foreach ($models as $model) {
            if (!$model instanceof ModelInterface) {
                throw new \InvalidArgumentException(
                    sprintf('Model with index %d needs to implement: %s', ModelInterface::class)
                );
            }

            $modelsWithIdKey[$model->getId()] = $model;
        }

        return $modelsWithIdKey;
    }

    /**
     * @return ModelInterface
     */
    public function current()
    {
        return current($this->models);
    }

    /**
     * @return ModelInterface|false
     */
    public function next()
    {
        return next($this->models);
    }

    /**
     * @return string
     */
    public function key()
    {
        return key($this->models);
    }

    /**
     * @return bool
     */
    public function valid()
    {
        return (bool) current($this->models);
    }

    public function rewind()
    {
        reset($this->models);
    }

    /**
     * @param ModelInterface[]|array $models
     */
    public function set(array $models)
    {
        $this->models = $this->modelsWithIdKey($models);
    }

    /**
     * @return ModelInterface[]|array
     */
    public function toPersist(): array
    {
        return $this->models;
    }

    /**
     * @return ModelInterface[]|array
     */
    public function toRemove(): array

This method seems to be duplicated in your project.

    {
        $toRemoveModels = [];
        foreach ($this->initialModels as $initialModel) {
            if (!isset($this->models[$initialModel->getId()])) {
                $toRemoveModels[$initialModel->getId()] = $initialModel;
            }
        }

        return $toRemoveModels;
    }

    /**
     * @return array
     */
    public function jsonSerialize(): array
    {
        $serializedModels = [];
        foreach ($this->models as $model) {
            $serializedModels[] = $model->jsonSerialize();
        }

        return $serializedModels;
    }
}