LazyModelCollection - Code Metrics - Inspection of "make the exception final" - chubbyphp/chubbyphp-model - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c59a9c...50173f )

by Dominik

created 2016-11-24 20:04 UTC

LazyModelCollection A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	105
Duplicated Lines	14.29 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	11
lcom	1
cbo	1
dl	15
loc	105
rs	10
c	0
b	0
f	0

How to fix Duplicated Code

<?php

declare(strict_types=1);

namespace Chubbyphp\Model\Collection;

use Chubbyphp\Model\ModelInterface;

final class LazyModelCollection implements ModelCollectionInterface
{
    /**
     * @var \Closure;
     */
    private $resolver;

    /**
     * @var ModelInterface[]|array
     */
    private $initialModels;

    /**
     * @var ModelInterface[]|array
     */
    private $models;

    /**
     * @param \Closure $resolver
     */
    public function __construct(\Closure $resolver)
    {
        $this->resolver = $resolver;
    }

    private function resolveModels()
    {
        if (null === $this->resolver) {
            return;
        }

        $resolver = $this->resolver;

        $this->resolver = null;

        $this->setModels($resolver());
        $this->initialModels = $this->models;
    }

    /**
     * @param ModelInterface $model
     * @return ModelCollectionInterface
     */
    public function addModel(ModelInterface $model): ModelCollectionInterface
    {
        $this->resolveModels();

        $this->models[$model->getId()] = $model;

        return $this;
    }

    /**
     * @param ModelInterface $model
     * @return ModelCollectionInterface
     */
    public function removeModel(ModelInterface $model): ModelCollectionInterface
    {
        $this->resolveModels();

        if (isset($this->models[$model->getId()])) {
            unset($this->models[$model->getId());

        }

        return $this;
    }

    /**
     * @param ModelInterface[]|array $models
     * @return ModelCollectionInterface
     */
    public function setModels(array $models): ModelCollectionInterface
    {
        $this->resolveModels();

        $this->models = [];
        foreach ($models as $model) {
            $this->addModel($model);
        }

        return $this;
    }

    /**
     * @return ModelInterface[]|array
     */
    public function getModels(): array
    {
        $this->resolveModels();

        return $this->models;
    }

    /**
     * @return ModelInterface[]|array
     */
    public function getInitialModels(): array
    {
        $this->resolveModels();

        return $this->initialModels;
    }

    /**
     * @return array
     */
    public function jsonSerialize(): array
    {
        $this->resolveModels();

        $serializedModels = [];
        foreach ($this->models as $model) {
            $serializedModels[] = $model->jsonSerialize();
        }

        return $serializedModels;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Chubbyphp\Model\Collection;
6
7			use Chubbyphp\Model\ModelInterface;
8
9			final class LazyModelCollection implements ModelCollectionInterface
10			{
11			/**
12			* @var \Closure;
13			*/
14			private $resolver;
15
16			/**
17			* @var ModelInterface[]\|array
18			*/
19			private $initialModels;
20
21			/**
22			* @var ModelInterface[]\|array
23			*/
24			private $models;
25
26			/**
27			* @param \Closure $resolver
28			*/
29			public function __construct(\Closure $resolver)
30			{
31			$this->resolver = $resolver;
32			}
33
34			private function resolveModels()
35			{
36			if (null === $this->resolver) {
37			return;
38			}
39
40			$resolver = $this->resolver;
41
42			$this->resolver = null;
43
44			$this->setModels($resolver());
45			$this->initialModels = $this->models;
46			}
47
48			/**
49			* @param ModelInterface $model
50			* @return ModelCollectionInterface
51			*/
52			public function addModel(ModelInterface $model): ModelCollectionInterface
53			{
54			$this->resolveModels();
55
56			$this->models[$model->getId()] = $model;
57
58			return $this;
59			}
60
61			/**
62			* @param ModelInterface $model
63			* @return ModelCollectionInterface
64			*/
65			public function removeModel(ModelInterface $model): ModelCollectionInterface
66			{
67			$this->resolveModels();
68
69			if (isset($this->models[$model->getId()])) {
70			unset($this->models[$model->getId());
			0 ignored issues – show Bug introduced 2016-11-24 20:06 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected ')', expecting ']' Loading history...
71			}
72
73			return $this;
74			}
75
76			/**
77			* @param ModelInterface[]\|array $models
78			* @return ModelCollectionInterface
79			*/
80			public function setModels(array $models): ModelCollectionInterface
81			{
82			$this->resolveModels();
83
84			$this->models = [];
85			foreach ($models as $model) {
86			$this->addModel($model);
87			}
88
89			return $this;
90			}
91
92			/**
93			* @return ModelInterface[]\|array
94			*/
95			public function getModels(): array
96			{
97			$this->resolveModels();
98
99			return $this->models;
100			}
101
102			/**
103			* @return ModelInterface[]\|array
104			*/
105			public function getInitialModels(): array
106			{
107			$this->resolveModels();
108
109			return $this->initialModels;
110			}
111
112			/**
113			* @return array
114			*/
115			public function jsonSerialize(): array
116			{
117			$this->resolveModels();
118
119			$serializedModels = [];
120			foreach ($this->models as $model) {
121			$serializedModels[] = $model->jsonSerialize();
122			}
123
124			return $serializedModels;
125			}
126			}
127

chubbyphp / chubbyphp-model

Push — master ( c59a9c...50173f )

LazyModelCollection A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like