ModelReference::jsonSerialize() - Code Metrics - Inspection of "\JsonSerializable is not required anymore on model" - chubbyphp/chubbyphp-model - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 74b41a...e78beb )

by Dominik

created 2017-04-27 11:59 UTC

ModelReference::jsonSerialize() A

↳ Parent: ModelReference

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0
crap	2

<?php

declare(strict_types=1);

namespace Chubbyphp\Model\Reference;

use Chubbyphp\Model\ModelInterface;

final class ModelReference implements ModelReferenceInterface
{
    /**
     * @var string|null
     */
    private $id;

    /**
     * @var ModelInterface|null
     */
    private $model;

    /**
     * @param ModelInterface|null $model
     * @return ModelReferenceInterface
     */
    public function setModel(ModelInterface $model = null): ModelReferenceInterface

    {
        $this->model = $model;
        $this->id = null !== $model ? $model->getId() : null;

        return $this;
    }

    /**
     * @return ModelInterface|null
     */
    public function getModel()
    {
        return $this->model;
    }

    /**
     * @return null|string
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return ModelInterface|null
     */
    public function getInitialModel()
    {
        return null;
    }

    /**
     * @return array|null
     */
    public function jsonSerialize()
    {
        if (null === $this->model) {
            return null;
        }

        $this->jsonSerializableOrException();

        return $this->model->jsonSerialize();

    }

    /**
     * @throws \LogicException
     */
    private function jsonSerializableOrException()

    {
        if (!$this->model instanceof \JsonSerializable) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            throw new \LogicException(
                sprintf('Model %s does not implement %s', get_class($this->model), \JsonSerializable::class)
            );
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Chubbyphp\Model\Reference;
6
7			use Chubbyphp\Model\ModelInterface;
8
9			final class ModelReference implements ModelReferenceInterface
10			{
11			/**
12			* @var string\|null
13			*/
14			private $id;
15
16			/**
17			* @var ModelInterface\|null
18			*/
19			private $model;
20
21			/**
22			* @param ModelInterface\|null $model
23			* @return ModelReferenceInterface
24			*/
25	1	View Code Duplication	public function setModel(ModelInterface $model = null): ModelReferenceInterface
			0 ignored issues – show Duplication introduced 2016-12-29 12:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26			{
27	1		$this->model = $model;
28	1		$this->id = null !== $model ? $model->getId() : null;
29
30	1		return $this;
31			}
32
33			/**
34			* @return ModelInterface\|null
35			*/
36	1		public function getModel()
37			{
38	1		return $this->model;
39			}
40
41			/**
42			* @return null\|string
43			*/
44	2		public function getId()
45			{
46	2		return $this->id;
47			}
48
49			/**
50			* @return ModelInterface\|null
51			*/
52	1		public function getInitialModel()
53			{
54	1		return null;
55			}
56
57			/**
58			* @return array\|null
59			*/
60	2		public function jsonSerialize()
61			{
62	2		if (null === $this->model) {
63	1		return null;
64			}
65
66	1		$this->jsonSerializableOrException();
67
68	1		return $this->model->jsonSerialize();
			0 ignored issues – show Bug introduced 2017-04-27 12:06 UTC by Report Bug Copy Issue Report The method `jsonSerialize()` does not seem to exist on `object<Chubbyphp\Model\ModelInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
69			}
70
71			/**
72			* @throws \LogicException
73			*/
74		View Code Duplication	private function jsonSerializableOrException()
			0 ignored issues – show Duplication introduced 2017-04-27 12:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75			{
76			if (!$this->model instanceof \JsonSerializable) {
			0 ignored issues – show Bug introduced 2017-04-27 12:06 UTC by Report Bug Copy Issue Report The class `JsonSerializable` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
77			throw new \LogicException(
78			sprintf('Model %s does not implement %s', get_class($this->model), \JsonSerializable::class)
79			);
80			}
81			}
82			}
83

chubbyphp / chubbyphp-model

Push — master ( 74b41a...e78beb )

ModelReference::jsonSerialize() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like