AdvancedErrorHandlerProvider::registerRequirements() - Code Metrics - Inspection of "add error handler middleware" - chubbyphp/chubbyphp-error-handler - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3bf488...347cdc )

by Dominik

created 2016-11-03 12:11 UTC

registerRequirements() A

↳ Parent: AdvancedErrorHandlerProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	1

<?php

declare(strict_types=1);

namespace Chubbyphp\ErrorHandler;

use Negotiation\Negotiator;
use Pimple\Container;
use Pimple\ServiceProviderInterface;

final class AdvancedErrorHandlerProvider implements ServiceProviderInterface

{
    /**
     * @param Container $container
     */
    public function register(Container $container)
    {
        $this->registerRequirements($container);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}

        $container['errorHandler.defaultProvider'] = function () use ($container) {
            throw new \RuntimeException('Please configure your default provider for error handler!');
        };

        $container['errorHandler.providers'] = function () use ($container) {
            return [];
        };

        $container['errorHandler.service'] = function () use ($container) {
            return new AdvancedErrorHandler(
                $container['errorHandler.contentTypeResolver'],
                $container['errorHandler.defaultProvider'],
                $container['errorHandler.providers'],
                $container['logger'] ?? null
            );
        };
    }

    /**
     * @param Container $container
     */
    private function registerRequirements(Container $container)
    {
        $container['errorHandler.acceptNegation'] = function () use ($container) {
            return new Negotiator();
        };

        $container['errorHandler.contentTypeResolver'] = function () use ($container) {
            return new ContentTypeResolver($container['errorHandler.acceptNegation']);
        };
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Chubbyphp\ErrorHandler;
6
7		use Negotiation\Negotiator;
8		use Pimple\Container;
9		use Pimple\ServiceProviderInterface;
10
11	View Code Duplication	final class AdvancedErrorHandlerProvider implements ServiceProviderInterface
		0 ignored issues – show Duplication introduced 2016-11-03 12:15 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12		{
13		/**
14		* @param Container $container
15		*/
16		public function register(Container $container)
17		{
18		$this->registerRequirements($container);
		0 ignored issues – show Unused Code introduced 2016-11-03 12:15 UTC by Report Bug Copy Issue Report The call to the method `Chubbyphp\ErrorHandler\A...:registerRequirements()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
19
20		$container['errorHandler.defaultProvider'] = function () use ($container) {
21		throw new \RuntimeException('Please configure your default provider for error handler!');
22		};
23
24		$container['errorHandler.providers'] = function () use ($container) {
25		return [];
26		};
27
28		$container['errorHandler.service'] = function () use ($container) {
29		return new AdvancedErrorHandler(
30		$container['errorHandler.contentTypeResolver'],
31		$container['errorHandler.defaultProvider'],
32		$container['errorHandler.providers'],
33		$container['logger'] ?? null
34		);
35		};
36		}
37
38		/**
39		* @param Container $container
40		*/
41		private function registerRequirements(Container $container)
42		{
43		$container['errorHandler.acceptNegation'] = function () use ($container) {
44		return new Negotiator();
45		};
46
47		$container['errorHandler.contentTypeResolver'] = function () use ($container) {
48		return new ContentTypeResolver($container['errorHandler.acceptNegation']);
49		};
50		}
51		}
52

chubbyphp / chubbyphp-error-handler

Push — master ( 3bf488...347cdc )

registerRequirements() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like