CreateDatabaseDoctrineCommand::createDatabase() - Code Metrics - Inspection of "fix isPath" - chubbyphp/chubbyphp-doctrine-db-service-provider - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 6a514f...b3c769 )

by Dominik

created 2018-08-07 16:16 UTC

CreateDatabaseDoctrineCommand::createDatabase() A

↳ Parent: CreateDatabaseDoctrineCommand

Complexity

Conditions	3
Paths	5

Size

Total Lines

Duplication

Lines	37
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	37
loc	37
ccs	0
cts	18
cp	0
rs	9.328
c	0
b	0
f	0
cc	3
nc	5
nop	5
crap	12

<?php

declare(strict_types=1);

namespace Chubbyphp\DoctrineDbServiceProvider\Command;

use Doctrine\Common\Persistence\ConnectionRegistry;
use Doctrine\DBAL\Connection;
use Doctrine\DBAL\DriverManager;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Input\InputOption;

/**
 * @see https://github.com/doctrine/DoctrineBundle/blob/master/Command/CreateDatabaseDoctrineCommand.php
 */
final class CreateDatabaseDoctrineCommand extends Command
{
    /**
     * @var ConnectionRegistry
     */
    private $connectionRegistry;

    /**
     * @param ConnectionRegistry $connectionRegistry
     */
    public function __construct(ConnectionRegistry $connectionRegistry)
    {
        parent::__construct();

        $this->connectionRegistry = $connectionRegistry;
    }

    protected function configure()
    {
        $this
            ->setName('dbal:database:create')
            ->setDescription('Creates the configured database')
            ->addOption('connection', null, InputOption::VALUE_OPTIONAL, 'The connection to use for this command')
            ->addOption(
                'if-not-exists',
                null,
                InputOption::VALUE_NONE,
                'Don\'t trigger an error, when the database already exists'
            )
            ->setHelp(<<<EOT
The <info>%command.name%</info> command creates the default connections database:

    <info>php %command.full_name%</info>

You can also optionally specify the name of a connection to create the database for:

    <info>php %command.full_name% --connection=default</info>
EOT
            );
    }

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     *
     * @return int
     */
    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $connectionName = $this->getConnectionName($input);

        $connection = $this->connectionRegistry->getConnection($connectionName);

        $params = $this->getParams($connection);

        $dbName = $this->getDbName($params, $connectionName);

        $isPath = isset($params['path']);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $ifNotExists = $input->getOption('if-not-exists');

        // Need to get rid of _every_ occurrence of dbname from connection configuration
        unset($params['dbname'], $params['path'], $params['url']);

        $tmpConnection = DriverManager::getConnection($params);
        $shouldNotCreateDatabase = $ifNotExists && in_array($dbName, $tmpConnection->getSchemaManager()->listDatabases());

        // Only quote if we don't have a path
        if (!$path) {

            $dbName = $tmpConnection->getDatabasePlatform()->quoteSingleIdentifier($dbName);
        }

        return $this->createDatabase($output, $connectionName, $tmpConnection, $dbName, $shouldNotCreateDatabase);
    }

    /**
     * @param InputInterface $input
     *
     * @return string
     */
    private function getConnectionName(InputInterface $input): string

    {
        $connectionName = $input->getOption('connection');

        if (null !== $connectionName) {
            return $connectionName;
        }

        return $this->connectionRegistry->getDefaultConnectionName();
    }

    /**
     * @param Connection $connection
     *
     * @return array
     */
    private function getParams(Connection $connection): array

    {
        $params = $connection->getParams();
        if (isset($params['master'])) {
            $params = $params['master'];
        }

        return $params;
    }

    /**
     * @param array  $params
     * @param string $connectionName
     *
     * @return string
     */
    private function getDbName(array $params, string $connectionName): string

    {
        if (isset($params['path'])) {
            return $params['path'];
        }

        if (isset($params['dbname'])) {
            return $params['dbname'];
        }

        throw new \InvalidArgumentException('Connection does not contain a \'path\' or \'dbname\' parameter.');
    }

    /**
     * @param OutputInterface $output
     * @param string          $connectionName
     * @param Connection      $tmpConnection
     * @param string          $dbName
     * @param bool            $shouldNotCreateDatabase
     *
     * @return int
     */
    private function createDatabase(

        OutputInterface $output,
        string $connectionName,
        Connection $tmpConnection,
        string $dbName,
        bool $shouldNotCreateDatabase
    ): int {
        try {
            if ($shouldNotCreateDatabase) {
                $output->writeln(
                    sprintf(
                        '<info>Database <comment>%s</comment> for connection named <comment>%s</comment>'
                            .' already exists. Skipped.</info>',
                        $dbName,
                        $connectionName
                    )
                );
            } else {
                $tmpConnection->getSchemaManager()->createDatabase($dbName);
                $output->writeln(
                    sprintf(
                        '<info>Created database <comment>%s</comment>'
                             .' for connection named <comment>%s</comment>.</info>',
                        $dbName,
                        $connectionName
                    )
                );
            }

            return 0;
        } catch (\Exception $e) {
            $output->writeln(sprintf('<error>Could not create database <comment>%s</comment>.</error>', $dbName));
            $output->writeln(sprintf('<error>%s</error>', $e->getMessage()));

            return 1;
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Chubbyphp\DoctrineDbServiceProvider\Command;
6
7			use Doctrine\Common\Persistence\ConnectionRegistry;
8			use Doctrine\DBAL\Connection;
9			use Doctrine\DBAL\DriverManager;
10			use Symfony\Component\Console\Command\Command;
11			use Symfony\Component\Console\Input\InputInterface;
12			use Symfony\Component\Console\Output\OutputInterface;
13			use Symfony\Component\Console\Input\InputOption;
14
15			/**
16			* @see https://github.com/doctrine/DoctrineBundle/blob/master/Command/CreateDatabaseDoctrineCommand.php
17			*/
18			final class CreateDatabaseDoctrineCommand extends Command
19			{
20			/**
21			* @var ConnectionRegistry
22			*/
23			private $connectionRegistry;
24
25			/**
26			* @param ConnectionRegistry $connectionRegistry
27			*/
28	5		public function __construct(ConnectionRegistry $connectionRegistry)
29			{
30	5		parent::__construct();
31
32	5		$this->connectionRegistry = $connectionRegistry;
33	5		}
34
35	5		protected function configure()
36			{
37			$this
38	5		->setName('dbal:database:create')
39	5		->setDescription('Creates the configured database')
40	5		->addOption('connection', null, InputOption::VALUE_OPTIONAL, 'The connection to use for this command')
41	5		->addOption(
42	5		'if-not-exists',
43	5		null,
44	5		InputOption::VALUE_NONE,
45	5		'Don\'t trigger an error, when the database already exists'
46			)
47	5		->setHelp(<<<EOT
48	5		The <info>%command.name%</info> command creates the default connections database:
49
50			<info>php %command.full_name%</info>
51
52			You can also optionally specify the name of a connection to create the database for:
53
54			<info>php %command.full_name% --connection=default</info>
55			EOT
56			);
57	5		}
58
59			/**
60			* @param InputInterface $input
61			* @param OutputInterface $output
62			*
63			* @return int
64			*/
65	5		protected function execute(InputInterface $input, OutputInterface $output): int
66			{
67	5		$connectionName = $this->getConnectionName($input);
68
69	5		$connection = $this->connectionRegistry->getConnection($connectionName);
70
71	5		$params = $this->getParams($connection);
72
73	5		$dbName = $this->getDbName($params, $connectionName);
74
75	4		$isPath = isset($params['path']);
			0 ignored issues – show Unused Code introduced 2018-08-07 16:20 UTC by Report Bug Copy Issue Report `$isPath` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
76
77	4		$ifNotExists = $input->getOption('if-not-exists');
78
79			// Need to get rid of _every_ occurrence of dbname from connection configuration
80	4		unset($params['dbname'], $params['path'], $params['url']);
81
82	4		$tmpConnection = DriverManager::getConnection($params);
83	4		$shouldNotCreateDatabase = $ifNotExists && in_array($dbName, $tmpConnection->getSchemaManager()->listDatabases());
84
85			// Only quote if we don't have a path
86	4		if (!$path) {
			0 ignored issues – show Bug introduced 2018-08-07 16:20 UTC by Report Bug Copy Issue Report The variable `$path` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
87			$dbName = $tmpConnection->getDatabasePlatform()->quoteSingleIdentifier($dbName);
88			}
89
90			return $this->createDatabase($output, $connectionName, $tmpConnection, $dbName, $shouldNotCreateDatabase);
91			}
92
93			/**
94			* @param InputInterface $input
95			*
96			* @return string
97			*/
98	5	View Code Duplication	private function getConnectionName(InputInterface $input): string
			0 ignored issues – show Duplication introduced 2018-08-05 20:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
99			{
100	5		$connectionName = $input->getOption('connection');
101
102	5		if (null !== $connectionName) {
103	3		return $connectionName;
104			}
105
106	2		return $this->connectionRegistry->getDefaultConnectionName();
107			}
108
109			/**
110			* @param Connection $connection
111			*
112			* @return array
113			*/
114	5	View Code Duplication	private function getParams(Connection $connection): array
			0 ignored issues – show Duplication introduced 2018-08-05 20:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
115			{
116	5		$params = $connection->getParams();
117	5		if (isset($params['master'])) {
118	3		$params = $params['master'];
119			}
120
121	5		return $params;
122			}
123
124			/**
125			* @param array $params
126			* @param string $connectionName
127			*
128			* @return string
129			*/
130	5	View Code Duplication	private function getDbName(array $params, string $connectionName): string
			0 ignored issues – show Unused Code introduced 2018-08-07 15:34 UTC by Report Bug Copy Issue Report The parameter `$connectionName` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2018-08-07 16:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
131			{
132	5		if (isset($params['path'])) {
133	1		return $params['path'];
134			}
135
136	4		if (isset($params['dbname'])) {
137	3		return $params['dbname'];
138			}
139
140	1		throw new \InvalidArgumentException('Connection does not contain a \'path\' or \'dbname\' parameter.');
141			}
142
143			/**
144			* @param OutputInterface $output
145			* @param string $connectionName
146			* @param Connection $tmpConnection
147			* @param string $dbName
148			* @param bool $shouldNotCreateDatabase
149			*
150			* @return int
151			*/
152		View Code Duplication	private function createDatabase(
			0 ignored issues – show Duplication introduced 2018-08-07 16:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
153			OutputInterface $output,
154			string $connectionName,
155			Connection $tmpConnection,
156			string $dbName,
157			bool $shouldNotCreateDatabase
158			): int {
159			try {
160			if ($shouldNotCreateDatabase) {
161			$output->writeln(
162			sprintf(
163			'<info>Database <comment>%s</comment> for connection named <comment>%s</comment>'
164			.' already exists. Skipped.</info>',
165			$dbName,
166			$connectionName
167			)
168			);
169			} else {
170			$tmpConnection->getSchemaManager()->createDatabase($dbName);
171			$output->writeln(
172			sprintf(
173			'<info>Created database <comment>%s</comment>'
174			.' for connection named <comment>%s</comment>.</info>',
175			$dbName,
176			$connectionName
177			)
178			);
179			}
180
181			return 0;
182			} catch (\Exception $e) {
183			$output->writeln(sprintf('<error>Could not create database <comment>%s</comment>.</error>', $dbName));
184			$output->writeln(sprintf('<error>%s</error>', $e->getMessage()));
185
186			return 1;
187			}
188			}
189			}
190

chubbyphp / chubbyphp-doctrine-db-service-provider

Push — master ( 6a514f...b3c769 )

CreateDatabaseDoctrineCommand::createDatabase() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like