chubbyphp / chubbyphp-deserialization

src/Decoder/JsonTypeDecoder.php

<?php

declare(strict_types=1);

namespace Chubbyphp\Deserialization\Decoder;

use Chubbyphp\Deserialization\DeserializerRuntimeException;

final class JsonTypeDecoder implements TypeDecoderInterface
{
    public function getContentType(): string
    {
        return 'application/json';
    }

    /**
     * @throws DeserializerRuntimeException
     */
    public function decode(string $data): array
    {
        $decoded = $json = json_decode($data, true);

The assignment to $json is dead and can be removed.

        if (JSON_ERROR_NONE !== json_last_error()) {
            throw DeserializerRuntimeException::createNotParsable($this->getContentType(), json_last_error_msg());
        }

        if (!is_array($decoded)) {
            throw DeserializerRuntimeException::createNotParsable($this->getContentType(), 'Not an object');
        }

        return $decoded;
    }
}