Chubbyphp\Deserialization\Decoder\UrlEncodedTypeDecoder

Complexity

Total Complexity

15

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

96.43%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getContentType()	0	4	1
A	decode()	0	11	3
A	fixValues()	0	15	4
C	fixValue()	0	24	7

<?php

declare(strict_types=1);

namespace Chubbyphp\Deserialization\Decoder;

use Chubbyphp\Deserialization\DeserializerRuntimeException;

final class UrlEncodedTypeDecoder implements TypeDecoderInterface
{
    /**
     * @return string
     */
    public function getContentType(): string
    {
        return 'application/x-www-form-urlencoded';
    }

    /**
     * @param string $data
     *
     * @return array
     *
     * @throws DeserializerRuntimeException
     */
    public function decode(string $data): array
    {
        $rawData = [];
        parse_str($data, $rawData);

        if ('' !== $data && [] === $rawData) {
            throw DeserializerRuntimeException::createNotParsable($this->getContentType());
        }

        return $this->fixValues($rawData);

It seems like $rawData can also be of type null; however, Chubbyphp\Deserialization\Decoder\UrlEncodedTypeDecoder::fixValues() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param array $rawData
     *
     * @return array
     */
    private function fixValues(array $rawData): array
    {
        $data = [];
        foreach ($rawData as $rawKey => $value) {
            $key = (string) (int) $rawKey === $rawData ? (int) $rawKey : $rawKey;

            if (is_array($value)) {
                $data[$key] = $this->fixValues($value);
            } else {
                $data[$key] = $this->fixValue($value);
            }
        }

        return $data;
    }

    /**
     * @param string $value
     *
     * @return mixed
     */
    private function fixValue(string $value)
    {
        if ('' === $value) {
            return null;
        }

        if ('true' === $value) {
            return true;
        }

        if ('false' === $value) {
            return false;
        }

        if (is_numeric($value) && '0' !== $value[0]) {
            if ((string) (int) $value === $value) {
                return (int) $value;
            }

            return (float) $value;
        }

        return $value;
    }
}