DenormalizerObjectMappingRegistry::__construct() - Code Metrics - Inspection of "move-doctrine-related-stuff" - chubbyphp/chubbyphp-deserialization - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#11)

by Dominik

created 2018-04-05 14:26 UTC

DenormalizerObjectMappingRegistry::__construct() A

↳ Parent: DenormalizerObjectMappingRegistry

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	7
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	7
loc	7
ccs	0
cts	7
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1
crap	6

<?php

declare(strict_types=1);

namespace Chubbyphp\Deserialization\Doctrine\Denormalizer;

use Chubbyphp\Deserialization\Denormalizer\DenormalizerObjectMappingRegistryInterface;
use Chubbyphp\Deserialization\DeserializerLogicException;
use Chubbyphp\Deserialization\Mapping\DenormalizationObjectMappingInterface;
use Doctrine\Common\Persistence\Proxy;

final class DenormalizerObjectMappingRegistry implements DenormalizerObjectMappingRegistryInterface

{
    /**
     * @var DenormalizationObjectMappingInterface[]
     */
    private $objectMappings;

    /**
     * @param array $objectMappings
     */
    public function __construct(array $objectMappings)
    {
        $this->objectMappings = [];
        foreach ($objectMappings as $objectMapping) {
            $this->addObjectMapping($objectMapping);
        }
    }

    /**
     * @param DenormalizationObjectMappingInterface $objectMapping
     */
    private function addObjectMapping(DenormalizationObjectMappingInterface $objectMapping)
    {
        $this->objectMappings[$objectMapping->getClass()] = $objectMapping;
    }

    /**
     * @param string $class
     *
     * @return DenormalizationObjectMappingInterface
     *
     * @throws DeserializerLogicException
     */
    public function getObjectMapping(string $class): DenormalizationObjectMappingInterface
    {
        $reflectionClass = new \ReflectionClass($class);

        if (in_array(Proxy::class, $reflectionClass->getInterfaceNames(), true)) {
            $parentClass = $reflectionClass->getParentClass()->name;
            @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                sprintf(
                    'Use "%s" instead of "%s" for "%s"',
                    DoctrineDenormalizerObjectMappingRegistry::class,
                    self::class,
                    $parentClass
                ),
                E_USER_DEPRECATED
            );

            $class = $parentClass;
        }

        if (isset($this->objectMappings[$class])) {
            return $this->objectMappings[$class];
        }

        throw DeserializerLogicException::createMissingMapping($class);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Chubbyphp\Deserialization\Doctrine\Denormalizer;
6
7		use Chubbyphp\Deserialization\Denormalizer\DenormalizerObjectMappingRegistryInterface;
8		use Chubbyphp\Deserialization\DeserializerLogicException;
9		use Chubbyphp\Deserialization\Mapping\DenormalizationObjectMappingInterface;
10		use Doctrine\Common\Persistence\Proxy;
11
12	View Code Duplication	final class DenormalizerObjectMappingRegistry implements DenormalizerObjectMappingRegistryInterface
		0 ignored issues – show Duplication introduced 2018-04-05 14:16 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		/**
15		* @var DenormalizationObjectMappingInterface[]
16		*/
17		private $objectMappings;
18
19		/**
20		* @param array $objectMappings
21		*/
22		public function __construct(array $objectMappings)
23		{
24		$this->objectMappings = [];
25		foreach ($objectMappings as $objectMapping) {
26		$this->addObjectMapping($objectMapping);
27		}
28		}
29
30		/**
31		* @param DenormalizationObjectMappingInterface $objectMapping
32		*/
33		private function addObjectMapping(DenormalizationObjectMappingInterface $objectMapping)
34		{
35		$this->objectMappings[$objectMapping->getClass()] = $objectMapping;
36		}
37
38		/**
39		* @param string $class
40		*
41		* @return DenormalizationObjectMappingInterface
42		*
43		* @throws DeserializerLogicException
44		*/
45		public function getObjectMapping(string $class): DenormalizationObjectMappingInterface
46		{
47		$reflectionClass = new \ReflectionClass($class);
48
49		if (in_array(Proxy::class, $reflectionClass->getInterfaceNames(), true)) {
50		$parentClass = $reflectionClass->getParentClass()->name;
51		@trigger_error(
		0 ignored issues – show Security Best Practice introduced 2018-04-05 14:16 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
52		sprintf(
53		'Use "%s" instead of "%s" for "%s"',
54		DoctrineDenormalizerObjectMappingRegistry::class,
55		self::class,
56		$parentClass
57		),
58		E_USER_DEPRECATED
59		);
60
61		$class = $parentClass;
62		}
63
64		if (isset($this->objectMappings[$class])) {
65		return $this->objectMappings[$class];
66		}
67
68		throw DeserializerLogicException::createMissingMapping($class);
69		}
70		}
71

chubbyphp / chubbyphp-deserialization

Pull Request — master (#11)

DenormalizerObjectMappingRegistry::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like