Passed
Pull Request — master (#11)
by Dominik
04:20 queued 01:29
created

DenormalizerObjectMappingRegistry   A

Complexity

Total Complexity 7

Size/Duplication

Total Lines 61
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 1

Test Coverage

Coverage 100%

Importance

Changes 0
Metric Value
wmc 7
lcom 1
cbo 1
dl 61
loc 61
ccs 24
cts 24
cp 1
rs 10
c 0
b 0
f 0

3 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 7 7 2
A addObjectMapping() 4 4 1
B getObjectMapping() 27 27 4

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
declare(strict_types=1);
4
5
namespace Chubbyphp\Deserialization\Denormalizer;
6
7
use Chubbyphp\Deserialization\DeserializerLogicException;
8
use Chubbyphp\Deserialization\Doctrine\Denormalizer\DenormalizerObjectMappingRegistry as DoctrineDenormalizerObjectMappingRegistry;
9
use Chubbyphp\Deserialization\Mapping\DenormalizationObjectMappingInterface;
10
use Doctrine\Common\Persistence\Proxy;
11
12 View Code Duplication
final class DenormalizerObjectMappingRegistry implements DenormalizerObjectMappingRegistryInterface
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
13
{
14
    /**
15
     * @var DenormalizationObjectMappingInterface[]
16
     */
17
    private $objectMappings;
18
19
    /**
20
     * @param array $objectMappings
21
     */
22 3
    public function __construct(array $objectMappings)
23
    {
24 3
        $this->objectMappings = [];
25 3
        foreach ($objectMappings as $objectMapping) {
26 2
            $this->addObjectMapping($objectMapping);
27
        }
28 3
    }
29
30
    /**
31
     * @param DenormalizationObjectMappingInterface $objectMapping
32
     */
33 2
    private function addObjectMapping(DenormalizationObjectMappingInterface $objectMapping)
34
    {
35 2
        $this->objectMappings[$objectMapping->getClass()] = $objectMapping;
36 2
    }
37
38
    /**
39
     * @param string $class
40
     *
41
     * @return DenormalizationObjectMappingInterface
42
     *
43
     * @throws DeserializerLogicException
44
     */
45 3
    public function getObjectMapping(string $class): DenormalizationObjectMappingInterface
46
    {
47 3
        $reflectionClass = new \ReflectionClass($class);
48
49 3
        if (interface_exists('Doctrine\Common\Persistence\Proxy')
50 3
            && in_array(Proxy::class, $reflectionClass->getInterfaceNames(), true)
51
        ) {
52 1
            $parentClass = $reflectionClass->getParentClass()->name;
53 1
            @trigger_error(
0 ignored issues
show
Security Best Practice introduced by
It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

If you suppress an error, we recommend checking for the error condition explicitly:

// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
Loading history...
54 1
                sprintf(
55 1
                    'Use "%s" instead of "%s" for "%s"',
56 1
                    DoctrineDenormalizerObjectMappingRegistry::class,
57 1
                    self::class,
58 1
                    $parentClass
59
                ),
60 1
                E_USER_DEPRECATED
61
            );
62
63 1
            $class = $parentClass;
64
        }
65
66 3
        if (isset($this->objectMappings[$class])) {
67 2
            return $this->objectMappings[$class];
68
        }
69
70 1
        throw DeserializerLogicException::createMissingMapping($class);
71
    }
72
}
73