UrlEncodedDecoderType::cleanRawData() - Code Metrics - Inspection of "first steps in building the v2" - chubbyphp/chubbyphp-deserialization - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( b50703...9d91c5 )

by Dominik

created 2017-09-25 19:53 UTC

UrlEncodedDecoderType::cleanRawData() D

↳ Parent: UrlEncodedDecoderType

Complexity

Conditions	10
Paths	31

Size

Total Lines	32
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	32
c	0
b	0
f	0
rs	4.8196
cc	10
eloc	20
nc	31
nop	2

How to fix Complexity

<?php

declare(strict_types=1);

namespace Chubbyphp\Deserialization\Decoder;

final class UrlEncodedDecoderType implements DecoderTypeInterface
{
    /**
     * @var string
     */
    private $numericPrefix;

    /**
     * @var string
     */
    private $argSeperator;

    /**
     * @param string $numericPrefix
     * @param string $argSeperator
     */
    public function __construct(string $numericPrefix = '', string $argSeperator = '&')
    {
        $this->numericPrefix = $numericPrefix;
        $this->argSeperator = $argSeperator;
    }

    /**
     * @return string
     */
    public function getContentType(): string
    {
        return 'application/x-www-form-urlencoded';
    }

    /**
     * @param string $data
     *
     * @return array
     *
     * @throws DecoderException
     */
    public function decode(string $data): array
    {
        $data = str_replace($this->argSeperator, '&', $data);

        $rawData = [];
        parse_str($data, $rawData);

        if ('' !== $data && [] === $rawData) {
            throw DecoderException::createNotParsable($this->getContentType());
        }

        return $this->cleanRawData($rawData, strlen($this->numericPrefix));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @param array $rawData
     * @param int   $numericPrefixLength
     *
     * @return array
     */
    private function cleanRawData(array $rawData, int $numericPrefixLength): array
    {
        $data = [];
        foreach ($rawData as $rawKey => $value) {
            if (0 !== $numericPrefixLength && 0 === strpos($rawKey, $this->numericPrefix)) {
                $rawSubKey = substr($rawKey, $numericPrefixLength);
                if (is_numeric($rawSubKey)) {
                    $rawKey = $rawSubKey;
                }
            }

            $key = is_numeric($rawKey) ? (int) $rawKey : $rawKey;

            if (is_array($value)) {
                $data[$key] = $this->cleanRawData($value, $numericPrefixLength);
            } else {
                if (is_numeric($value)) {
                    if ((string) (int) $value === $value) {
                        $value = (int) $value;
                    } else {
                        $value = (float) $value;
                    }
                } elseif ('' === $value) {
                    $value = null;
                }

                $data[$key] = $value;
            }
        }

        return $data;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Chubbyphp\Deserialization\Decoder;
6
7			final class UrlEncodedDecoderType implements DecoderTypeInterface
8			{
9			/**
10			* @var string
11			*/
12			private $numericPrefix;
13
14			/**
15			* @var string
16			*/
17			private $argSeperator;
18
19			/**
20			* @param string $numericPrefix
21			* @param string $argSeperator
22			*/
23			public function __construct(string $numericPrefix = '', string $argSeperator = '&')
24			{
25			$this->numericPrefix = $numericPrefix;
26			$this->argSeperator = $argSeperator;
27			}
28
29			/**
30			* @return string
31			*/
32			public function getContentType(): string
33			{
34			return 'application/x-www-form-urlencoded';
35			}
36
37			/**
38			* @param string $data
39			*
40			* @return array
41			*
42			* @throws DecoderException
43			*/
44			public function decode(string $data): array
45			{
46			$data = str_replace($this->argSeperator, '&', $data);
47
48			$rawData = [];
49			parse_str($data, $rawData);
50
51			if ('' !== $data && [] === $rawData) {
52			throw DecoderException::createNotParsable($this->getContentType());
53			}
54
55			return $this->cleanRawData($rawData, strlen($this->numericPrefix));
			0 ignored issues – show Bug introduced 2017-09-25 19:59 UTC by Report Bug Copy Issue Report It seems like `$rawData` can also be of type `null`; however, `Chubbyphp\Deserializatio...derType::cleanRawData()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
56			}
57
58			/**
59			* @param array $rawData
60			* @param int $numericPrefixLength
61			*
62			* @return array
63			*/
64			private function cleanRawData(array $rawData, int $numericPrefixLength): array
65			{
66			$data = [];
67			foreach ($rawData as $rawKey => $value) {
68			if (0 !== $numericPrefixLength && 0 === strpos($rawKey, $this->numericPrefix)) {
69			$rawSubKey = substr($rawKey, $numericPrefixLength);
70			if (is_numeric($rawSubKey)) {
71			$rawKey = $rawSubKey;
72			}
73			}
74
75			$key = is_numeric($rawKey) ? (int) $rawKey : $rawKey;
76
77			if (is_array($value)) {
78			$data[$key] = $this->cleanRawData($value, $numericPrefixLength);
79			} else {
80			if (is_numeric($value)) {
81			if ((string) (int) $value === $value) {
82			$value = (int) $value;
83			} else {
84			$value = (float) $value;
85			}
86			} elseif ('' === $value) {
87			$value = null;
88			}
89
90			$data[$key] = $value;
91			}
92			}
93
94			return $data;
95			}
96			}
97

chubbyphp / chubbyphp-deserialization

Push — master ( b50703...9d91c5 )

UrlEncodedDecoderType::cleanRawData() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like