CsrfMiddleware::__invoke() - Code Metrics - Inspection of "add CsrfErrorResponseMiddleware which should repla..." - chubbyphp/chubbyphp-csrf - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1b1def...6e81bd )

by Dominik

created 2017-06-26 18:28 UTC

CsrfMiddleware::__invoke() A

↳ Parent: CsrfMiddleware

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	3
crap	1

<?php

declare(strict_types=1);

namespace Chubbyphp\Csrf;

use Chubbyphp\ErrorHandler\HttpException;
use Chubbyphp\Session\SessionInterface;
use Psr\Http\Message\ServerRequestInterface as Request;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;

/**
 * @deprecated use CsrfErrorResponseMiddleware
 */
final class CsrfMiddleware
{
    /**
     * @var CsrfErrorResponseMiddleware
     */
    private $csrfErrorResponseMiddleware;

    const CSRF_KEY = 'csrf';

    const EXCEPTION_STATUS = 424;

    const EXCEPTION_MISSING_IN_SESSION = 'Csrf token is missing within session';
    const EXCEPTION_MISSING_IN_BODY = 'Csrf token is missing within body';
    const EXCEPTION_IS_NOT_SAME = 'Csrf token within body is not the same as in session';

    /**
     * @param CsrfTokenGeneratorInterface $csrfTokenGenerator
     * @param SessionInterface            $session
     * @param LoggerInterface|null        $logger
     */
    public function __construct(
        CsrfTokenGeneratorInterface $csrfTokenGenerator,
        SessionInterface $session,
        LoggerInterface $logger = null
    ) {
        $this->csrfErrorResponseMiddleware = new CsrfErrorResponseMiddleware(
            $csrfTokenGenerator,
            $session,
            new class() implements CsrfErrorHandlerInterface {
                public function errorResponse(
                    Request $request,
                    Response $response,
                    int $code,
                    string $reasonPhrase
                ): Response {
                    throw HttpException::create($request, $response, $code, $reasonPhrase);
                }
            },
            $logger
        );

        $this->csrfTokenGenerator = $csrfTokenGenerator;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->session = $session;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->logger = $logger ?? new NullLogger();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param Request  $request
     * @param Response $response
     * @param callable $next
     *
     * @return Response
     */
    public function __invoke(Request $request, Response $response, callable $next = null)
    {
        return $this->csrfErrorResponseMiddleware->__invoke($request, $response, $next);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Chubbyphp\Csrf;
6
7		use Chubbyphp\ErrorHandler\HttpException;
8		use Chubbyphp\Session\SessionInterface;
9		use Psr\Http\Message\ServerRequestInterface as Request;
10		use Psr\Http\Message\ResponseInterface as Response;
11		use Psr\Log\LoggerInterface;
12		use Psr\Log\NullLogger;
13
14		/**
15		* @deprecated use CsrfErrorResponseMiddleware
16		*/
17		final class CsrfMiddleware
18		{
19		/**
20		* @var CsrfErrorResponseMiddleware
21		*/
22		private $csrfErrorResponseMiddleware;
23
24		const CSRF_KEY = 'csrf';
25
26		const EXCEPTION_STATUS = 424;
27
28		const EXCEPTION_MISSING_IN_SESSION = 'Csrf token is missing within session';
29		const EXCEPTION_MISSING_IN_BODY = 'Csrf token is missing within body';
30		const EXCEPTION_IS_NOT_SAME = 'Csrf token within body is not the same as in session';
31
32		/**
33		* @param CsrfTokenGeneratorInterface $csrfTokenGenerator
34		* @param SessionInterface $session
35		* @param LoggerInterface\|null $logger
36		*/
37	6	public function __construct(
38		CsrfTokenGeneratorInterface $csrfTokenGenerator,
39		SessionInterface $session,
40		LoggerInterface $logger = null
41		) {
42	6	$this->csrfErrorResponseMiddleware = new CsrfErrorResponseMiddleware(
43	6	$csrfTokenGenerator,
44	6	$session,
45		new class() implements CsrfErrorHandlerInterface {
46	3	public function errorResponse(
47		Request $request,
48		Response $response,
49		int $code,
50		string $reasonPhrase
51		): Response {
52	3	throw HttpException::create($request, $response, $code, $reasonPhrase);
53		}
54		},
55	6	$logger
56		);
57
58	6	$this->csrfTokenGenerator = $csrfTokenGenerator;
		0 ignored issues – show Bug introduced 2017-06-26 18:32 UTC by Report Bug Copy Issue Report The property `csrfTokenGenerator` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
59	6	$this->session = $session;
		0 ignored issues – show Bug introduced 2017-06-26 18:32 UTC by Report Bug Copy Issue Report The property `session` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
60	6	$this->logger = $logger ?? new NullLogger();
		0 ignored issues – show Bug introduced 2017-06-26 18:32 UTC by Report Bug Copy Issue Report The property `logger` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
61	6	}
62
63		/**
64		* @param Request $request
65		* @param Response $response
66		* @param callable $next
67		*
68		* @return Response
69		*/
70	6	public function __invoke(Request $request, Response $response, callable $next = null)
71		{
72	6	return $this->csrfErrorResponseMiddleware->__invoke($request, $response, $next);
73		}
74		}
75

chubbyphp / chubbyphp-csrf

Push — master ( 1b1def...6e81bd )

CsrfMiddleware::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like