Test Failed
Push — master ( 98997f...e65f7f )
by Dominik
02:18
created

app/Controller/Course/CourseUpdateController.php (4 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
declare(strict_types=1);
4
5
namespace Chubbyphp\ApiSkeleton\Controller\Course;
6
7
use Chubbyphp\ApiHttp\Error\Error;
8
use Chubbyphp\ApiHttp\Manager\RequestManagerInterface;
9
use Chubbyphp\ApiHttp\Manager\ResponseManagerInterface;
10
use Chubbyphp\Model\RepositoryInterface;
11
use Chubbyphp\Translation\TranslatorInterface;
12
use Chubbyphp\Validation\Error\NestedErrorMessages;
13
use Chubbyphp\Validation\ValidatorInterface;
14
use Psr\Http\Message\ServerRequestInterface as Request;
15
use Psr\Http\Message\ResponseInterface as Response;
16
use Chubbyphp\ApiSkeleton\Model\Course;
17
18
final class CourseUpdateController
19
{
20
    /**
21
     * @var string
22
     */
23
    private $defaultLanguage;
24
25
    /**
26
     * @var RepositoryInterface
27
     */
28
    private $repository;
29
30
    /**
31
     * @var RequestManagerInterface
32
     */
33
    private $requestManager;
34
35
    /**
36
     * @var ResponseManagerInterface
37
     */
38
    private $responseManager;
39
40
    /**
41
     * @var TranslatorInterface
42
     */
43
    private $translator;
44
45
    /**
46
     * @var ValidatorInterface
47
     */
48
    private $validator;
49
50
    /**
51
     * @param string                   $defaultLanguage
52
     * @param RepositoryInterface      $repository
53
     * @param RequestManagerInterface  $requestManager
54
     * @param ResponseManagerInterface $responseManager
55
     * @param TranslatorInterface      $translator
56
     * @param ValidatorInterface       $validator
57
     */
58 View Code Duplication
    public function __construct(
0 ignored issues
show
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
59
        string $defaultLanguage,
60
        RepositoryInterface $repository,
61
        RequestManagerInterface $requestManager,
62
        ResponseManagerInterface $responseManager,
63
        TranslatorInterface $translator,
64
        ValidatorInterface $validator
65
    ) {
66
        $this->defaultLanguage = $defaultLanguage;
67
        $this->repository = $repository;
68
        $this->requestManager = $requestManager;
69
        $this->responseManager = $responseManager;
70
        $this->translator = $translator;
71
        $this->validator = $validator;
72
    }
73
74
    /**
75
     * @param Request $request
76
     *
77
     * @return Response
78
     */
79
    public function __invoke(Request $request): Response
80
    {
81
        if (null === $accept = $this->requestManager->getAccept($request)) {
82
            return $this->responseManager->createAcceptNotSupportedResponse($request);
83
        }
84
85 View Code Duplication
        if (null === $contentType = $this->requestManager->getContentType($request)) {
0 ignored issues
show
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
86
            return $this->responseManager->createContentTypeNotSupportedResponse($request, $accept);
87
        }
88
89
        $id = $request->getAttribute('id');
90
91
        /** @var Course $course */
92
        if (null === $course = $this->repository->find($id)) {
93
            return $this->responseManager->createResourceNotFoundResponse($request, $accept, 'course', ['id' => $id]);
94
        }
95
96
        /** @var Course $course */
97
        if (null === $course = $this->requestManager->getDataFromRequestBody($request, $course, $contentType)) {
98
            return $this->responseManager->createBodyNotDeserializableResponse($request, $accept, $contentType);
99
        }
100
101 View Code Duplication
        if ([] !== $errors = $this->validator->validateObject($course)) {
0 ignored issues
show
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
102
            $locale = $this->requestManager->getAcceptLanguage($request, $this->defaultLanguage);
103
104
            return $this->responseManager->createValidationErrorResponse(
105
                $request,
106
                $accept,
107
                Error::SCOPE_BODY,
108
                'course',
109
                (new NestedErrorMessages($errors, function (string $key, array $arguments) use ($locale) {
0 ignored issues
show
$errors is of type array<integer,string>, but the function expects a array<integer,object<Chu...\Error\ErrorInterface>>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
110
                    return $this->translator->translate($locale, $key, $arguments);
111
                }))->getMessages()
112
            );
113
        }
114
115
        $this->repository->persist($course);
116
117
        return $this->responseManager->createResponse($request, 200, $accept, $course);
118
    }
119
}
120