BadRequest::getStatus() - Code Metrics - Inspection of "api-problem" - chubbyphp/chubbyphp-api-http - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2)

by Dominik

created 2019-04-15 18:32 UTC

BadRequest::getStatus() A

↳ Parent: BadRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

declare(strict_types=1);

namespace Chubbyphp\ApiHttp\ApiProblem\ClientError;

use Chubbyphp\ApiHttp\ApiProblem\AbstractApiProblem;
use Chubbyphp\ApiHttp\ApiProblem\ApiProblemInterface;

final class BadRequest extends AbstractApiProblem
{
    /**
     * @var array[]
     */
    private $invalidParameters = [];

    /**
     * @return int
     */
    public function getStatus(): int
    {
        return 400;
    }

    /**
     * @return string
     */
    public function getType(): string
    {
        return 'https://tools.ietf.org/html/rfc2616#section-10.4.1';
    }

    /**
     * @param string[] $invalidParameters
     *
     * @return ApiProblemInterface
     */
    public function withInvalidParameters(array $invalidParameters): ApiProblemInterface
    {
        $clone = clone $this;
        $clone->invalidParameters = $invalidParameters;


        return $clone;
    }

    /**
     * @return array
     */
    public function getInvalidParameters(): array
    {
        return $this->invalidParameters;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Chubbyphp\ApiHttp\ApiProblem\ClientError;
6
7		use Chubbyphp\ApiHttp\ApiProblem\AbstractApiProblem;
8		use Chubbyphp\ApiHttp\ApiProblem\ApiProblemInterface;
9
10		final class BadRequest extends AbstractApiProblem
11		{
12		/**
13		* @var array[]
14		*/
15		private $invalidParameters = [];
16
17		/**
18		* @return int
19		*/
20	2	public function getStatus(): int
21		{
22	2	return 400;
23		}
24
25		/**
26		* @return string
27		*/
28	2	public function getType(): string
29		{
30	2	return 'https://tools.ietf.org/html/rfc2616#section-10.4.1';
31		}
32
33		/**
34		* @param string[] $invalidParameters
35		*
36		* @return ApiProblemInterface
37		*/
38	1	public function withInvalidParameters(array $invalidParameters): ApiProblemInterface
39		{
40	1	$clone = clone $this;
41	1	$clone->invalidParameters = $invalidParameters;
		0 ignored issues – show Documentation Bug introduced 2019-04-15 18:27 UTC by Report Bug Copy Issue Report It seems like `$invalidParameters` of type `array<integer,string>` is incompatible with the declared type `array<integer,array>` of property `$invalidParameters`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
42
43	1	return $clone;
44		}
45
46		/**
47		* @return array
48		*/
49	2	public function getInvalidParameters(): array
50		{
51	2	return $this->invalidParameters;
52		}
53		}
54

chubbyphp / chubbyphp-api-http

Pull Request — master (#2)

BadRequest::getStatus() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like