Chubbyphp\ApiHttp\Manager\ResponseManager

Complexity

Total Complexity

5

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
B	createResponse()	0	24	4

<?php

declare(strict_types=1);

namespace Chubbyphp\ApiHttp\Manager;

use Chubbyphp\ApiHttp\Factory\ResponseFactoryInterface;
use Chubbyphp\Serialization\SerializerInterface;
use Chubbyphp\Serialization\TransformerInterface;
use Psr\Http\Message\ServerRequestInterface as Request;
use Psr\Http\Message\ResponseInterface as Response;

final class ResponseManager implements ResponseManagerInterface
{
    /**
     * @var RequestManagerInterface
     */
    private $requestManager;

    /**
     * @var ResponseFactoryInterface
     */
    private $responseFactory;

    /**
     * @var SerializerInterface
     */
    private $serializer;

    /**
     * @var TransformerInterface
     */
    private $transformer;

    /**
     * @param RequestManagerInterface  $requestManager
     * @param ResponseFactoryInterface $responseFactory
     * @param SerializerInterface      $serializer
     * @param TransformerInterface     $transformer
     */
    public function __construct(
        RequestManagerInterface $requestManager,
        ResponseFactoryInterface $responseFactory,
        SerializerInterface $serializer,
        TransformerInterface $transformer
    ) {
        $this->requestManager = $requestManager;
        $this->responseFactory = $responseFactory;
        $this->serializer = $serializer;
        $this->transformer = $transformer;
    }

    /**
     * @param Request     $request
     * @param int         $code
     * @param object      $object
     * @param string|null $defaultAccept
     *
     * @return Response
     */
    public function createResponse(
        Request $request,
        int $code = 200,
        $object = null,
        string $defaultAccept = null
    ): Response {
        $response = $this->responseFactory->createResponse($code);

        if (200 === $code && null === $object) {
            return $response->withStatus(204);
        }

        if (null === $accept = $this->requestManager->getAccept($request, $defaultAccept)) {
            return $response->withStatus(406);
        }

        $body = $this->transformer->transform($this->serializer->serialize($request, $object), $accept);

It seems like $object defined by parameter $object on line 64 can also be of type null; however, Chubbyphp\Serialization\SerializerInterface::serialize() does only seem to accept object, maybe add an additional type check?

        /** @var Response $response */
        $response = $response->withStatus($code)->withHeader('Content-Type', $accept);
        $response->getBody()->write($body);

        return $response;
    }
}