AppBundle\Variable\Service

Complexity

Total Complexity

10

Size/Duplication

Total Lines	104
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

67.92%

Importance

Changes	4
Bugs	1	Features	2

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getDoctrine()	0	4	1
A	get()	0	11	2
B	set()	0	47	5
A	getDayHistory()	0	20	1

<?php

namespace AppBundle\Variable;

use AppBundle\Entity\Variable;
use AppBundle\Entity\VariableHistory;
use AppBundle\Variable\Parser\ParserInterface;
use Doctrine\Bundle\DoctrineBundle\Registry;
use Doctrine\ORM\EntityManager;
use Symfony\Component\Config\Definition\Exception\Exception;

class Service
{

    private $doctrine;
    private $needSync = false;
    private $syncHost;

    public function __construct(Registry $doctrine, $needSync, $syncHost)
    {
        $this->doctrine = $doctrine;
        $this->needSync = $needSync;
        $this->syncHost = $syncHost;
    }

    private function getDoctrine()
    {
        return $this->doctrine;
    }

    public function get($varName)
    {
        $vars = $this->getDoctrine()->getRepository('AppBundle:Variable');

        /** @var Variable $var */
        $var = $vars->findOneBy(['name'=>$varName]);
        if (!$var) {
            throw new Exception('Variable '.$varName.' not found');
        }
        return $var;
    }

    public function set($varName, $value)
    {
        $vars = $this->getDoctrine()->getRepository('AppBundle:Variable');

        /** @var Variable $var */
        $var = $vars->findOneBy(['name'=>$varName]);
        if (!$var) {
            throw new Exception('Variable '.$varName.' not found');
        }

        $parser = 'AppBundle\Variable\Parser\\'.ucfirst($var->getParser());

        if (!class_exists($parser)) {
            throw new Exception('Unknown parser: '.$parser);
        }

        /** @var ParserInterface $parser */
        $parser = new $parser();

        $value = $parser->parse($value);

        if (!$value) {
            return false;
        }

        if ($this->needSync) {
            @file_get_contents($this->syncHost.'set/'.$varName.'?value='.$value);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }

        $var->setValue($value);
        $var->setLaststatus(200);
        $var->setLastupdate(new \DateTime());

        $this->getDoctrine()->getManagerForClass('AppBundle:Variable')->persist($var);

        $state = new VariableHistory();
        $state->setVar($var);
        $state->setTime(new \DateTime());
        $state->setValue($value);

        $this->getDoctrine()->getManagerForClass('AppBundle:VariableHistory')->persist($state);

        $this->getDoctrine()->getManagerForClass('AppBundle:Variable')->flush();
        $this->getDoctrine()->getManagerForClass('AppBundle:VariableHistory')->flush();

        return $value;
    }

    /**
     * @param Variable $variable
     * @return array
     */
    public function getDayHistory(Variable $variable)
    {
        /** @var EntityManager $em */
        $em = $this->getDoctrine()->getManager();

        $q = $em->createQueryBuilder();
        $res = $q->
            select('AVG(vh.value) as av')->
            addSelect('DATE_FORMAT(vh.time,\'%Y-%m-%d %H:%i\') as df')->
            from('AppBundle:VariableHistory', 'vh')->
            where('vh.time >= :date')->
            setParameter('date', new \DateTime('-24 hour'))->
            andWhere('vh.var = :var_id')->
            setParameter('var_id', $variable->getId())->
            groupBy('df')->
            orderBy('df', 'asc')->
            getQuery();

        return $res->getArrayResult();
    }
}