Service::getLastValue() - Code Metrics - Inspection of "+ Add executors, example of movement data updater" - chrl/myhome - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 289c61...45ac24 )

by Kirill

created 2017-03-04 20:34 UTC

Service::getLastValue() A

↳ Parent: Service

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	0
cts	12
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	13
nc	1
nop	1
crap	2

<?php

namespace AppBundle\Variable;

use AppBundle\Entity\Variable;
use AppBundle\Entity\VariableHistory;
use AppBundle\Variable\Parser\ParserInterface;
use Doctrine\Bundle\DoctrineBundle\Registry;
use Doctrine\ORM\EntityManager;
use Symfony\Component\Config\Definition\Exception\Exception;

class Service
{

    private $doctrine;
    private $needSync = false;
    private $syncHost;

    public function __construct(Registry $doctrine, $needSync, $syncHost)
    {
        $this->doctrine = $doctrine;
        $this->needSync = $needSync;
        $this->syncHost = $syncHost;
    }

    private function getDoctrine()
    {
        return $this->doctrine;
    }

    public function get($varName)
    {
        $vars = $this->getDoctrine()->getRepository('AppBundle:Variable');

        /** @var Variable $var */
        $var = $vars->findOneBy(['name'=>$varName]);
        if (!$var) {
            throw new Exception('Variable '.$varName.' not found');
        }
        return $var;
    }

    public function set($varName, $value)
    {
        $vars = $this->getDoctrine()->getRepository('AppBundle:Variable');

        /** @var Variable $var */
        $var = $vars->findOneBy(['name'=>$varName]);
        if (!$var) {
            throw new Exception('Variable '.$varName.' not found');
        }

        $parser = 'AppBundle\Variable\Parser\\'.ucfirst($var->getParser());

        if (!class_exists($parser)) {
            throw new Exception('Unknown parser: '.$parser);
        }

        /** @var ParserInterface $parser */
        $parser = new $parser();

        $value = $parser->parse($value);

        if (!$value) {
            return false;
        }

        if ($this->needSync) {
            if ($var->needSync) {
                @file_get_contents($this->syncHost . 'set/' . $varName . '?value=' . $value);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
        }

        $var->setValue($value);
        $var->setLaststatus(200);
        $var->setLastupdate(new \DateTime());

        $this->getDoctrine()->getManagerForClass('AppBundle:Variable')->persist($var);

        if ($var->needHistory) {
            $state = new VariableHistory();
            $state->setVar($var);
            $state->setTime(new \DateTime());
            $state->setValue($value);

            $this->getDoctrine()->getManagerForClass('AppBundle:VariableHistory')->persist($state);
            $this->getDoctrine()->getManagerForClass('AppBundle:VariableHistory')->flush();
        }

        $this->getDoctrine()->getManagerForClass('AppBundle:Variable')->flush();

        return $value;
    }

    /**
     * @param Variable $variable
     * @return array
     */
    public function getDayHistory(Variable $variable)
    {
        /** @var EntityManager $em */
        $em = $this->getDoctrine()->getManager();

        $q = $em->createQueryBuilder();
        $res = $q->
            select('AVG(vh.value) as av')->
            addSelect('DATE_FORMAT(vh.time,\'%Y-%m-%d %H:00\') as df')->
            from('AppBundle:VariableHistory', 'vh')->
            where('vh.time >= :date')->
            setParameter('date', new \DateTime('-48 hour'))->
            andWhere('vh.var = :var_id')->
            setParameter('var_id', $variable->getId())->
            groupBy('df')->
            orderBy('df', 'asc')->
            getQuery();

        return $res->getArrayResult();
    }

    /**
     * @param Variable $variable
     * @return array
     */
    public function getLastValue(Variable $variable)
    {
        /** @var EntityManager $em */
        $em = $this->getDoctrine()->getManager();

        $q = $em->createQueryBuilder();
        $res = $q->
        select('vh.value as av')->
        addSelect('vh.time as df')->
        from('AppBundle:VariableHistory', 'vh')->
        where('vh.var = :var_id')->
        setParameter('var_id', $variable->getId())->
        orderBy('df', 'desc')->
        setMaxResults(1)->
        getQuery();

        return $res->getSingleResult();
    }
}


1		<?php
2
3		namespace AppBundle\Variable;
4
5		use AppBundle\Entity\Variable;
6		use AppBundle\Entity\VariableHistory;
7		use AppBundle\Variable\Parser\ParserInterface;
8		use Doctrine\Bundle\DoctrineBundle\Registry;
9		use Doctrine\ORM\EntityManager;
10		use Symfony\Component\Config\Definition\Exception\Exception;
11
12		class Service
13		{
14
15		private $doctrine;
16		private $needSync = false;
17		private $syncHost;
18
19	4	public function __construct(Registry $doctrine, $needSync, $syncHost)
20		{
21	4	$this->doctrine = $doctrine;
22	4	$this->needSync = $needSync;
23	4	$this->syncHost = $syncHost;
24	4	}
25
26	4	private function getDoctrine()
27		{
28	4	return $this->doctrine;
29		}
30
31	4	public function get($varName)
32		{
33	4	$vars = $this->getDoctrine()->getRepository('AppBundle:Variable');
34
35		/** @var Variable $var */
36	4	$var = $vars->findOneBy(['name'=>$varName]);
37	4	if (!$var) {
38	1	throw new Exception('Variable '.$varName.' not found');
39		}
40	3	return $var;
41		}
42
43	2	public function set($varName, $value)
44		{
45	2	$vars = $this->getDoctrine()->getRepository('AppBundle:Variable');
46
47		/** @var Variable $var */
48	2	$var = $vars->findOneBy(['name'=>$varName]);
49	2	if (!$var) {
50		throw new Exception('Variable '.$varName.' not found');
51		}
52
53	2	$parser = 'AppBundle\Variable\Parser\\'.ucfirst($var->getParser());
54
55	2	if (!class_exists($parser)) {
56		throw new Exception('Unknown parser: '.$parser);
57		}
58
59		/** @var ParserInterface $parser */
60	2	$parser = new $parser();
61
62	2	$value = $parser->parse($value);
63
64	2	if (!$value) {
65	1	return false;
66		}
67
68	2	if ($this->needSync) {
69		if ($var->needSync) {
70		@file_get_contents($this->syncHost . 'set/' . $varName . '?value=' . $value);
		0 ignored issues – show Security Best Practice introduced 2017-02-21 22:46 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
71		}
72		}
73
74	2	$var->setValue($value);
75	2	$var->setLaststatus(200);
76	2	$var->setLastupdate(new \DateTime());
77
78	2	$this->getDoctrine()->getManagerForClass('AppBundle:Variable')->persist($var);
79
80	2	if ($var->needHistory) {
81		$state = new VariableHistory();
82		$state->setVar($var);
83		$state->setTime(new \DateTime());
84		$state->setValue($value);
85
86		$this->getDoctrine()->getManagerForClass('AppBundle:VariableHistory')->persist($state);
87		$this->getDoctrine()->getManagerForClass('AppBundle:VariableHistory')->flush();
88		}
89
90	2	$this->getDoctrine()->getManagerForClass('AppBundle:Variable')->flush();
91
92	2	return $value;
93		}
94
95		/**
96		* @param Variable $variable
97		* @return array
98		*/
99		public function getDayHistory(Variable $variable)
100		{
101		/** @var EntityManager $em */
102		$em = $this->getDoctrine()->getManager();
103
104		$q = $em->createQueryBuilder();
105		$res = $q->
106		select('AVG(vh.value) as av')->
107		addSelect('DATE_FORMAT(vh.time,\'%Y-%m-%d %H:00\') as df')->
108		from('AppBundle:VariableHistory', 'vh')->
109		where('vh.time >= :date')->
110		setParameter('date', new \DateTime('-48 hour'))->
111		andWhere('vh.var = :var_id')->
112		setParameter('var_id', $variable->getId())->
113		groupBy('df')->
114		orderBy('df', 'asc')->
115		getQuery();
116
117		return $res->getArrayResult();
118		}
119
120		/**
121		* @param Variable $variable
122		* @return array
123		*/
124		public function getLastValue(Variable $variable)
125		{
126		/** @var EntityManager $em */
127		$em = $this->getDoctrine()->getManager();
128
129		$q = $em->createQueryBuilder();
130		$res = $q->
131		select('vh.value as av')->
132		addSelect('vh.time as df')->
133		from('AppBundle:VariableHistory', 'vh')->
134		where('vh.var = :var_id')->
135		setParameter('var_id', $variable->getId())->
136		orderBy('df', 'desc')->
137		setMaxResults(1)->
138		getQuery();
139
140		return $res->getSingleResult();
141		}
142		}
143

chrl / myhome

Push — master ( 289c61...45ac24 )

Service::getLastValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like