Service::execute() - Code Metrics - Inspection of "+ Add new container" - chrl/myhome - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ca6541...851321 )

by Kirill

created 2017-03-15 22:22 UTC

Service::execute() B

↳ Parent: Service

Complexity

Conditions	5
Paths	5

Size

Total Lines	52
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	24
CRAP Score	5.0729

Importance

Changes

Metric	Value
dl	0
loc	52
ccs	24
cts	28
cp	0.8571
rs	8.6868
c	0
b	0
f	0
cc	5
eloc	29
nc	5
nop	4
crap	5.0729

How to fix Long Method

<?php
/**
 * Created by PhpStorm.
 * User: chrl
 * Date: 04/03/17
 * Time: 17:49
 */

namespace AppBundle\Action;

use AppBundle\Action\Executor\ExecutorInterface;
use AppBundle\Entity\Action;
use AppBundle\Entity\ActionHistory;
use Doctrine\Bundle\DoctrineBundle\Registry;

class Service
{

    private $doctrine;
    private $container;

    public function __construct(Registry $doctrine, $container)
    {
        $this->doctrine = $doctrine;
        $this->container = $container;
    }

    private function getDoctrine()
    {
        return $this->doctrine;
    }


    public function executeVirtual(Action $action, $source, array $changeSet)
    {
        return $this->execute($action, $source, $changeSet, true);
    }

    /**
     * @param string $source
     */
    public function executeReal(Action $action, $source, $arguments)
    {
        return $this->execute($action, $source, $arguments, false);
    }

    public function execute(Action $action, $source = 'internal', array $changeSet = [], $virtual = false)
    {

        //TODO: Find and run executor here

        if (!$virtual) {
            list($executor, $method) = explode(':', $action->getExecutor());

            $executor = 'AppBundle\Action\Executor\\'.ucfirst($executor);

            if (!class_exists($executor)) {
                throw new \Exception('Unknown executor: '.$executor);
            }

            /** @var ExecutorInterface $executor */
            $executor = new $executor();
            $executor->setDoctrine($this->getDoctrine());

            $executor->setContainer($this->container);
            unset($changeSet['container']);


            if (!method_exists($executor, $method)) {
                throw new \Exception('Unknown executor method: '.$action->getExecutor().'()');
            }

            $executor->setParameters($changeSet);

            try {
                $result = $executor->{$method}($action);
            } catch (\Exception $exception) {
                $result = $exception->getMessage();
            }
            $changeSet['result'] = $result;
        }

        $state = new ActionHistory();
        $state->setAction($action);
        $state->setTime(new \DateTime());
        $state->setSource($source);
        $state->setPerformed(!$virtual);
        $state->setChangeSet(json_encode($changeSet));

        $device = $action->getDevice()->setState($changeSet);

        $this->getDoctrine()->getManagerForClass('AppBundle:ActionHistory')->persist($state);
        $this->getDoctrine()->getManagerForClass('AppBundle:Device')->persist($device);

        $this->getDoctrine()->getManager()->flush();

        return $this;
    }

    public function runAction($actionName, array $parameters)
    {
        $action = $this->doctrine->getRepository('AppBundle:Action')->findOneBy(['name'=>$actionName]);
        if (!$action) {
            throw new \Exception("Action ".$actionName." not found");
        }


        if (isset($parameter['container'])) {

            $args['container'] = $parameter['container'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        $this->executeReal($action, "internalcall", $parameters);
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: chrl
5		* Date: 04/03/17
6		* Time: 17:49
7		*/
8
9		namespace AppBundle\Action;
10
11		use AppBundle\Action\Executor\ExecutorInterface;
12		use AppBundle\Entity\Action;
13		use AppBundle\Entity\ActionHistory;
14		use Doctrine\Bundle\DoctrineBundle\Registry;
15
16		class Service
17		{
18
19		private $doctrine;
20		private $container;
21
22	5	public function __construct(Registry $doctrine, $container)
23		{
24	5	$this->doctrine = $doctrine;
25	5	$this->container = $container;
26	5	}
27
28	1	private function getDoctrine()
29		{
30	1	return $this->doctrine;
31		}
32
33
34		public function executeVirtual(Action $action, $source, array $changeSet)
35		{
36		return $this->execute($action, $source, $changeSet, true);
37		}
38
39		/**
40		* @param string $source
41		*/
42	1	public function executeReal(Action $action, $source, $arguments)
43		{
44	1	return $this->execute($action, $source, $arguments, false);
45		}
46
47	1	public function execute(Action $action, $source = 'internal', array $changeSet = [], $virtual = false)
48		{
49
50		//TODO: Find and run executor here
51
52	1	if (!$virtual) {
53	1	list($executor, $method) = explode(':', $action->getExecutor());
54
55	1	$executor = 'AppBundle\Action\Executor\\'.ucfirst($executor);
56
57	1	if (!class_exists($executor)) {
58		throw new \Exception('Unknown executor: '.$executor);
59		}
60
61		/** @var ExecutorInterface $executor */
62	1	$executor = new $executor();
63	1	$executor->setDoctrine($this->getDoctrine());
64
65	1	$executor->setContainer($this->container);
66	1	unset($changeSet['container']);
67
68
69	1	if (!method_exists($executor, $method)) {
70		throw new \Exception('Unknown executor method: '.$action->getExecutor().'()');
71		}
72
73	1	$executor->setParameters($changeSet);
74
75		try {
76	1	$result = $executor->{$method}($action);
77		} catch (\Exception $exception) {
78		$result = $exception->getMessage();
79		}
80	1	$changeSet['result'] = $result;
81		}
82
83	1	$state = new ActionHistory();
84	1	$state->setAction($action);
85	1	$state->setTime(new \DateTime());
86	1	$state->setSource($source);
87	1	$state->setPerformed(!$virtual);
88	1	$state->setChangeSet(json_encode($changeSet));
89
90	1	$device = $action->getDevice()->setState($changeSet);
91
92	1	$this->getDoctrine()->getManagerForClass('AppBundle:ActionHistory')->persist($state);
93	1	$this->getDoctrine()->getManagerForClass('AppBundle:Device')->persist($device);
94
95	1	$this->getDoctrine()->getManager()->flush();
96
97	1	return $this;
98		}
99
100		public function runAction($actionName, array $parameters)
101		{
102		$action = $this->doctrine->getRepository('AppBundle:Action')->findOneBy(['name'=>$actionName]);
103		if (!$action) {
104		throw new \Exception("Action ".$actionName." not found");
105		}
106
107
108		if (isset($parameter['container'])) {
		0 ignored issues – show Bug introduced 2017-03-04 22:25 UTC by Report Bug Copy Issue Report The variable `$parameter` does not exist. Did you mean `$parameters`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
109		$args['container'] = $parameter['container'];
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-04 22:25 UTC by Report Bug Copy Issue Report `$args` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$args = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
110		}
111		$this->executeReal($action, "internalcall", $parameters);
112		}
113		}
114

chrl / myhome

Push — master ( ca6541...851321 )

Service::execute() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like