AppBundle\Controller\NooliteController

Complexity

Total Complexity

26

Size/Duplication

Total Lines	166
Duplicated Lines	30.72 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
F	putAction()	41	129	24
A	sendResponse()	10	10	2

<?php

namespace AppBundle\Controller;

use AppBundle\Entity\Action;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

class NooliteController extends Controller
{

    private $channelMap = [

        1 => ['name'=>'noolite.main','source'=>'human'],
        2 => ['name'=>'noolite.kitchen','source'=>'human'],
        3 => ['name'=>'noolite.diningroom','source'=>'human'],
        4 => ['name'=>'noolite.main','source'=>'pi'],
        5 => ['name'=>'noolite.toilet','source'=>'pi'],
        6 => ['name'=>'noolite.diningroom','source'=>'pi'],
        7 => ['name'=>'noolite.kitchen','source'=>'pi'],
    ];

    /**
     * @Route("/noolite", methods={"GET"})
     * @param Request $request
     * @return Response
     * @throws \Exception
     */
    public function putAction(Request $request)
    {

        $channel = $request->get('ch');

        if (!$channel) {
            return $this->sendResponse(false, ['message'=>'No channel is set']);
        }


        if (isset($this->channelMap[$channel])) {
            $device = $this->
                        getDoctrine()->
                        getRepository('AppBundle:Device')->
                        findOneBy(['alias'=>$this->channelMap[$channel]['name']]);

            if (!$device) {
                return $this->sendResponse(
                    false,
                    ['message'=>'Device "'.$this->channelMap[$channel]['name'].'" not found']
                );
            }

            $actions = $device->getActions();


            $resultAction = null;
            $changeSet = [];


            if ($request->get('cmd')==4) {
                // reverse state, only by human

                $oldState = $device->getState();
                $oldState = $oldState['state'];

                if ($oldState == 'off') {
                    // turning on
                    $changeSet = ['state'=>'on'];

                    /** @var Action $action */
                    foreach ($actions as $action) {
                        if ($action->getArguments()=='{"state":"on"}') {
                            $resultAction = $action;
                            break;
                        }
                    }
                } else {

This code seems to be duplicated across your project.

                    // turning off
                    $changeSet = ['state'=>'off'];
                    /** @var Action $action */
                    foreach ($actions as $action) {
                        if ($action->getArguments()=='{"state":"off"}') {
                            $resultAction = $action;
                            break;
                        }
                    }
                }
            }

            if ($request->get('cmd')==0) {

This code seems to be duplicated across your project.

                // turn off, only by pi

                $changeSet = ['state'=>'off'];
                /** @var Action $action */
                foreach ($actions as $action) {
                    if ($action->getArguments()=='{"state":"off"}') {
                        $resultAction = $action;
                        break;
                    }
                }
            }

            if ($request->get('cmd')==6) {
                // turn off, only by pi

                $percent = round((($request->get('d0') - 34)/123) * 100);

                $changeSet = ['state'=>'on','percent'=>$percent];
                /** @var Action $action */
                foreach ($actions as $action) {
                    if ($action->getArguments()=='{"state":"on"}') {
                        $resultAction = $action;
                        break;
                    }
                }
            }

            if ($request->get('cmd')==2) {

This code seems to be duplicated across your project.

                // turn on, only by pi

                $changeSet = ['state'=>'on'];
                /** @var Action $action */
                foreach ($actions as $action) {
                    if ($action->getArguments()=='{"state":"on"}') {
                        $resultAction = $action;
                        break;
                    }
                }
            }

            if (($changeSet['state'] == 'off') && !isset($changeSet['percent'])) {

This code seems to be duplicated across your project.

                $changeSet['percent'] = 0;
            }

            if (($changeSet['state'] == 'on') && !isset($changeSet['percent'])) {

This code seems to be duplicated across your project.

                $changeSet['percent'] = 100;  // ? I don't really know if they restore their states
            }

            if (!$resultAction) {
                return $this->sendResponse(true, ['message'=>'State was changed, but no action was found']);
            }

            $this->get('actions')->executeVirtual($resultAction, $this->channelMap[$channel]['source'], $changeSet);

            $this->getDoctrine()->getManager()->flush();

            return $this->sendResponse(
                true,
                [
                    'message'=>'Executed successfully',
                    'device'=>$device->getAlias(),
                    'changeset'=>$changeSet
                ]
            );
        } else {
            return $this->sendResponse(false, ['message'=>'Requested channel does not exist']);
        }
    }

    /**
     * @param $success
     * @param array $resp
     * @return Response
     */
    public function sendResponse($success, array $resp)

This method seems to be duplicated in your project.

    {
        $response = new Response();
        $response->setContent(json_encode(array(
            'result' => $success ? 'ok' : 'fail',
            'response'=> $resp,
        )));
        $response->headers->set('Content-Type', 'application/json');
        return $response;
    }
}