Service::set() - Code Metrics - Inspection of "+ Remove varHooks, in respect to triggers" - chrl/myhome - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e09e3d...82203b )

by Kirill

created 2017-03-13 21:35 UTC

Service::set() B

↳ Parent: Service

Complexity

Conditions	7
Paths	9

Size

Total Lines	52
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes	6
Bugs	1	Features	2

Metric	Value
dl	0
loc	52
ccs	0
cts	36
cp	0
rs	7.2396
c	6
b	1
f	2
cc	7
eloc	28
nc	9
nop	2
crap	56

How to fix Long Method

<?php

namespace AppBundle\Variable;

use AppBundle\Action\Executor\ExecutorInterface;
use AppBundle\Entity\Variable;
use AppBundle\Entity\VariableHistory;
use AppBundle\Variable\Parser\ParserInterface;
use Doctrine\Bundle\DoctrineBundle\Registry;
use Doctrine\ORM\EntityManager;
use Symfony\Component\Config\Definition\Exception\Exception;

class Service
{

    private $doctrine;
    private $needSync = false;
    private $syncHost;
    private $actionService;

    public function __construct(Registry $doctrine, \AppBundle\Action\Service $actionService, $needSync, $syncHost)
    {
        $this->doctrine = $doctrine;
        $this->needSync = $needSync;
        $this->syncHost = $syncHost;
        $this->actionService = $actionService;
    }

    private function getDoctrine()
    {
        return $this->doctrine;
    }

    public function get($varName)
    {
        $vars = $this->getDoctrine()->getRepository('AppBundle:Variable');

        /** @var Variable $var */
        $var = $vars->findOneBy(['name'=>$varName]);
        if (!$var) {
            throw new Exception('Variable '.$varName.' not found');
        }
        return $var;
    }

    public function set($varName, $value)
    {
        $vars = $this->getDoctrine()->getRepository('AppBundle:Variable');

        /** @var Variable $var */
        $var = $vars->findOneBy(['name'=>$varName]);
        if (!$var) {
            throw new Exception('Variable '.$varName.' not found');
        }

        $parser = 'AppBundle\Variable\Parser\\'.ucfirst($var->getParser());

        if (!class_exists($parser)) {
            throw new Exception('Unknown parser: '.$parser);
        }

        /** @var ParserInterface $parser */
        $parser = new $parser();

        $value = $parser->parse($value);

        if (!$value) {
            return false;
        }

        if ($this->needSync) {
            if ($var->needSync) {
                @file_get_contents($this->syncHost.'set/'.$varName.'?value='.$value);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
        }

        $var->setValue($value);
        $var->setLaststatus(200);
        $var->setLastupdate(new \DateTime());

        $this->getDoctrine()->getManagerForClass('AppBundle:Variable')->persist($var);

        if ($var->needHistory) {
            $state = new VariableHistory();
            $state->setVar($var);
            $state->setTime(new \DateTime());
            $state->setValue($value);

            $this->getDoctrine()->getManagerForClass('AppBundle:VariableHistory')->persist($state);
            $this->getDoctrine()->getManagerForClass('AppBundle:VariableHistory')->flush();
        }

        $this->getDoctrine()->getManagerForClass('AppBundle:Variable')->flush();


        return $value;
    }

    /**
     * @param Variable $variable
     * @return array
     */
    public function getDayHistory(Variable $variable)
    {
        /** @var EntityManager $em */
        $em = $this->getDoctrine()->getManager();

        $q = $em->createQueryBuilder();
        $res = $q->
            select('AVG(vh.value) as av')->
            addSelect('DATE_FORMAT(vh.time,\'%Y-%m-%d %H:00\') as df')->
            from('AppBundle:VariableHistory', 'vh')->
            where('vh.time >= :date')->
            setParameter('date', new \DateTime('-48 hour'))->
            andWhere('vh.var = :var_id')->
            setParameter('var_id', $variable->getId())->
            groupBy('df')->
            orderBy('df', 'asc')->
            getQuery();

        return $res->getArrayResult();
    }

    /**
     * @param Variable $variable
     * @return array
     */
    public function getLastValue(Variable $variable)
    {
        /** @var EntityManager $em */
        $em = $this->getDoctrine()->getManager();

        $q = $em->createQueryBuilder();
        $res = $q->
        select('vh.value as av')->
        addSelect('vh.time as df')->
        from('AppBundle:VariableHistory', 'vh')->
        where('vh.var = :var_id')->
        setParameter('var_id', $variable->getId())->
        orderBy('df', 'desc')->
        setMaxResults(1)->
        getQuery();

        return $res->getSingleResult();
    }
}


1			<?php
2
3			namespace AppBundle\Variable;
4
5			use AppBundle\Action\Executor\ExecutorInterface;
6			use AppBundle\Entity\Variable;
7			use AppBundle\Entity\VariableHistory;
8			use AppBundle\Variable\Parser\ParserInterface;
9			use Doctrine\Bundle\DoctrineBundle\Registry;
10			use Doctrine\ORM\EntityManager;
11			use Symfony\Component\Config\Definition\Exception\Exception;
12
13			class Service
14			{
15
16			private $doctrine;
17			private $needSync = false;
18			private $syncHost;
19			private $actionService;
20
21			public function __construct(Registry $doctrine, \AppBundle\Action\Service $actionService, $needSync, $syncHost)
22			{
23			$this->doctrine = $doctrine;
24			$this->needSync = $needSync;
25			$this->syncHost = $syncHost;
26			$this->actionService = $actionService;
27			}
28
29			private function getDoctrine()
30			{
31			return $this->doctrine;
32			}
33
34			public function get($varName)
35			{
36			$vars = $this->getDoctrine()->getRepository('AppBundle:Variable');
37
38			/** @var Variable $var */
39			$var = $vars->findOneBy(['name'=>$varName]);
40			if (!$var) {
41			throw new Exception('Variable '.$varName.' not found');
42			}
43			return $var;
44			}
45
46			public function set($varName, $value)
47			{
48			$vars = $this->getDoctrine()->getRepository('AppBundle:Variable');
49
50			/** @var Variable $var */
51			$var = $vars->findOneBy(['name'=>$varName]);
52			if (!$var) {
53			throw new Exception('Variable '.$varName.' not found');
54			}
55
56			$parser = 'AppBundle\Variable\Parser\\'.ucfirst($var->getParser());
57
58			if (!class_exists($parser)) {
59			throw new Exception('Unknown parser: '.$parser);
60			}
61
62			/** @var ParserInterface $parser */
63			$parser = new $parser();
64
65			$value = $parser->parse($value);
66
67			if (!$value) {
68			return false;
69			}
70
71			if ($this->needSync) {
72			if ($var->needSync) {
73			@file_get_contents($this->syncHost.'set/'.$varName.'?value='.$value);
			0 ignored issues – show Security Best Practice introduced 2017-02-21 22:46 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
74			}
75			}
76
77			$var->setValue($value);
78			$var->setLaststatus(200);
79			$var->setLastupdate(new \DateTime());
80
81			$this->getDoctrine()->getManagerForClass('AppBundle:Variable')->persist($var);
82
83			if ($var->needHistory) {
84			$state = new VariableHistory();
85			$state->setVar($var);
86			$state->setTime(new \DateTime());
87			$state->setValue($value);
88
89			$this->getDoctrine()->getManagerForClass('AppBundle:VariableHistory')->persist($state);
90			$this->getDoctrine()->getManagerForClass('AppBundle:VariableHistory')->flush();
91			}
92
93			$this->getDoctrine()->getManagerForClass('AppBundle:Variable')->flush();
94
95
96			return $value;
97			}
98
99			/**
100			* @param Variable $variable
101			* @return array
102			*/
103			public function getDayHistory(Variable $variable)
104			{
105			/** @var EntityManager $em */
106			$em = $this->getDoctrine()->getManager();
107
108			$q = $em->createQueryBuilder();
109			$res = $q->
110			select('AVG(vh.value) as av')->
111			addSelect('DATE_FORMAT(vh.time,\'%Y-%m-%d %H:00\') as df')->
112			from('AppBundle:VariableHistory', 'vh')->
113			where('vh.time >= :date')->
114			setParameter('date', new \DateTime('-48 hour'))->
115			andWhere('vh.var = :var_id')->
116			setParameter('var_id', $variable->getId())->
117			groupBy('df')->
118			orderBy('df', 'asc')->
119			getQuery();
120
121			return $res->getArrayResult();
122			}
123
124			/**
125			* @param Variable $variable
126			* @return array
127			*/
128			public function getLastValue(Variable $variable)
129			{
130			/** @var EntityManager $em */
131			$em = $this->getDoctrine()->getManager();
132
133			$q = $em->createQueryBuilder();
134			$res = $q->
135			select('vh.value as av')->
136			addSelect('vh.time as df')->
137			from('AppBundle:VariableHistory', 'vh')->
138			where('vh.var = :var_id')->
139			setParameter('var_id', $variable->getId())->
140			orderBy('df', 'desc')->
141			setMaxResults(1)->
142			getQuery();
143
144			return $res->getSingleResult();
145			}
146			}
147

chrl / myhome

Push — master ( e09e3d...82203b )

Service::set() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like