View GitHub Repository buktopuha

Schedule Inspection
Subscribe
Completed
Push — master ( 6d1e94...2cd5f8 )
by Kirill
02:09
created

NextAction::run()   A

↳ Parent: NextAction

Complexity

Conditions 1
Paths 1

Size

Total Lines 13
Code Lines 9

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 13
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 9
nc 1
nop 2
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Chrl\AppBundle\GameAction;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
class NextAction extends BaseGameAction implements GameActionInterface

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
{

            


            
                                                        
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
    public function run($message, $user)

            


            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
		$game = $this->gameService->findGame($game);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The variable $game seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This error can happen if you refactor code and forget to move the variable
initialization.


Let’s take a look at a simple example:


function someFunction() {
    $x = 5;
    echo $x;
}





The above code is perfectly fine. Now imagine that we re-order the statements:


function someFunction() {
    echo $x;
    $x = 5;
}





In that case, $x would be read before it is initialized. This was a very
basic example, however the principle is the same for the found issue.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
		$this->botApi->sendMessage(

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
			$game->chatId,

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
			'Ok, changing question.',

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
			'markdown'

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
		);

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
		$this->gameService->em->persist($game);

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
		$this->gameService->em->flush();

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
		$this->gameService->askQuestion($game);

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    21