UpdateReceiver::handleUpdate() - Code Metrics - Inspection of "+ Switch to own UpdateReceiver" - chrl/buktopuha - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8e6a11...bb5baa )

by Kirill

created 2016-10-12 08:40 UTC

UpdateReceiver::handleUpdate() B

↳ Parent: UpdateReceiver

Complexity

Conditions	5
Paths	5

Size

Total Lines	20
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	15
nc	5
nop	1

<?php

namespace AppBundle\UpdateReceiver;

use Shaygan\TelegramBotApiBundle\TelegramBotApi;
use Shaygan\TelegramBotApiBundle\Type\Update;
use Shaygan\TelegramBotApiBundle\UpdateReceiver\UpdateReceiverInterface;


class UpdateReceiver implements UpdateReceiverInterface
{

	private $config;
	private $telegramBotApi;

	public function __construct(TelegramBotApi $telegramBotApi, $config)
	{
		$this->telegramBotApi = $telegramBotApi;
		$this->config = $config;
	}

	public function handleUpdate(Update $update)
	{
		$message = json_decode(json_encode($update->message), true);

		switch ($message['text']) {
			case "/about":
			case "/about@{$this->config['bot_name']}":
				$text = "I'm a Buktopuha Telegram Bot";
				break;
			case "/help":
			case "/help@{$this->config['bot_name']}":
			default :
switch ($expr) {
    default : //wrong
        doSomething();
        break;
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
				$text = "Command List:\n";
				$text .= "/about - About this bot\n";
				$text .= "/help - show this help message\n";
				break;
		}

		$this->telegramBotApi->sendMessage($message['chat']['id'], $text);
	}
}


1			<?php
2
3			namespace AppBundle\UpdateReceiver;
4
5			use Shaygan\TelegramBotApiBundle\TelegramBotApi;
6			use Shaygan\TelegramBotApiBundle\Type\Update;
7			use Shaygan\TelegramBotApiBundle\UpdateReceiver\UpdateReceiverInterface;
8
9
10			class UpdateReceiver implements UpdateReceiverInterface
11			{
12
13			private $config;
14			private $telegramBotApi;
15
16			public function __construct(TelegramBotApi $telegramBotApi, $config)
17			{
18			$this->telegramBotApi = $telegramBotApi;
19			$this->config = $config;
20			}
21
22			public function handleUpdate(Update $update)
23			{
24			$message = json_decode(json_encode($update->message), true);
25
26			switch ($message['text']) {
27			case "/about":
28			case "/about@{$this->config['bot_name']}":
29			$text = "I'm a Buktopuha Telegram Bot";
30			break;
31			case "/help":
32			case "/help@{$this->config['bot_name']}":
33			default :
			0 ignored issues – show Coding Style introduced 2016-10-12 08:42 UTC by Report Bug Copy Issue Report There must be no space before the colon in a DEFAULT statement As per the PSR-2 coding standard, there must not be a space in front of the colon in the default statement. switch ($expr) { default : //wrong doSomething(); break; } switch ($expr) { default: //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
34			$text = "Command List:\n";
35			$text .= "/about - About this bot\n";
36			$text .= "/help - show this help message\n";
37			break;
38			}
39
40			$this->telegramBotApi->sendMessage($message['chat']['id'], $text);
41			}
42			}
43

chrl / buktopuha

Push — master ( 8e6a11...bb5baa )

UpdateReceiver::handleUpdate() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like