Uri::dump() - Code Metrics - Inspection of "Merge pull request #19 from chrisyue/feature/2.0" - chrisyue/php-m3u8 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( f101a1...f94113 )

by Chris

created 2017-06-24 18:53 UTC

Uri::dump() A

↳ Parent: Uri

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

/*
 * This file is part of the PhpM3u8 package.
 *
 * (c) Chrisyue <http://chrisyue.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Chrisyue\PhpM3u8;

class Uri implements DumpableInterface
{
    private $uri;

    public function readLines(array &$lines)

    {
        foreach ($lines as $key => $line) {
            if (0 !== strpos($line, '#')) {
                $this->uri = $line;

                unset($lines[$key]);

                return;
            }
        }
    }

    public function setUri($uri)
    {
        $this->uri = $uri;

        return $this;
    }

    public function __toString()
    {
        return $this->dump();
    }

    public function dump()
    {
        return $this->uri;
    }

    public function isEmpty()
    {
        return empty($this->uri);
    }
}


1			<?php
2
3			/*
4			* This file is part of the PhpM3u8 package.
5			*
6			* (c) Chrisyue <http://chrisyue.com/>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Chrisyue\PhpM3u8;
13
14			class Uri implements DumpableInterface
15			{
16			private $uri;
17
18	1	View Code Duplication	public function readLines(array &$lines)
			0 ignored issues – show Duplication introduced 2017-06-24 17:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19			{
20	1		foreach ($lines as $key => $line) {
21	1		if (0 !== strpos($line, '#')) {
22	1		$this->uri = $line;
23
24	1		unset($lines[$key]);
25
26	1		return;
27			}
28	1		}
29	1		}
30
31	1		public function setUri($uri)
32			{
33	1		$this->uri = $uri;
34
35	1		return $this;
36			}
37
38	1		public function __toString()
39			{
40	1		return $this->dump();
41			}
42
43	2		public function dump()
44			{
45	2		return $this->uri;
46			}
47
48	1		public function isEmpty()
49			{
50	1		return empty($this->uri);
51			}
52			}
53

chrisyue / php-m3u8

Push — develop ( f101a1...f94113 )

Uri::dump() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like