Chrisyue\PhpM3u8\Parser\UriAwareAttrTagParser

Complexity

Total Complexity

4

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	parse()	0	8	1
A	supports()	0	4	1
A	isRepeatable()	0	4	1

<?php

namespace Chrisyue\PhpM3u8\Parser;

use Chrisyue\PhpM3u8\Line\LinesInterface;
use Chrisyue\PhpM3u8\Line\LineInterface;
use Chrisyue\PhpM3u8\Transformer\AttrListTransformer;

class UriAwareAttrTagParser extends TagParser
{
    private $uriParser;

    private $dataAccessor;

    public function __construct(
        LineInterface $line,
        AttrListTransformer $transformer = null,
        ChildParserInterface $uriParser,
        $repeatable = false
    ) {
        parent::__construct($line, $transformer, $repeatable);

        $this->uriParser = $uriParser;
        $this->dataAccessor = $transformer->getDataAccessor();

It seems like $transformer is not always an object, but can also be of type null. Maybe add an additional type check?

    }

    public function parse(LinesInterface $lines)
    {
        parent::parse($lines);
        $lines->goNext();
        $this->dataAccessor->set('uri', $this->uriParser->parse($lines));

        return $this->dataAccessor->getData();
    }

    public function supports(LineInterface $line)
    {
        return parent::supports($line);
    }

    public function isRepeatable()
    {
        return true;
    }
}