AbstractAnnotationReadable::initResult() - Code Metrics - Inspection of "Feature/3.0" - chrisyue/php-m3u8 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#27)

by Chris

created 2018-03-18 11:28 UTC

AbstractAnnotationReadable::initResult() A

↳ Parent: AbstractAnnotationReadable

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Chrisyue\PhpM3u8\M3u8\Core;

use Chrisyue\PhpM3u8\Stream\StreamInterface;
use Chrisyue\PhpM3u8\M3u8\M3u8Interface;
use Chrisyue\PhpM3u8\ReaderAwareInterface;
use Chrisyue\PhpM3u8\M3u8\OptionsTrait;

abstract class AbstractAnnotationReadable extends AbstractParentCore
{
    use OptionsTrait;

    private $cores;

    protected function getCores()
    {
        if (null === $this->cores) {
            $this->cores = $this->options['reader']->read($this->options['class'], ChildCoreInterface::class);
            uasort($this->cores, function(ChildCoreInterface $core, ChildCoreInterface $core2) {
                return $core->getSequence() > $core2->getSequence();
            });
        }

        return $this->cores;
    }

    protected function initResult()
    {
        return new $this->options['class'];
    }

    private function moveToNextLine()

    {
        $this->getStream()->next();

        return $this->getStream()->valid();
    }
}


1			<?php
2
3			namespace Chrisyue\PhpM3u8\M3u8\Core;
4
5			use Chrisyue\PhpM3u8\Stream\StreamInterface;
6			use Chrisyue\PhpM3u8\M3u8\M3u8Interface;
7			use Chrisyue\PhpM3u8\ReaderAwareInterface;
8			use Chrisyue\PhpM3u8\M3u8\OptionsTrait;
9
10			abstract class AbstractAnnotationReadable extends AbstractParentCore
11			{
12			use OptionsTrait;
13
14			private $cores;
15
16			protected function getCores()
17			{
18			if (null === $this->cores) {
19			$this->cores = $this->options['reader']->read($this->options['class'], ChildCoreInterface::class);
20			uasort($this->cores, function(ChildCoreInterface $core, ChildCoreInterface $core2) {
21			return $core->getSequence() > $core2->getSequence();
22			});
23			}
24
25			return $this->cores;
26			}
27
28			protected function initResult()
29			{
30			return new $this->options['class'];
31			}
32
33			private function moveToNextLine()
			0 ignored issues – show Bug introduced 2018-03-18 11:39 UTC by Report Bug Copy Issue Report Consider using a different method name as you override a private method of the parent class. Overwriting private methods is generally fine as long as you also use private visibility. It might still be preferable for understandability to use a different method name. Loading history... Unused Code introduced 2018-03-18 11:39 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
34			{
35			$this->getStream()->next();
36
37			return $this->getStream()->valid();
38			}
39			}
40

chrisyue / php-m3u8

Pull Request — develop (#27)

AbstractAnnotationReadable::initResult() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like