AutoJsonResponseListener::onKernelView() - Code Metrics - chrisyue/auto-json-response-bundle - Measure and Improve Code Quality continuously with Scrutinizer

AutoJsonResponseListener::onKernelView() C
last analyzed 2016-05-11 07:55 UTC

↳ Parent: AutoJsonResponseListener

Complexity

Conditions	7
Paths	8

Size

Total Lines	38
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	24
CRAP Score	7

Importance

Changes	4
Bugs	0	Features	2

Metric	Value
c	4
b	0
f	2
dl	0
loc	38
ccs	24
cts	24
cp	1
rs	6.7272
cc	7
eloc	20
nc	8
nop	1
crap	7

<?php

/*
 * This file is part of the ChrisyueAutoJsonResponseBundle package.
 *
 * (c) Chrisyue <http://chrisyue.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Chrisyue\Bundle\AutoJsonResponseBundle\EventListener;

use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent;
use Symfony\Component\Serializer\Serializer;

class AutoJsonResponseListener
{
    private $serializer;
    private $options;

    public function __construct(Serializer $serializer = null, array $options = [])
    {
        $this->serializer = $serializer;
        $this->options = $options;
    }

    public function onKernelView(GetResponseForControllerResultEvent $event)
    {
        if (!$event->isMasterRequest()) {
            return;
        }

        $request = $event->getRequest();
        if ('json' !== $request->getRequestFormat()) {
            return;
        }

        $result = $event->getControllerResult();
        if (null === $result) {
            $event->setResponse(new JsonResponse(null, 204));

            return;
        }

        if ($result instanceof Response) {
            return;
        }

        $response = new JsonResponse();

        if ($request->isMethod('POST')) {
            $response->setStatusCode(201);
        }

        if (!is_scalar($result)) {
            $result = $this->getSerializer()->normalize($result, null, [
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                'groups' => $this->options['serialization_default_groups'],
            ]);
        }

        $response->setData($result);

        $event->setResponse($response);
    }

    private function getSerializer()
    {
        if (null === $this->serializer) {
            throw new \BadMethodCallException('You should enable `serializer` in `config.yml` to get this work');
        }

        return $this->serializer;
    }
}


1		<?php
2
3		/*
4		* This file is part of the ChrisyueAutoJsonResponseBundle package.
5		*
6		* (c) Chrisyue <http://chrisyue.com/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Chrisyue\Bundle\AutoJsonResponseBundle\EventListener;
13
14		use Symfony\Component\HttpFoundation\JsonResponse;
15		use Symfony\Component\HttpFoundation\Response;
16		use Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent;
17		use Symfony\Component\Serializer\Serializer;
18
19		class AutoJsonResponseListener
20		{
21		private $serializer;
22		private $options;
23
24	9	public function __construct(Serializer $serializer = null, array $options = [])
25		{
26	9	$this->serializer = $serializer;
27	9	$this->options = $options;
28	9	}
29
30	9	public function onKernelView(GetResponseForControllerResultEvent $event)
31		{
32	9	if (!$event->isMasterRequest()) {
33	1	return;
34		}
35
36	8	$request = $event->getRequest();
37	8	if ('json' !== $request->getRequestFormat()) {
38	1	return;
39		}
40
41	7	$result = $event->getControllerResult();
42	7	if (null === $result) {
43	1	$event->setResponse(new JsonResponse(null, 204));
44
45	1	return;
46		}
47
48	6	if ($result instanceof Response) {
49	1	return;
50		}
51
52	5	$response = new JsonResponse();
53
54	5	if ($request->isMethod('POST')) {
55	2	$response->setStatusCode(201);
56	2	}
57
58	5	if (!is_scalar($result)) {
59	3	$result = $this->getSerializer()->normalize($result, null, [
		0 ignored issues – show Bug introduced 2016-04-08 14:24 UTC by Report Bug Copy Issue Report It seems like `$result` defined by `$this->getSerializer()->...tion_default_groups']))` on line `59` can also be of type `array` or `null`; however, `Symfony\Component\Serial...Serializer::normalize()` does only seem to accept `object`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
60	2	'groups' => $this->options['serialization_default_groups'],
61	2	]);
62	2	}
63
64	4	$response->setData($result);
65
66	4	$event->setResponse($response);
67	4	}
68
69	3	private function getSerializer()
70		{
71	3	if (null === $this->serializer) {
72	1	throw new \BadMethodCallException('You should enable `serializer` in `config.yml` to get this work');
73		}
74
75	2	return $this->serializer;
76		}
77		}
78

chrisyue / auto-json-response-bundle

AutoJsonResponseListener::onKernelView() C last analyzed 2016-05-11 07:55 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

AutoJsonResponseListener::onKernelView() C
last analyzed 2016-05-11 07:55 UTC