Chrisyue\Bundle\AutoJsonResponseBundle\Tests\EventListener\AutoJsonResponseListenerTest

Complexity

Total Complexity

18

Size/Duplication

Total Lines	125
Duplicated Lines	17.6 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	0	Features	1

12 Methods

Rating	Name	Duplication	Size	Complexity
A	testOnKernelViewWithNonMasterRequest()	0	6	1
A	testOnKernelViewWithNonJsonRequest()	0	6	1
A	testOnKernelViewWithNullControllerResult()	0	7	1
A	testOnKernelViewWithResponseControllerResult()	0	6	1
A	testOnKernelViewWithObjectControllerResultButNoSerializer()	0	7	1
A	testOnKernelViewWithObjectControllerResult()	11	11	1
A	testOnKernelViewWithPostRequestAndObjectControllerResult()	11	11	1
B	prophesizeEvent()	0	26	6
A	doTest()	0	5	2
A	prophesizeSerializer()	0	7	1
A	testOnKernelViewWithScalarControllerResult()	0	8	1
A	testOnKernelViewWithPostRequestAndNonObjectControllerResult()	0	8	1

<?php

/*
 * This file is part of the ChrisyueAutoJsonResponseBundle package.
 *
 * (c) Chrisyue <http://chrisyue.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Chrisyue\Bundle\AutoJsonResponseBundle\Tests\EventListener;

use Chrisyue\Bundle\AutoJsonResponseBundle\EventListener\AutoJsonResponseListener;
use Prophecy\Prophecy\ObjectProphecy;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent;
use Symfony\Component\Serializer\Serializer;

class AutoJsonResponseListenerTest extends \PHPUnit_Framework_TestCase
{
    public function testOnKernelViewWithNonMasterRequest()
    {
        $event = $this->prophesizeEvent(false);

        $this->doTest($event);
    }

    public function testOnKernelViewWithNonJsonRequest()
    {
        $event = $this->prophesizeEvent(true);

        $this->doTest($event);
    }

    public function testOnKernelViewWithNullControllerResult()
    {
        $event = $this->prophesizeEvent(true, true, null);
        $event->setResponse(new JsonResponse(null, 204))->shouldBeCalledTimes(1);

        $this->doTest($event);
    }

    public function testOnKernelViewWithResponseControllerResult()
    {
        $event = $this->prophesizeEvent(true, true, new JsonResponse());

        $this->doTest($event);
    }

    public function testOnKernelViewWithScalarControllerResult()
    {
        $nonObject = 'foo';
        $event = $this->prophesizeEvent(true, true, $nonObject);
        $event->setResponse(new JsonResponse($nonObject))->shouldBeCalledTimes(1);

        $this->doTest($event);
    }

    public function testOnKernelViewWithPostRequestAndNonObjectControllerResult()
    {
        $nonObject = 'hello world';
        $event = $this->prophesizeEvent(true, true, $nonObject, true);
        $event->setResponse(new JsonResponse($nonObject, 201))->shouldBeCalledTimes(1);

        $this->doTest($event);
    }

    /**
     * @expectedException BadMethodCallException
     */
    public function testOnKernelViewWithObjectControllerResultButNoSerializer()
    {
        $object = new \stdClass();
        $event = $this->prophesizeEvent(true, true, $object);

        $this->doTest($event);
    }

    public function testOnKernelViewWithObjectControllerResult()

This method seems to be duplicated in your project.

    {
        $object = new \stdClass();
        $event = $this->prophesizeEvent(true, true, $object);

        $normalized = ['foo' => 'bar'];
        $serializer = $this->prophesizeSerializer($object, $normalized);
        $event->setResponse(new JsonResponse($normalized))->shouldBeCalledTimes(1);

        $this->doTest($event, $serializer);
    }

    public function testOnKernelViewWithPostRequestAndObjectControllerResult()

This method seems to be duplicated in your project.

    {
        $object = new \stdClass();
        $event = $this->prophesizeEvent(true, true, $object, true);

        $normalized = ['bar' => 'foo'];
        $serializer = $this->prophesizeSerializer($object, $normalized);
        $event->setResponse(new JsonResponse($normalized, 201))->shouldBeCalledTimes(1);

        $this->doTest($event, $serializer);
    }

    private function prophesizeEvent($isMasterRequest, $isRequestJson = false, $controllerResult = null, $isMethodPost = false)
    {
        $event = $this->prophesize(GetResponseForControllerResultEvent::class);
        $event->isMasterRequest()->shouldBeCalledTimes(1)->willReturn($isMasterRequest);

        if (!$isMasterRequest) {
            return $event;
        }

        $request = $this->prophesize(Request::class);
        $request->getRequestFormat()->shouldBeCalledTimes(1)->willReturn($isRequestJson ? 'json' : '!json');
        $event->getRequest()->shouldBeCalledTimes(1)->willReturn($request->reveal());

        if (!$isRequestJson) {
            return $event;
        }

        $event->getControllerResult()->shouldBeCalledTimes(1)->willReturn($controllerResult);
        if ($controllerResult instanceof Response || null === $controllerResult) {
            return $event;
        }

        $request->isMethod('POST')->shouldBeCalledTimes(1)->willReturn($isMethodPost);

        return $event;
    }

    private function doTest(ObjectProphecy $event, ObjectProphecy $serializer = null)
    {
        $listener = new AutoJsonResponseListener(null === $serializer ? null : $serializer->reveal(), ['serialization_default_groups' => null]);
        $listener->onKernelView($event->reveal());
    }

    private function prophesizeSerializer(\stdClass $object, array $normalized)
    {
        $serializer = $this->prophesize(Serializer::class);
        $serializer->normalize($object, null, ['groups' => null])->shouldBeCalledTimes(1)->willReturn($normalized);

        return $serializer;
    }
}