Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class FrontRenderTest extends \PHPUnit_Framework_TestCase |
||
16 | { |
||
17 | /** |
||
18 | * @var string TEMPLATE |
||
19 | */ |
||
20 | const TEMPLATE = 'index.html.twig'; |
||
21 | |||
22 | /** |
||
23 | * @var string FAILED_TEMPLATE |
||
24 | */ |
||
25 | const FAILED_TEMPLATE = 'failed.html.twig'; |
||
26 | |||
27 | /** |
||
28 | * @var string FAILED_PATH |
||
29 | */ |
||
30 | const FAILED_PATH = 'failedPath.html.twig'; |
||
31 | |||
32 | /** |
||
33 | * @var EventDispatcher $eventDispatcher |
||
34 | */ |
||
35 | protected $eventDispatcher; |
||
36 | |||
37 | /** |
||
38 | * @var \Twig_Loader_Filesystem $twigLoader |
||
39 | */ |
||
40 | protected $twigLoader; |
||
41 | |||
42 | /** |
||
43 | * @var \Twig_Environment $twigEnvironment |
||
44 | */ |
||
45 | protected $twigEnvironment; |
||
46 | |||
47 | /** |
||
48 | * @var TwigListener $twigListener |
||
49 | */ |
||
50 | protected $twigListener; |
||
51 | |||
52 | /** |
||
53 | * @var TemplateNameParser $templateNameParser |
||
54 | */ |
||
55 | protected $templateNameParser; |
||
56 | |||
57 | /** |
||
58 | * @var FileLocator $fileLocator |
||
59 | */ |
||
60 | protected $fileLocator; |
||
61 | |||
62 | /** |
||
63 | * @var TwigEngine $engine |
||
64 | */ |
||
65 | protected $engine; |
||
66 | |||
67 | /** |
||
68 | * @var FrontRender $frontRender |
||
69 | */ |
||
70 | protected $frontRender; |
||
71 | |||
72 | /** |
||
73 | * Set up the front render test |
||
74 | */ |
||
75 | public function setUp() |
||
91 | |||
92 | /** |
||
93 | * Test render of the template with parameter |
||
94 | */ |
||
95 | View Code Duplication | public function testTemplateRenderWithParameter() |
|
112 | |||
113 | /** |
||
114 | * Test render of the template without parameter |
||
115 | */ |
||
116 | View Code Duplication | public function testTemplateRenderWithoutParameter() |
|
127 | |||
128 | /** |
||
129 | * Test on the update of lexer |
||
130 | * |
||
131 | * @dataProvider lexerTags |
||
132 | * |
||
133 | * @param $oldTags |
||
134 | * @param $newTags |
||
135 | */ |
||
136 | public function testSetLexer($oldTags, $newTags) |
||
160 | |||
161 | /** |
||
162 | * Test on the failed template |
||
163 | * |
||
164 | * @expectedException Twig_Error_Syntax |
||
165 | */ |
||
166 | public function testExceptionOnSyntax() |
||
172 | |||
173 | /** |
||
174 | * Test when the template doesn't exist |
||
175 | * |
||
176 | * @expectedException InvalidArgumentException |
||
177 | */ |
||
178 | public function testExceptionOnFailedPath() |
||
184 | |||
185 | /** |
||
186 | * Test when the template path is empty |
||
187 | * |
||
188 | * @expectedException Chris\Bundle\FrontRenderBundle\Exception\FrontRenderException |
||
189 | */ |
||
190 | public function testExceptionOnEmptyPath() |
||
196 | |||
197 | /** |
||
198 | * Provide the lexer tags |
||
199 | * |
||
200 | * @return array |
||
201 | */ |
||
202 | public function lexerTags() |
||
211 | |||
212 | |||
213 | } |
||
214 |
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: