SystemMailerTest::testSendWithoutDefaults() - Code Metrics - christoph-hautzinger/SystemMailBundle - Measure and Improve Code Quality continuously with Scrutinizer

SystemMailerTest::testSendWithoutDefaults() A
last analyzed 2018-01-12 20:40 UTC

↳ Parent: SystemMailerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0

<?php

namespace Hautzi\SystemMailBundle\Tests\SystemMailer;


use Hautzi\SystemMailBundle\SystemMailer\MailDefinition\ParserInterface;
use Hautzi\SystemMailBundle\SystemMailer\MailDefinition\ProviderInterface;
use Hautzi\SystemMailBundle\SystemMailer\Mailer\MailerInterface;
use Hautzi\SystemMailBundle\SystemMailer\ParsedMessage;
use Hautzi\SystemMailBundle\SystemMailer\SystemMailer;

class SystemMailerTest extends \PHPUnit_Framework_TestCase
{
    protected $fixture;

    /**
     * @var ProviderInterface
     */
    protected $provider;
    /**
     * @var ParserInterface
     */
    protected $parser;
    /**
     * @var MailerInterface
     */
    protected $mailer;


    public function testSendWithoutDefaults()
    {
        $fixture = $this->createFixture('de');

        $parsedMessage = $this->prophesize(ParsedMessage::class)->reveal();

        $this->provider->fetchMailDefinition('App:test', ['param1' => 'yay!'])->willReturn('<email></email>')->shouldBeCalled();

        $this->parser->parseMailDefinition('<email></email>', 'de')->willReturn($parsedMessage)->shouldBeCalled();

        $this->mailer->send($parsedMessage, null)->shouldBeCalled();

        $fixture->send('App:test', ['param1' => 'yay!']);
    }


    public function testSendDefaultsArePopulated()
    {
        $fixture = $this->createFixture('de', [
            'subject' => '_1',
            'replyTo' => '_2',
            'from' => [
                'email' => '_3',
                'name' => '_4',
            ],
            'to' => [
                'email' => '_5',
                'name' => '_6',
            ],
            'cc' => [
                'email' => '_7',
                'name' => '_8',
            ],
            'bcc' => [
                'email' => '_9',
                'name' => '_10',
            ]
        ]);

        $parsedMessage = $this->prophesize(ParsedMessage::class);
        $parsedMessage->getSubject()->willReturn(null);
        $parsedMessage->setSubject('_1')->shouldBeCalled();
        $parsedMessage->getReplyTo()->willReturn(null);
        $parsedMessage->setReplyTo('_2')->shouldBeCalled();
        $parsedMessage->getFrom()->willReturn([]);
        $parsedMessage->setFrom('_3', '_4')->shouldBeCalled();
        $parsedMessage->getTo()->willReturn([]);
        $parsedMessage->addTo('_5', '_6')->shouldBeCalled();
        $parsedMessage->getCc()->willReturn([]);
        $parsedMessage->addCc('_7', '_8')->shouldBeCalled();
        $parsedMessage->getBcc()->willReturn([]);
        $parsedMessage->addBcc('_9', '_10')->shouldBeCalled();

        $this->provider->fetchMailDefinition('App:test', ['param1' => 'yay!'])->willReturn('<email></email>')->shouldBeCalled();

        $this->parser->parseMailDefinition('<email></email>', 'de')->willReturn($parsedMessage)->shouldBeCalled();

        $this->mailer->send($parsedMessage, null)->shouldBeCalled();
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $fixture->send('App:test', ['param1' => 'yay!']);
    }


    /**
     * @param null  $locale
     * @param array $defaults
     *
     * @return SystemMailer
     */
    protected function createFixture($locale = null, $defaults = [])
    {
        $this->provider = $this->prophesize(ProviderInterface::class);

        $this->parser = $this->prophesize(ParserInterface::class);

        $this->mailer = $this->prophesize(MailerInterface::class);


        $defaults = $this->mergeDefaults($defaults);

        return new SystemMailer($this->provider->reveal(), $this->parser->reveal(), $this->mailer->reveal(), $locale, $defaults);
    }

    /**
     * @param array $defaults
     *
     * @return array
     */
    protected function mergeDefaults(array $defaults = [])
    {
        return array_replace_recursive([
            'subject' => '',
            'replyTo' => '',
            'from' => [
                'email' => '',
                'name' => '',
            ],
            'to' => [
                'email' => '',
                'name' => '',
            ],
            'cc' => [
                'email' => '',
                'name' => '',
            ],
            'bcc' => [
                'email' => '',
                'name' => '',
            ],
        ], $defaults);
    }
}


1			<?php
2
3			namespace Hautzi\SystemMailBundle\Tests\SystemMailer;
4
5
6			use Hautzi\SystemMailBundle\SystemMailer\MailDefinition\ParserInterface;
7			use Hautzi\SystemMailBundle\SystemMailer\MailDefinition\ProviderInterface;
8			use Hautzi\SystemMailBundle\SystemMailer\Mailer\MailerInterface;
9			use Hautzi\SystemMailBundle\SystemMailer\ParsedMessage;
10			use Hautzi\SystemMailBundle\SystemMailer\SystemMailer;
11
12			class SystemMailerTest extends \PHPUnit_Framework_TestCase
13			{
14			protected $fixture;
15
16			/**
17			* @var ProviderInterface
18			*/
19			protected $provider;
20			/**
21			* @var ParserInterface
22			*/
23			protected $parser;
24			/**
25			* @var MailerInterface
26			*/
27			protected $mailer;
28
29
30			public function testSendWithoutDefaults()
31			{
32			$fixture = $this->createFixture('de');
33
34			$parsedMessage = $this->prophesize(ParsedMessage::class)->reveal();
35
36			$this->provider->fetchMailDefinition('App:test', ['param1' => 'yay!'])->willReturn('<email></email>')->shouldBeCalled();
			0 ignored issues – show Bug introduced 2015-12-01 16:41 UTC by Report Bug Copy Issue Report The method `willReturn` cannot be called on `$this->provider->fetchMa...ay('param1' => 'yay!'))` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
37			$this->parser->parseMailDefinition('<email></email>', 'de')->willReturn($parsedMessage)->shouldBeCalled();
			0 ignored issues – show Bug introduced 2015-12-01 16:41 UTC by Report Bug Copy Issue Report The method `willReturn()` does not seem to exist on `object<Hautzi\SystemMail...emMailer\ParsedMessage>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
38			$this->mailer->send($parsedMessage, null)->shouldBeCalled();
39
40			$fixture->send('App:test', ['param1' => 'yay!']);
41			}
42
43
44			public function testSendDefaultsArePopulated()
45			{
46			$fixture = $this->createFixture('de', [
47			'subject' => '_1',
48			'replyTo' => '_2',
49			'from' => [
50			'email' => '_3',
51			'name' => '_4',
52			],
53			'to' => [
54			'email' => '_5',
55			'name' => '_6',
56			],
57			'cc' => [
58			'email' => '_7',
59			'name' => '_8',
60			],
61			'bcc' => [
62			'email' => '_9',
63			'name' => '_10',
64			]
65			]);
66
67			$parsedMessage = $this->prophesize(ParsedMessage::class);
68			$parsedMessage->getSubject()->willReturn(null);
69			$parsedMessage->setSubject('_1')->shouldBeCalled();
70			$parsedMessage->getReplyTo()->willReturn(null);
71			$parsedMessage->setReplyTo('_2')->shouldBeCalled();
72			$parsedMessage->getFrom()->willReturn([]);
73			$parsedMessage->setFrom('_3', '_4')->shouldBeCalled();
74			$parsedMessage->getTo()->willReturn([]);
75			$parsedMessage->addTo('_5', '_6')->shouldBeCalled();
76			$parsedMessage->getCc()->willReturn([]);
77			$parsedMessage->addCc('_7', '_8')->shouldBeCalled();
78			$parsedMessage->getBcc()->willReturn([]);
79			$parsedMessage->addBcc('_9', '_10')->shouldBeCalled();
80
81			$this->provider->fetchMailDefinition('App:test', ['param1' => 'yay!'])->willReturn('<email></email>')->shouldBeCalled();
			0 ignored issues – show Bug introduced 2015-12-01 16:41 UTC by Report Bug Copy Issue Report The method `willReturn` cannot be called on `$this->provider->fetchMa...ay('param1' => 'yay!'))` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
82			$this->parser->parseMailDefinition('<email></email>', 'de')->willReturn($parsedMessage)->shouldBeCalled();
			0 ignored issues – show Bug introduced 2015-12-01 16:41 UTC by Report Bug Copy Issue Report The method `willReturn()` does not seem to exist on `object<Hautzi\SystemMail...emMailer\ParsedMessage>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
83			$this->mailer->send($parsedMessage, null)->shouldBeCalled();
			0 ignored issues – show Documentation introduced 2015-12-01 16:41 UTC by Report Bug Copy Issue Report `$parsedMessage` is of type `object<Prophecy\Prophecy\ObjectProphecy>`, but the function expects a `object<Hautzi\SystemMail...emMailer\ParsedMessage>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
84
85			$fixture->send('App:test', ['param1' => 'yay!']);
86			}
87
88
89			/**
90			* @param null $locale
91			* @param array $defaults
92			*
93			* @return SystemMailer
94			*/
95			protected function createFixture($locale = null, $defaults = [])
96			{
97			$this->provider = $this->prophesize(ProviderInterface::class);
			0 ignored issues – show Documentation Bug introduced 2015-12-01 16:41 UTC by Report Bug Copy Issue Report It seems like `$this->prophesize(\Hautz...oviderInterface::class)` of type `object<Prophecy\Prophecy\ObjectProphecy>` is incompatible with the declared type `object<Hautzi\SystemMail...tion\ProviderInterface>` of property `$provider`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
98			$this->parser = $this->prophesize(ParserInterface::class);
			0 ignored issues – show Documentation Bug introduced 2015-12-01 16:41 UTC by Report Bug Copy Issue Report It seems like `$this->prophesize(\Hautz...ParserInterface::class)` of type `object<Prophecy\Prophecy\ObjectProphecy>` is incompatible with the declared type `object<Hautzi\SystemMail...nition\ParserInterface>` of property `$parser`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
99			$this->mailer = $this->prophesize(MailerInterface::class);
			0 ignored issues – show Documentation Bug introduced 2015-12-01 16:41 UTC by Report Bug Copy Issue Report It seems like `$this->prophesize(\Hautz...MailerInterface::class)` of type `object<Prophecy\Prophecy\ObjectProphecy>` is incompatible with the declared type `object<Hautzi\SystemMail...Mailer\MailerInterface>` of property `$mailer`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
100
101			$defaults = $this->mergeDefaults($defaults);
102
103			return new SystemMailer($this->provider->reveal(), $this->parser->reveal(), $this->mailer->reveal(), $locale, $defaults);
104			}
105
106			/**
107			* @param array $defaults
108			*
109			* @return array
110			*/
111			protected function mergeDefaults(array $defaults = [])
112			{
113			return array_replace_recursive([
114			'subject' => '',
115			'replyTo' => '',
116			'from' => [
117			'email' => '',
118			'name' => '',
119			],
120			'to' => [
121			'email' => '',
122			'name' => '',
123			],
124			'cc' => [
125			'email' => '',
126			'name' => '',
127			],
128			'bcc' => [
129			'email' => '',
130			'name' => '',
131			],
132			], $defaults);
133			}
134			}
135

christoph-hautzinger / SystemMailBundle

GitHub Access Token became invalid

SystemMailerTest::testSendWithoutDefaults() A last analyzed 2018-01-12 20:40 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SystemMailerTest::testSendWithoutDefaults() A
last analyzed 2018-01-12 20:40 UTC