christoffer-bolin / weathermodule

src/Weather/WeatherJSONController.php

<?php

namespace Anax\Weather;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;
use Anax\Models\WeatherForecast;
use Anax\Models\GetGeo;

class WeatherJSONController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    public function checkWeatherRestAction()
    {
        $location = $_GET["location"];

        $weather = $this->di->get("weather");
        $type = $this->di->get("request")->getGet("type");
        $geo = new GetGeo();


        if ($type == 'prognosAPI') {
            if (strpos($location, ",") == true) {

It seems like you are loosely comparing strpos($location, ',') of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

                $exploded = explode(",", $location);
                $data = $weather->checkWeather($exploded[0], $exploded[1]);
            } else {
                $res = $geo->getGeo($location);
                if ($res["longitude"] !== null) {
                    $data = $weather->checkWeather($res["latitude"], $res["longitude"]);
                } else {
                    $error = "Felaktig input, prova igen!";
                }
            }
        } elseif ($type == 'historyAPI') {
            if (strpos($location, ",") == true) {

It seems like you are loosely comparing strpos($location, ',') of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

                $exploded = explode(",", $location);
                $data = $weather->checkHistory($exploded[0], $exploded[1]);
            } else {
                $res = $geo->getGeo($location);
                if ($res["longitude"] !== null) {
                    $data = $weather->checkHistory($res["latitude"], $res["longitude"]);
                } else {
                    $error = "Felaktig input, prova igen!";
                }
            }
        }


        $data = [
            "forecast" => $data ?? null,
            "error" => $error ?? null
        ];

        json_encode($data, true);

true of type true is incompatible with the type integer expected by parameter $options of json_encode().

        return [[ $data ]];
    }
}